From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6CA2C47DDB for ; Tue, 23 Jan 2024 07:34:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCD276B0083; Tue, 23 Jan 2024 02:34:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7D676B0085; Tue, 23 Jan 2024 02:34:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCF476B0087; Tue, 23 Jan 2024 02:34:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9E3956B0085 for ; Tue, 23 Jan 2024 02:34:45 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7C381140326 for ; Tue, 23 Jan 2024 07:34:45 +0000 (UTC) X-FDA: 81709763730.23.7FC3B99 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by imf27.hostedemail.com (Postfix) with ESMTP id C06ED40005 for ; Tue, 23 Jan 2024 07:34:42 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of huangpei@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=huangpei@loongson.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705995283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nJJYL1YjJsDPsr7+ECq41QhZttQEtHasD7s6+Aopnfg=; b=VeuWFowawQH9DK8vlp1iiqqKUImxD65MGRb5dXMgXwXsQUXEViq0GU+95gQxxmyKfA2Luw hPT+mJXztPqYuvYicGqi7SZ0imwge8thCDsdXnXCoTaK60vsVoZgoIVn4FxdFkqOIc7HUR GtPL1mP6OjPc2/eecONAjnQmHh68Xaw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of huangpei@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=huangpei@loongson.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705995283; a=rsa-sha256; cv=none; b=bHmA5MjMVl47MNaoAhzXWljqCHd81vsO7HwzH/8xLWquy5spU7+FkT+13lJZwvXqwyN8LB RUphhfbT27QBOutzeI1sfhlMR1WgekuZpJidUhVRDEXQ7reMt3gur++Q7Pwv96UyO3xxfL dwkENVz0j/nfGuJJ2TeEwEs69kIHUUE= Received: from loongson.cn (unknown [111.9.175.10]) by gateway (Coremail) with SMTP id _____8BxXev+QqdlQgEBAA--.4784S3; Wed, 17 Jan 2024 11:01:18 +0800 (CST) Received: from Board-3A3000 (unknown [111.9.175.10]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Axj835Qqdl_JcFAA--.957S2; Wed, 17 Jan 2024 11:01:15 +0800 (CST) Date: Wed, 17 Jan 2024 11:01:13 +0800 From: Huang Pei To: Yajun Deng Cc: Mike Rapoport , Jiaxun Yang , linux-mm@kvack.org, Bibo Mao , linux-mips@vger.kernel.org, Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Thomas Bogendoerfer , linux-kernel@vger.kernel.org Subject: Re: memblock_reserve for unadded region (was: [PATCH] MIPS: loongson64: fix boot failure) Message-ID: <20240117030113.gs2fjs6vydthsc6l@Board-3A3000> References: <20231225093025.23215-1-huangpei@loongson.cn> <731134fd-4b3d-418c-84ee-80646bffcc01@flygoat.com> <20240116122304.qwzy7san2vgspt2x@Board-3A3000> <3fc2f75e-d163-1ad1-009a-0e4538011885@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3fc2f75e-d163-1ad1-009a-0e4538011885@linux.dev> X-CM-TRANSID:AQAAf8Axj835Qqdl_JcFAA--.957S2 X-CM-SenderInfo: xkxd0whshlqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW3Xw15Ww1rWr4UtrW5ZFW7WrX_yoW3Wry7pr 1fJF12krW8Jr18Xr4Utr15Gr1jvw1Fk3WUXrZrJr18ZFyq9r17Xr18Xr1FgFyDJrW8JF1I qF1DX3WIvw1DAwcCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkEb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr0_Gr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41l42xK82IYc2Ij64vIr4 1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1l4IxYO2xFxVAFwI0_JF0_Jw1lx2IqxVAqx4xG67AK xVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrx kI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v2 6r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8Jw CI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07j1WlkUUUUU = X-Gw-Check: 325535f2152225ab X-Rspamd-Queue-Id: C06ED40005 X-Rspam-User: X-Stat-Signature: 5n3hmqf9nbc1ur57swmj5t6xe8itgk6d X-Rspamd-Server: rspam01 X-HE-Tag: 1705995282-28667 X-HE-Meta: U2FsdGVkX19XPzE0cSjIS4XFa8Aq868yN+jelflfBhHfAfeyU2V40f4o68UBEbN7Hnr8cHtxuXQU30lXlfMPRv9UlA1bFX6j40oymB68zH5SFdqEPXt2Eha5/FGTW3kTxchAmvc9+jyt5stkjVkeR7gI9ZqAiDKtVLw0Qy38BE+zLcu5TCf8W7oX9n2ObTDC/8lekRMFiEHHzAf5zGz4HZ+vesTlPcYpq73aA1AJNOWvJpD1d6uxQjT9M/169Ous717vKCIf1vnW9ijWw69tutxH7yZjSvdK6NhfJ639+Z+34JonSwgKTTK4RLnZAuHbiNCIL99zOgW5fDWv1XiMZ/aSVqvNTM3ppb3Joz10u7VFyXRNScvHLGGKd02aFEHVXWuGoDFQ7/MEF/DPHARPrJo5Zlx/0f1SkQgv70LuYMj+FkNeXp8wOBYdHbXyeACr8Fvy2kiIAuByEbV4LINFrovmK8sDt/09u/g9XjOP3B8I8Mypm4mGuO4ZBHk/bORPHaYK9K+ep8Bkytr7+CCqeUsQ7qK7v8aJEVBmzfR4Omp+7A0rlVC52BbjeOizYPU3Lapr4vc6oZb7dNEaOOCljYcN8Tvm30eL8Nb042HZ6SUHG/0jiaLJPg0QRwm5bxe3B05KhGfGZk4t1EM9olkK3v7rVHSgq1sizIPDEGzSLzLIfPJw+OKMdY30ZNgqyL0epjtX3IYAIMRHk1y0/O24zmGpOH+rYv0TfjIY1l5+TA+feDO+2Hfly5cJH2Q+gwnT4+aIvlDU2+kbKGd8DKS8utz9xUIE/cCpp+Hy5jizYE2K7NQUuhI07vpiG3DWJpjgcqC+AyvzbKxsB8ZjurQPTrIL2V84O/py2WrrJBNKEHQZdIhmjjDnDJQY7NQTl9DkkV9W4lg2lUOsMh3eD3cfg8B6n6kko6xZq5fRjj5gXzheeUiu5z6arA7Emmi7QQGtY4oQINRs5fSIv5uBLQi FeZuw3oq uD3B7B18qhtk3ij+7U0WHmN2dNmTFnir/o67VyBzHkO7VlCBfAkUpEsKjWkASHShONoBRv27coi68uEbmT+pdgVkOjE/M/BbWn81NC9BHteC8Ohc017Lwgr7qL8AVy7SHLLjdXGfc0EYsunSRa8ViLH8OcvWCTTX/z9gFiFU4aKorsAnqRjAW8eqMRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 17, 2024 at 10:20:00AM +0800, Yajun Deng wrote: > > On 2024/1/16 20:23, Huang Pei wrote: > > On Tue, Jan 16, 2024 at 10:39:04AM +0200, Mike Rapoport wrote: > > > On Mon, Jan 15, 2024 at 02:08:21PM +0000, Jiaxun Yang wrote: > > > > Hi mm folks, > > > > > > > > Just a quick question, what is the expected behavior of memblock_reserve > > > > a region that is not added to memblock with memblock_add? > > > > > > > > I'm unable to find any documentation about memblock_reserve in comments and > > > > boot-time-mm, but as per my understanding to the code, this should be a > > > > legit usage? > > > Yes, memblock allows reserving memory that was not added to memblock with > > > memblock_add(). > > I think arch/platform specific code should fix this bug, like, > > -------------------------------------------------------------------------- > > //for loongson64 > > memblock_set_node(0, 1ULL << 44, &memblock.reserved, 0); > > > > -------------------------------------------------------------------------- > > > > or maybe memblock provide something like memblock_reserve_node > > Hi pei, > > Can you test the following patch to see if it fixes this bug? > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 2c19f5515e36..97721d99fdce 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -708,6 +708,9 @@ static void __meminit init_reserved_page(unsigned long > pfn, int nid) >         pg_data_t *pgdat; >         int zid; > > +       if (unlikely(nid == NUMA_NO_NODE || nid >= MAX_NUMNODES)) > +               nid = early_pfn_to_nid(pfn); > + >         if (early_page_initialised(pfn, nid)) >                 return; I do not think this fix set the right nid, ONLY arch/platform know that nid int __meminit early_pfn_to_nid(unsigned long pfn) { static DEFINE_SPINLOCK(early_pfn_lock); int nid; spin_lock(&early_pfn_lock); nid = __early_pfn_to_nid(pfn, &early_pfnnid_cache); if (nid < 0) //!!!first_online_node MAY NOT be the node the pfn belong to!!! nid = first_online_node; spin_unlock(&early_pfn_lock); return nid; } > > > > > > In practical we run into uninitialized nid of reserved block problem, should > > > > we fix it > > > > in our usage, or on memblock side? > > > Apparently it's a bug in memblock :( > > > > > > If you revert 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") > > > does the issue disappear? > > Yes, I git bisect this commit. > > > > But I don't think it is a bug in memblock. IMO, memblock_reserve under > > NUMA set nid of reserved region to MAX_NUMNODES, which is the point > > that cause the "memblock_get_region_node from memmap_init_reserved_pages " > > passing a invalid node id(aka MAX_NUMNODES) to "reserver_bootmem_region > > -> init_reserved_page -> early_pfn_to_nid". If arch-specific code DOES NOT > > initialize the nid of reserved region(only it know that), or the reserved > > region NOT within a memblock added by memblock_add, memblock can not > > give a valid node id to the reserved region. Commit 61167ad5fecd ("mm: pass nid to > > reserve_bootmem_region()") just reveals the embarrassment case by an > > out of bound memory access. > > > > > > Thanks > > > > > > > > 在 2023/12/25 09:30, Huang Pei 写道: > > > > > Since commit 61167ad5fecd("mm: pass nid to reserve_bootmem_region()), > > > > > loongson64 booting failed with CONFIG_DEFERRED_STRUCT_PAGE_INIT like > > > > > this: > > > > > ---------------------------------------------------------------------- > > > > > Call Trace: > > > > > [] reserve_bootmem_region+0xa8/0x184 > > > > > [] memblock_free_all+0x104/0x2a8 > > > > > [] mem_init+0x84/0x94 > > > > > [] mm_core_init+0xf8/0x308 > > > > > [] start_kernel+0x43c/0x86c > > > > > > > > > > Code: 10400028 2402fff0 de420000 0203182b 14600022 > > > > > 64420070 00003025 24040003 > > > > > > > > > > ---[ end trace 0000000000000000 ]--- > > > > > Kernel panic - not syncing: Attempted to kill the idle task! > > > > > ---[ end Kernel panic - not syncing: Attempted to kill the idle task! ]--- > > > > > ---------------------------------------------------------------------- > > > > > > > > > > The root cause is no memory region "0x0-0x1fffff" paired with > > > > > memory-reserved region "0x0-0x1fffff" and "0x0-0xfff", with "memblock > > > > > =debug": > > > > > > > > > > ---------------------------------------------------------------------- > > > > > memory[0x0] [0x0000000000200000-0x000000000effffff], > > > > > 0x000000000ee00000 bytes on node 0 flags: 0x0 !!!!here > > > > > memory[0x1] [0x0000000090000000-0x00000000fdffffff], > > > > > 0x000000006e000000 bytes on node 0 flags: 0x0 > > > > > memory[0x2] [0x0000000100000000-0x000000027fffffff], > > > > > 0x0000000180000000 bytes on node 0 flags: 0x0 > > > > > memory[0x3] [0x0000100000000000-0x000010000fffffff], > > > > > 0x0000000010000000 bytes on node 1 flags: 0x0 > > > > > memory[0x4] [0x0000100090000000-0x000010027fffffff], > > > > > 0x00000001f0000000 bytes on node 1 flags: 0x0 > > > > > reserved.cnt = 0x1f > > > > > reserved[0x0] [0x0000000000000000-0x000000000190c80a], > > > > > 0x000000000190c80b bytes flags: 0x0 !!!!oops 0x0-0x1fffff not in memory[0] > > > > > reserved[0x1] [0x000000000190c810-0x000000000190eea3], > > > > > 0x0000000000002694 bytes flags: 0x0 > > > > > ---------------------------------------------------------------------- > > > > > > > > > > It caused memory-reserved region "0x0-0x1fffff" without valid node id > > > > > in "memblock_get_region_node" from "memmap_init_reserved_pages", lead to > > > > > "reserve_bootmem_region-> init_reserved_page -> early_pfn_to_nid()" > > > > > accessing "node_data" out of bound. > > > > > > > > > > To fix this bug, we should remove unnecessary memory block reservation. > > > > > > > > > > +. no need to reserve 0x0-0x1fffff below kernel loading address, since > > > > > it is not registered by "memblock_add_node" > > > > > > > > > > +. no need to reserve 0x0-0xfff for exception handling if it is not > > > > > registered by "memblock_add" either. > > > > > > > > > > Fixes: commit 61167ad5fecd("mm: pass nid to reserve_bootmem_region()) > > > > > Signed-off-by: Huang Pei > > > > > --- > > > > > arch/mips/kernel/traps.c | 3 ++- > > > > > arch/mips/loongson64/numa.c | 2 -- > > > > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c > > > > > index 246c6a6b0261..9b632b4c10c3 100644 > > > > > --- a/arch/mips/kernel/traps.c > > > > > +++ b/arch/mips/kernel/traps.c > > > > > @@ -2007,7 +2007,8 @@ unsigned long vi_handlers[64]; > > > > > void reserve_exception_space(phys_addr_t addr, unsigned long size) > > > > > { > > > > > - memblock_reserve(addr, size); > > > > > + if(memblock_is_region_memory(addr, size)) > > > > > + memblock_reserve(addr, size); > > > > > } > > > > > void __init *set_except_vector(int n, void *addr) > > > > > diff --git a/arch/mips/loongson64/numa.c b/arch/mips/loongson64/numa.c > > > > > index 8f61e93c0c5b..0f516dde81da 100644 > > > > > --- a/arch/mips/loongson64/numa.c > > > > > +++ b/arch/mips/loongson64/numa.c > > > > > @@ -130,8 +130,6 @@ static void __init node_mem_init(unsigned int node) > > > > > memblock_reserve((node_addrspace_offset | 0xfe000000), > > > > > 32 << 20); > > > > > - /* Reserve pfn range 0~node[0]->node_start_pfn */ > > > > > - memblock_reserve(0, PAGE_SIZE * start_pfn); > > > > > } > > > > > } > > > > -- > > > > --- > > > > Jiaxun Yang > > > > > > > -- > > > Sincerely yours, > > > Mike.