From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2199FC47077 for ; Tue, 16 Jan 2024 21:35:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A8066B007D; Tue, 16 Jan 2024 16:35:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 958886B0087; Tue, 16 Jan 2024 16:35:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 847526B00A9; Tue, 16 Jan 2024 16:35:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 760316B007D for ; Tue, 16 Jan 2024 16:35:11 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 598011C0D7A for ; Tue, 16 Jan 2024 21:35:11 +0000 (UTC) X-FDA: 81686480022.08.B52A75E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 93FF91C0014 for ; Tue, 16 Jan 2024 21:35:09 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=R4TMM6cY; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705440909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qt2LSL3Yx0JYVujVTbSPQ2KgSleIFGYfz6p8x61PGkA=; b=M4EIFCt05kzVlerKHw65JK/8MeASg7LMg7TYwopXReRjhKu49fH4zx/qOrUhWMrdWrML+v 2p417CGY1UcN1TH74VlO3gmAhlXRz5phxsptsNFPm6M2TfSWcrSxSaEoUEwN0v/6gT8xKz LzycGZYV9RO0be94AKUncWLEzQhAG4A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705440909; a=rsa-sha256; cv=none; b=SSlgXK4bcDpJbao/t5OiS8bwcx4EdYNUIOnly+bc2koCQ56/9LtokKGJy3hWSXJQ6GwXx7 Pot+xB4jgFLXo8px0obITEYMltns13jFF01NHOWWkn1lesgMib162BkUVEQPFCPCamUpL4 mlghlOAt5FhbSu1i5zbpYRFaNcrkySI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=R4TMM6cY; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8BA18614B7; Tue, 16 Jan 2024 21:35:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 078C3C433C7; Tue, 16 Jan 2024 21:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1705440908; bh=bPen2UlJBQHqlE5Ug6ywd00xGmHMjUIJMoNwx2nzRs8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R4TMM6cYbYJ6c+IO6jgzz2hg7i3Wdcfr68C0CGqHuWeTiOtSD/q+pfKhJTU3KvReL oLztrJzfYcnzY1pK4BhyAtmaEDL4VCYQNE3z9lHMMqbYJhfm2yOj5sgSjQBvMnj+DU xDATszVOytHlHxzq0miFlHmn8NFyU34NeQOHVvh4= Date: Tue, 16 Jan 2024 13:35:03 -0800 From: Andrew Morton To: Yosry Ahmed Cc: Matthew Wilcox , Johannes Weiner , Vlastimil Babka , Christoph Hellwig , Nhat Pham , Domenico Cerasuolo , konrad.wilk@oracle.com, vitaly.wool@konsulko.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kill frontswap Message-Id: <20240116133503.4fb4ea28db43989795a6915d@linux-foundation.org> In-Reply-To: References: <20230714194610.828210-1-hannes@cmpxchg.org> <20230717141250.GA866068@cmpxchg.org> <901409ed-504b-9500-54d8-e42f832e07b0@suse.cz> <20230717160227.GA867137@cmpxchg.org> <20240116120944.01f25e65d13f0fc7e2a2df34@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: f66oeofd74kjzay4z8z7egw6a6x8u3cm X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 93FF91C0014 X-Rspam-User: X-HE-Tag: 1705440909-922573 X-HE-Meta: U2FsdGVkX18tlcklSacq3YjdahH0IdoGm4DrbXq9mZXBss3BrKpq2rtgTZhklOUKycp5gZHJ321LUwLg06DafnZoV/MYksooS1H1sRcW5tsUAcglG1RUe8K5nS8bU+81ZftiAUKNs/iqtlXvwn8xZWvQMq3t87IB2IXzdQVY6vJjNJs4whJ0L4hcgf2UMjguRbOsyxD2t1DYZBPqLct27r8DLEeXoVpDEMUX9o46vAhKTaOlf0k8KMHfD0b71doUj5Dq3SuKh4+61EgEA8JnWiYy7YUaqy3Iq/LfdQwBk2uh88FB1DDoqI4WQ6IDSobSxye+QI4IA2u4q4GVTYzv5snPuwyTOjwgcenGCp0du1Go+23PyQbLsXcd2mPEGTJYVFqXG9b3+jL/lvmaEoXRuZWGhW70hjUavyofYkbBEeX1uOag7vri3FvYMhJzWVByqjUiqlNatuRTf+uajyWzgKy0J8gB50D0sFI1XSAP/syqA9+bT+NoD/eBnOg0IsK4Fru6v3rnCt6Mf2ZSlnEPYjcXVjwFMIVBIsEZrPRPyEgcaWXHLWuq7S/t1R07vE6Vny98RI73VHBpltuhutNC/UzuGrjbGJnRuO/Pq15KVv5IE45rMoWhEVt87q8AaKwBf5OcqUuhNPqZOIcrO+CyTHebEeGNTPzQorJbANxhKiARzg53Uxm0vjpeMCTyNJOrCUxHIWUclTzYxMrRb9pWd/ppR+iIjq4wxYx7c1tEjzam2sqPsr6yHp2qetmwLAAOlYquG+GCtcuGdmYO25/mUFUM3t7+AojtTAx4RcpxJVQwhhhimKbdCJJtTpAUyl9OflB8+A0iWqud3pOYfz5x3ck/9ncgaqvA/lBVnt8d9K5PP+7o+qMWVbmjnV5W+F5vds38JMqSi6oO7pZTAOJj3X5OWDE0U/29zKbL8RLjihPpuTLEXxshr1FYl8AenqrxzyxCM6E5B3GhUq8ZvDR jTXblQvz FaCeV6kDKPqUC6VKXdIUG6xWzR3SzAdtIt7zzTsvQ2CitqgUawEtrHAObalGd+179Zmsxm0aUT4p5Ulzipl5cStY/TJNESbOM8HDLYxBr5FnrAxS30xl7OC2GTf+dGSvyTeE5S8msfxEaWXPP27CDvY8GwnTTARAiBxclFR9uqigUbglyhg81P0h421kRwM7rUzuXhAFenfxa8yvChoHFcWtvsXCQTJwroUgE4xJ2WeHLkP7hSIUyWy8+jJV9EtkF9+Hc0mVp55oPdm3TcO1+wKkfUqxf9AOx/ghqB6stnjuaqCbdR1hYK+zl7yrdF3NCp7J8ApPf+cEqaYMKV8sFt6+sJsLkYE2Jk/uo8iuUkRbKS8i2X+Nu/gEbQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 16 Jan 2024 12:22:03 -0800 Yosry Ahmed wrote: > On Tue, Jan 16, 2024 at 12:18 PM Matthew Wilcox wrote: > > > > On Tue, Jan 16, 2024 at 12:09:44PM -0800, Andrew Morton wrote: > > > On Mon, 17 Jul 2023 12:02:27 -0400 Johannes Weiner wrote: > > > > > > > The only user of frontswap is zswap, and has been for a long > > > > time. Have swap call into zswap directly and remove the indirection. > > > > > > This falls afoul of "mm: zswap: multiple zpools support". Could we > > > please have a version against mm-unstable or linux-next? > > > > Did this email get caught in a timewarp? Or is it referring to > > something that isn't commit 42c06a0e8ebe from six months ago? > > +1. Both of these changes have been in Linus's tree for a while now. > Perhaps Andrew had this email prepared a while ago and never sent it, > and ended up fixing the problem himself. erp, sorry, Flushing out the drafts folder after a long flight. On a wifi-free airline, wtf.