From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F03C8C47077 for ; Tue, 16 Jan 2024 12:23:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E8866B006E; Tue, 16 Jan 2024 07:23:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49AD26B0072; Tue, 16 Jan 2024 07:23:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 362F16B007B; Tue, 16 Jan 2024 07:23:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 259876B006E for ; Tue, 16 Jan 2024 07:23:20 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D79501A09B9 for ; Tue, 16 Jan 2024 12:23:19 +0000 (UTC) X-FDA: 81685089318.21.8573C2A Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by imf08.hostedemail.com (Postfix) with ESMTP id 05A5A160018 for ; Tue, 16 Jan 2024 12:23:15 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of huangpei@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=huangpei@loongson.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705407797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nPpdWvp+fNZD1v/JNtc3AdzYlOl9DGhKdrLjBoFFoxk=; b=QHv76UZDcN6EuBX1VSGopUi71z8xS9ve4SXx/9NkfEt+dKuGJC5Lstdk8khdjQYS9r8dYE 9Hp4Pp3M7HZqR7sBmwKTIafOONP5JGA+w8r+M3m1xNL6YJsdYnAfdu1kcVZ2hY+SePIvMP XiHj3JH/iqh41LV1dyib0ZXEDJk+Wlk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of huangpei@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=huangpei@loongson.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705407797; a=rsa-sha256; cv=none; b=YrOeKBq2bUcx5zCoH8eFyEwK20YkIhTLxIhd6WNQNC2KRZ2mYs6s9BwTEut6c9XDKEBtAq LxFAQp80NZybNfwdZOT5q8WqEYPZl5UWe0mWNJjURwI+/2zlBSo9ZQuJpBoMi9Zhi5LzgI eN39gcy1XNkqcidRE6C9mbyIReRHLUc= Received: from loongson.cn (unknown [111.9.175.10]) by gateway (Coremail) with SMTP id _____8CxSPAsdaZlSrIAAA--.3690S3; Tue, 16 Jan 2024 20:23:08 +0800 (CST) Received: from Board-3A3000 (unknown [111.9.175.10]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxzM4odaZlJAcEAA--.827S2; Tue, 16 Jan 2024 20:23:07 +0800 (CST) Date: Tue, 16 Jan 2024 20:23:04 +0800 From: Huang Pei To: Mike Rapoport Cc: Jiaxun Yang , linux-mm@kvack.org, Bibo Mao , linux-mips@vger.kernel.org, Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, Yajun Deng Subject: Re: memblock_reserve for unadded region (was: [PATCH] MIPS: loongson64: fix boot failure) Message-ID: <20240116122304.qwzy7san2vgspt2x@Board-3A3000> References: <20231225093025.23215-1-huangpei@loongson.cn> <731134fd-4b3d-418c-84ee-80646bffcc01@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CM-TRANSID:AQAAf8DxzM4odaZlJAcEAA--.827S2 X-CM-SenderInfo: xkxd0whshlqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW3Xw15WFW8WryfKr13Zw1kJFc_yoWxGr45pr 13JF17Cr48Jr18X3y8tr15Wr10v3WFkF1UXrZrJr18ZryDur17Xr18Jr1rWFyDJrWxJF1I qF1DXF12vw1DAwcCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUk0b4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv 67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41l42xK82IYc2Ij64 vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8G jcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2I x0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK 8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I 0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjxUcVc_UUUUU X-Rspam-User: X-Stat-Signature: 1uytyt899iburxkiw3on58uzab5n6bjp X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 05A5A160018 X-HE-Tag: 1705407795-932721 X-HE-Meta: U2FsdGVkX1+kxN8N1FAGXIsZiSpGShOzf2EiItij3T+WZZECTA4CkO0Zg2kakQwD+ZIBD2VXAsH5FIDxhp9uzVgbZAIZXriq8imchHSZ4fIMBNDaVz2MWGQoJv5N5z+s8IFu5+BJZFsedq/LuXgSEGUOiPNfwL74bQ4Yd1Av7e62uzzzfPY2FDxoU972yICjqsenZPv6SBVL9Ayqwp+2tyyzrXGxhsM/KrGj3taSprxozXH8rfnVDAd8SnUJCFA6zdtPnKvrMG6wqVCaFqxxzCl+ZsCJSuACPwfO3eFSdtMaRHSPQOFtbmC6d+2gT7s6cLMLhpt1ilqxiVsmSVQuQ6PfT1ZHc7s/ejOiTXHf511l0kEe3AYSs77j7uFS2O6aPt4ieN1e//wV+K6Uje/otDpWkVuWMXO0uKU9vt43/VdvG2fKkvGC4W2MqDwCPekIgPB62sj7xD1f9atW1oI2kypkDizkN4Ya/WRI5dnMFAcDwfNvP8uSFb6A34tlEpFpP72Q+u1DsMWDRAOBRewcqUbJ+EU9jKBsiZNJx4pEOPPaJy91Z4TJyC8uLe2a7xqn36Ga+8uEjKS+OKVsHh9E3rGKNIIrLFlGD356LtgYPcBPnk6YMbG/5I8bv5vThOhi6jUNqEy4Dc54ldSZRlPuNRpapuPLz35DLczY9YZJ1L1hTyV9yb8tzt9nuA/6B7VKgeQdwS3HELRkZgf/toy01x9Tx8mqEB8Z3+rC4G9EJBkXcVA+DrKqEsZk4oHk7gCdgsLJN5trQyOjiKt9HD4yrafE8B0dH8uQOQD40J7xU17mUfMSx2+DWvOZy5mXmWHAQnGxaaq10fycL8URsVcfre6v1p428c5fk774J/BVaO76ZgDkKJERaz+ohScrFOErBIjKJGQQWpxgGC4pDuHBXdFlBjZonpCERX1NyNXhaOKizhhm4GK86EABEkl7tZ28Q1ibwDyAVot2XcTPSXx r1uUHWty ABCHD7lzv9UITKtL0CXC0O+TuC54iNHK5/rH+He5UI2jqktyRO5M+k4XbBHF2r4EEaFBQAG0u3hQTl3K9FYV7jDSq3BHNd3HI3hDYQZIltGmx5eeEXdoDa5770TTOLkh0j6c2ainRI59nVoU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 16, 2024 at 10:39:04AM +0200, Mike Rapoport wrote: > On Mon, Jan 15, 2024 at 02:08:21PM +0000, Jiaxun Yang wrote: > > Hi mm folks, > > > > Just a quick question, what is the expected behavior of memblock_reserve > > a region that is not added to memblock with memblock_add? > > > > I'm unable to find any documentation about memblock_reserve in comments and > > boot-time-mm, but as per my understanding to the code, this should be a > > legit usage? > > Yes, memblock allows reserving memory that was not added to memblock with > memblock_add(). I think arch/platform specific code should fix this bug, like, -------------------------------------------------------------------------- //for loongson64 memblock_set_node(0, 1ULL << 44, &memblock.reserved, 0); -------------------------------------------------------------------------- or maybe memblock provide something like memblock_reserve_node > > > In practical we run into uninitialized nid of reserved block problem, should > > we fix it > > in our usage, or on memblock side? > > Apparently it's a bug in memblock :( > > If you revert 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") > does the issue disappear? Yes, I git bisect this commit. But I don't think it is a bug in memblock. IMO, memblock_reserve under NUMA set nid of reserved region to MAX_NUMNODES, which is the point that cause the "memblock_get_region_node from memmap_init_reserved_pages " passing a invalid node id(aka MAX_NUMNODES) to "reserver_bootmem_region -> init_reserved_page -> early_pfn_to_nid". If arch-specific code DOES NOT initialize the nid of reserved region(only it know that), or the reserved region NOT within a memblock added by memblock_add, memblock can not give a valid node id to the reserved region. Commit 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") just reveals the embarrassment case by an out of bound memory access. > > > Thanks > > > > 在 2023/12/25 09:30, Huang Pei 写道: > > > Since commit 61167ad5fecd("mm: pass nid to reserve_bootmem_region()), > > > loongson64 booting failed with CONFIG_DEFERRED_STRUCT_PAGE_INIT like > > > this: > > > ---------------------------------------------------------------------- > > > Call Trace: > > > [] reserve_bootmem_region+0xa8/0x184 > > > [] memblock_free_all+0x104/0x2a8 > > > [] mem_init+0x84/0x94 > > > [] mm_core_init+0xf8/0x308 > > > [] start_kernel+0x43c/0x86c > > > > > > Code: 10400028 2402fff0 de420000 0203182b 14600022 > > > 64420070 00003025 24040003 > > > > > > ---[ end trace 0000000000000000 ]--- > > > Kernel panic - not syncing: Attempted to kill the idle task! > > > ---[ end Kernel panic - not syncing: Attempted to kill the idle task! ]--- > > > ---------------------------------------------------------------------- > > > > > > The root cause is no memory region "0x0-0x1fffff" paired with > > > memory-reserved region "0x0-0x1fffff" and "0x0-0xfff", with "memblock > > > =debug": > > > > > > ---------------------------------------------------------------------- > > > memory[0x0] [0x0000000000200000-0x000000000effffff], > > > 0x000000000ee00000 bytes on node 0 flags: 0x0 !!!!here > > > memory[0x1] [0x0000000090000000-0x00000000fdffffff], > > > 0x000000006e000000 bytes on node 0 flags: 0x0 > > > memory[0x2] [0x0000000100000000-0x000000027fffffff], > > > 0x0000000180000000 bytes on node 0 flags: 0x0 > > > memory[0x3] [0x0000100000000000-0x000010000fffffff], > > > 0x0000000010000000 bytes on node 1 flags: 0x0 > > > memory[0x4] [0x0000100090000000-0x000010027fffffff], > > > 0x00000001f0000000 bytes on node 1 flags: 0x0 > > > reserved.cnt = 0x1f > > > reserved[0x0] [0x0000000000000000-0x000000000190c80a], > > > 0x000000000190c80b bytes flags: 0x0 !!!!oops 0x0-0x1fffff not in memory[0] > > > reserved[0x1] [0x000000000190c810-0x000000000190eea3], > > > 0x0000000000002694 bytes flags: 0x0 > > > ---------------------------------------------------------------------- > > > > > > It caused memory-reserved region "0x0-0x1fffff" without valid node id > > > in "memblock_get_region_node" from "memmap_init_reserved_pages", lead to > > > "reserve_bootmem_region-> init_reserved_page -> early_pfn_to_nid()" > > > accessing "node_data" out of bound. > > > > > > To fix this bug, we should remove unnecessary memory block reservation. > > > > > > +. no need to reserve 0x0-0x1fffff below kernel loading address, since > > > it is not registered by "memblock_add_node" > > > > > > +. no need to reserve 0x0-0xfff for exception handling if it is not > > > registered by "memblock_add" either. > > > > > > Fixes: commit 61167ad5fecd("mm: pass nid to reserve_bootmem_region()) > > > Signed-off-by: Huang Pei > > > --- > > > arch/mips/kernel/traps.c | 3 ++- > > > arch/mips/loongson64/numa.c | 2 -- > > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c > > > index 246c6a6b0261..9b632b4c10c3 100644 > > > --- a/arch/mips/kernel/traps.c > > > +++ b/arch/mips/kernel/traps.c > > > @@ -2007,7 +2007,8 @@ unsigned long vi_handlers[64]; > > > void reserve_exception_space(phys_addr_t addr, unsigned long size) > > > { > > > - memblock_reserve(addr, size); > > > + if(memblock_is_region_memory(addr, size)) > > > + memblock_reserve(addr, size); > > > } > > > void __init *set_except_vector(int n, void *addr) > > > diff --git a/arch/mips/loongson64/numa.c b/arch/mips/loongson64/numa.c > > > index 8f61e93c0c5b..0f516dde81da 100644 > > > --- a/arch/mips/loongson64/numa.c > > > +++ b/arch/mips/loongson64/numa.c > > > @@ -130,8 +130,6 @@ static void __init node_mem_init(unsigned int node) > > > memblock_reserve((node_addrspace_offset | 0xfe000000), > > > 32 << 20); > > > - /* Reserve pfn range 0~node[0]->node_start_pfn */ > > > - memblock_reserve(0, PAGE_SIZE * start_pfn); > > > } > > > } > > > > -- > > --- > > Jiaxun Yang > > > > -- > Sincerely yours, > Mike.