From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D732DC4706C for ; Tue, 16 Jan 2024 03:28:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2DBE6B0080; Mon, 15 Jan 2024 22:27:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDE456B0082; Mon, 15 Jan 2024 22:27:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA5746B0083; Mon, 15 Jan 2024 22:27:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CB8676B0080 for ; Mon, 15 Jan 2024 22:27:59 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 991ABA1DCE for ; Tue, 16 Jan 2024 03:27:59 +0000 (UTC) X-FDA: 81683740278.01.3A76E4A Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by imf12.hostedemail.com (Postfix) with ESMTP id ADA0340009 for ; Tue, 16 Jan 2024 03:27:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of huangpei@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=huangpei@loongson.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705375677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uk2pmS78y3RhT9/ryPViS1ug1mvZTfklBCSD/ZrRDdQ=; b=8er9TarVrJgXIibHNaTxDn/QwFv6oHWdOn4IKgeODwLgCjkdkCCq+fZZKtcCv++CBrqamv OV2TQuRwj4mZkL2ColuXWKQ2HMTf1aPdVJWBjIsRp6QW4TMs48AxwFbWz8k219ZnpqOTV4 Ru3ZXhixHANSwyrGdxUh3EwIhsp/Fo8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of huangpei@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=huangpei@loongson.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705375677; a=rsa-sha256; cv=none; b=8D0g2+rvR9VNP9KWHBiW64/W8Pyo4lUeJcYvHIxNg7G4NCvtoHO3LTWSUlLzxUo51xD5db Wqny/SkiBVVqAtknE6Hdvai3ZLCm3iMIS+kA4Xi/97l1aBLMLt/bMm3FRmHTyv39V5SduK 0Nu/goz18EkaNcc0B21ZvlWBUG5+Dbo= Received: from loongson.cn (unknown [111.9.175.10]) by gateway (Coremail) with SMTP id _____8Cxruu296Vldo8AAA--.2473S3; Tue, 16 Jan 2024 11:27:50 +0800 (CST) Received: from Board-3A3000 (unknown [111.9.175.10]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxAOWy96VlBzADAA--.649S2; Tue, 16 Jan 2024 11:27:48 +0800 (CST) Date: Tue, 16 Jan 2024 11:27:46 +0800 From: Huang Pei To: Jiaxun Yang Cc: rppt@kernel.org, linux-mm@kvack.org, Bibo Mao , linux-mips@vger.kernel.org, Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Thomas Bogendoerfer , linux-kernel@vger.kernel.org Subject: Re: memblock_reserve for unadded region (was: [PATCH] MIPS: loongson64: fix boot failure) Message-ID: <20240116032746.rh2jh6gihykzorg5@Board-3A3000> References: <20231225093025.23215-1-huangpei@loongson.cn> <731134fd-4b3d-418c-84ee-80646bffcc01@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <731134fd-4b3d-418c-84ee-80646bffcc01@flygoat.com> X-CM-TRANSID:AQAAf8CxAOWy96VlBzADAA--.649S2 X-CM-SenderInfo: xkxd0whshlqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoWxAF48Zr4UtrW3GFyUXF13trc_yoWrKw17pr 13JF17Cr48Jr1UXrW8Jr15Wr1xXa1Fk3WUJrZrJr18uF1Dur17Xr18JryrXFyDJrWUGF1I qFyDXr1jvw1DAwcCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUyEb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6r4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27w Aqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE 14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU8zwZ7UUUUU== X-Rspam-User: X-Stat-Signature: pu8zffcyx9epny96gyeep8z3pw5wecq4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: ADA0340009 X-HE-Tag: 1705375675-212455 X-HE-Meta: U2FsdGVkX1/EIb+PFYwEa/UwJfUzwhQxwMsWBke+ohKa4tU0LXr8U+a6vFQ4fQqNggjnGyotQRrHtviueMw47a05cR05k9wOrx+P9U9ke+mZc0rTQ3pcesLG8uiNfgXm/gyAgA8/oBgKMHJrQ7215jb2XilMnD+D+l0bZI5tYlFsEOVt7NME51TKNnAWver+q8lXZLK6ARfrZAsljDT+gOV6PhiOAFY8E574yzkaP9rOeMlHRvPw421v1HoDp2gaJwt9RsIXoxlhcT37nVA7WrH/kbPaxHZyF07XnnY6IXaGocThkph+RZvonlZ25C67Um5w7ldYICuFzc+Zm7bwLDafHa6IcUCrcn+F1rnMG9K1nnhoD/fpCtWQKBdF/HSvIf+ReXJQkbxJqaM90q+4hS7ZDi1X1oQbaeQwfrrKry2xbmiPvOVUUzt+Hc8ITAB+Ok6zOBc9AFGKAfDb/81Vec5FILZE2MPK5HEttGMhYEq6kk22F/IbnKMMq1qNbMV6cz77LiVAXwJR0h300PK1ebJob5gbP3G150a7WR/UtGmHyn8Zbrovo3WrqOOwkvgjMsAJwbzSXYWD6rvQ3yCP1Ii6Q5yOru6za0yYd+oxuAJwyAbwHLL4pPI4SYekrC6z/ApsJKr0H5M7WUNOZmnKLtjCbFCKZZs7Ivh4rMbJg8++6PtfalQi69Y8920VTGje+ZCgb4mLGjaEhI5ud0CcFc/0TfnCf8cHDnB6ZffV7P5Kxh4CAZ0oVDtfwK7N6ZBb93kX4LIDOcFhbi5KxOJ/mHVCVc3H9hrCmuzGb+l9ivJYcOJQIlQB6p7Li52zAyXdg49z2ZxxoPVKA62kV3M2+L0yVGG4agJs+BIk57fHEp3TpTCHsZtCjwlELORWf79hBedtfbk/1JfbSvfA+hlRLjYAxvj/BfaenK3i0NDovRGWMcIo6qaPNhodDOKWgyjHiwEAlB69mzTasS44iL3 qMQMUN8L fWauhBEtz2bJ+/IaZC/mjcBAvXBDeWtUw7ZueB0lQABp9aguunidURABlBWi1jg/lQe0+Jtxe/fvYwppLCp+9WazC8flnM5Wx+3IGsDVsdbCxfbTWjc2fKDlMP75fR82llw/z9bDA6ihDgBQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 15, 2024 at 02:08:21PM +0000, Jiaxun Yang wrote: > Hi mm folks, > > Just a quick question, what is the expected behavior of memblock_reserve > a region that is not added to memblock with memblock_add? > > I'm unable to find any documentation about memblock_reserve in comments and > boot-time-mm, but as per my understanding to the code, this should be a > legit usage? > > In practical we run into uninitialized nid of reserved block problem, should > we fix it > in our usage, or on memblock side? > > Thanks I have same question. Kernel make a dmi info(see dmi_string, or add memblock=debug) copy. If reserved SMIBIOS memory belong to kernel, no need to make a copy. But if not, how could it be included in a range of memblock.memory? > > 在 2023/12/25 09:30, Huang Pei 写道: > > Since commit 61167ad5fecd("mm: pass nid to reserve_bootmem_region()), > > loongson64 booting failed with CONFIG_DEFERRED_STRUCT_PAGE_INIT like > > this: > > ---------------------------------------------------------------------- > > Call Trace: > > [] reserve_bootmem_region+0xa8/0x184 > > [] memblock_free_all+0x104/0x2a8 > > [] mem_init+0x84/0x94 > > [] mm_core_init+0xf8/0x308 > > [] start_kernel+0x43c/0x86c > > > > Code: 10400028 2402fff0 de420000 0203182b 14600022 > > 64420070 00003025 24040003 > > > > ---[ end trace 0000000000000000 ]--- > > Kernel panic - not syncing: Attempted to kill the idle task! > > ---[ end Kernel panic - not syncing: Attempted to kill the idle task! ]--- > > ---------------------------------------------------------------------- > > > > The root cause is no memory region "0x0-0x1fffff" paired with > > memory-reserved region "0x0-0x1fffff" and "0x0-0xfff", with "memblock > > =debug": > > > > ---------------------------------------------------------------------- > > memory[0x0] [0x0000000000200000-0x000000000effffff], > > 0x000000000ee00000 bytes on node 0 flags: 0x0 !!!!here > > memory[0x1] [0x0000000090000000-0x00000000fdffffff], > > 0x000000006e000000 bytes on node 0 flags: 0x0 > > memory[0x2] [0x0000000100000000-0x000000027fffffff], > > 0x0000000180000000 bytes on node 0 flags: 0x0 > > memory[0x3] [0x0000100000000000-0x000010000fffffff], > > 0x0000000010000000 bytes on node 1 flags: 0x0 > > memory[0x4] [0x0000100090000000-0x000010027fffffff], > > 0x00000001f0000000 bytes on node 1 flags: 0x0 > > reserved.cnt = 0x1f > > reserved[0x0] [0x0000000000000000-0x000000000190c80a], > > 0x000000000190c80b bytes flags: 0x0 !!!!oops 0x0-0x1fffff not in memory[0] > > reserved[0x1] [0x000000000190c810-0x000000000190eea3], > > 0x0000000000002694 bytes flags: 0x0 > > ---------------------------------------------------------------------- > > > > It caused memory-reserved region "0x0-0x1fffff" without valid node id > > in "memblock_get_region_node" from "memmap_init_reserved_pages", lead to > > "reserve_bootmem_region-> init_reserved_page -> early_pfn_to_nid()" > > accessing "node_data" out of bound. > > > > To fix this bug, we should remove unnecessary memory block reservation. > > > > +. no need to reserve 0x0-0x1fffff below kernel loading address, since > > it is not registered by "memblock_add_node" > > > > +. no need to reserve 0x0-0xfff for exception handling if it is not > > registered by "memblock_add" either. > > > > Fixes: commit 61167ad5fecd("mm: pass nid to reserve_bootmem_region()) > > Signed-off-by: Huang Pei > > --- > > arch/mips/kernel/traps.c | 3 ++- > > arch/mips/loongson64/numa.c | 2 -- > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c > > index 246c6a6b0261..9b632b4c10c3 100644 > > --- a/arch/mips/kernel/traps.c > > +++ b/arch/mips/kernel/traps.c > > @@ -2007,7 +2007,8 @@ unsigned long vi_handlers[64]; > > void reserve_exception_space(phys_addr_t addr, unsigned long size) > > { > > - memblock_reserve(addr, size); > > + if(memblock_is_region_memory(addr, size)) > > + memblock_reserve(addr, size); > > } > > void __init *set_except_vector(int n, void *addr) > > diff --git a/arch/mips/loongson64/numa.c b/arch/mips/loongson64/numa.c > > index 8f61e93c0c5b..0f516dde81da 100644 > > --- a/arch/mips/loongson64/numa.c > > +++ b/arch/mips/loongson64/numa.c > > @@ -130,8 +130,6 @@ static void __init node_mem_init(unsigned int node) > > memblock_reserve((node_addrspace_offset | 0xfe000000), > > 32 << 20); > > - /* Reserve pfn range 0~node[0]->node_start_pfn */ > > - memblock_reserve(0, PAGE_SIZE * start_pfn); > > } > > } > > -- > --- > Jiaxun Yang