From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7394C3DA79 for ; Mon, 15 Jan 2024 19:54:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 235096B0082; Mon, 15 Jan 2024 14:54:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E4A26B0083; Mon, 15 Jan 2024 14:54:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 085A96B0085; Mon, 15 Jan 2024 14:54:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ED3BF6B0082 for ; Mon, 15 Jan 2024 14:54:39 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C9EF2A1D77 for ; Mon, 15 Jan 2024 19:54:39 +0000 (UTC) X-FDA: 81682597878.21.C3D0495 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf06.hostedemail.com (Postfix) with ESMTP id 833DD18000A for ; Mon, 15 Jan 2024 19:54:37 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=YBn4l2yZ; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf06.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705348478; a=rsa-sha256; cv=none; b=vuP3QtYnsx10shV5jfzbYddK5VutjNSm/Wdd3zrw2nG+hQ8PgEXK12z2N4XPy1Aamwz0K2 yBZcDztaYVLwICq2cQT5T7w2aEyZaARhYSXmwhouXe4b9//F6EEJZqoX6q40yx050EygLL SUZ5cT5v8ybc4rW5qrY+mizTK+Xkhb8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=YBn4l2yZ; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf06.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705348478; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I4BKZtuvMD15eVn77Cz+lQijb+Y1S7XFupTLxcf4oE0=; b=qL/87gocTO7wyscpu7rTnSRzWr8PJjAn+mpHRni1adIEl9KQFfW9MVTxdv0DqSgiaY2MtZ i6mQEc4tIMFXGmX/bEgnuX3Wk5d3DBfgpUbpqjcfAlOFzpSRyhFYb4I/vTZpq6Vp7PtqJo BWyy43tmf0MzWLArv6dSSb34iVs0Bjs= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 56E6340E00C5; Mon, 15 Jan 2024 19:54:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id lrd4RczTfciN; Mon, 15 Jan 2024 19:54:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1705348470; bh=I4BKZtuvMD15eVn77Cz+lQijb+Y1S7XFupTLxcf4oE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YBn4l2yZDBQIdtVHUG8a/mOmP6/3Gsh4aeEBRtuGaPtmexmHp9kFY1/oxtGOL4UYa byrLcZvvavZIyKQXHlRtjcatJJJr29tl0I+HSVSOF91YUAIdFzSMAks3ALhb/PETHD H9uYUaveM/qbFTCzNqzcFTy/1/KR0wThYlzGFZBfJiKh8G3B44+eMQU0jAUkQsXwms qS77R7rzVDiTXfPSUwPf5YUCIGq4M64Md7a5So9m6Fr/PdJrBkgXCNjZt87URhdQI9 M9pcMqxja2+9qVAxfGVlpWOhCjJ3kRR65KwNUr03se5p7bKnEJXofDla+jH7XZq6nS yJiQURs13J92fCnMQWuSv+rdJrAF5x6iljCW6KoJEnTBn/ewoimrWG2pwBe1k5YECH AjGDCzLWCMgLH4KpDxHieorQmia3aXKaP79KMaeOYcQw9fTRDDC4ZcHF/aPSGhb0DX IS3ma6xVNYVSSbVPXjCKH1jOTXKUWjOZR7un2qb4kwf68oKEHLirOqbZl2Bu2I85Lg C2BWKxYh21FEPaiI8g49UfEtWR64ZOenqxUUPDDitJY3hvPwqG4LzrwHwB/4yv/QmP VX8c+VRNBbgKnLBFjxesXBr0SLgN5UDSA6TJ/NxCX9+OJZRmK9C8pKIdnNL3F4fhyQ JqZY8OigMA3mcN8cIvohNEEA= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AF81F40E01A9; Mon, 15 Jan 2024 19:53:52 +0000 (UTC) Date: Mon, 15 Jan 2024 20:53:46 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, "liam.merwick@oracle.com Brijesh Singh" , Jarkko Sakkinen Subject: Re: [PATCH v1 13/26] crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP Message-ID: <20240115195334.GHZaWNPiqbTg82QS_A@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-14-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231230161954.569267-14-michael.roth@amd.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 833DD18000A X-Stat-Signature: j5e56p7twxupabwsixsumhb15gf46jr1 X-HE-Tag: 1705348477-243093 X-HE-Meta: U2FsdGVkX18RuVIYI5GWYPymwf0kAPJGK9+B5XyEjIztLWRB6FoUrQ1NwwRxziFEng6IuAfFWxps4qPDKfnRyi1QO/ltvnKINdZc8TGm0FLvIb3owaLtjxHn2UXHj1W3BuqfoegxEQYyLio96URfnaZsJ4VvluRw8gNflGs9q/M/MEwh77AF51XB1vLzpV+SNRS6s+3nvobACt4Wjygqgl+w4pHN6D3q3DZ/3yY/zdM7q7Kp6bmaRWZkIqgM0cFy78kCXi5uzstKarauekt4Qzg/r4PgcNY2fCq6XNdd0BXZu7MiIKt613DhYWi+2aQ9jQuZs3JaNkeAPbUGnJ53R0ePgVxgRXyyKdfXnAn9Iva2ib2PSxEJ1vQLJQPDfefsj5NPNHceO/+4TODxHHdPZ/MaCV8EheJe2Q0XxKjQ2hNb9b/LCRsCLedvNPVJDUxqz6RRMM0wuslA+YXzt93Qe6WlY1A21pXKN5nUCapgXpWa0HfRTnNV+RkUCCrXu4GeJ9TzhyeZlASPkI9osIrtQ+AXzwlmW6aWXXAglrJctTB0CeMwAIKWzjGLQ3onPiiLMB5enmd4LfvERliYnciKXv0ySXB1byOSN5Uhtst50g9ApRojKnHAFTl7e/w+GIglvIPA4qspLsK87KwGYV9ilcaSNBAaN2yw0lq/TyviJI389DM087u+v3lR5CWbHLYf/7jo/ot3ajzAXiS3o9o479LQExup3MMteVPlIMUfhiFONy81Lhkcj1NxfrzezyWy2Cj/epvxUGagIKY3SRE4xzN8lc8AbGO4rILx0Z9gJm3vYKOSxTwuBJjU18U0K8nkTy/HX3b0lMZaERWwJAPP1lJ4P17yhhzTu5GskotvscaRsrAVoHCxMVTyUJv5X19EaNosco53TlcpPC6tCJR8/Hq0yPA92EXuFQrGy3XPAlaoIgvVCOpH2JS7t8nJ0zh02c2FYYpyqrPGRtPFwVG rBOYPOp3 A7cNYE1Oblxci1iPotJCnz1zNaqPG12wzRvA8YAOncu484uIF596IWS2HPqEEB5mxq6cGiALPmu0reZnH1o4qohPrrz0XQH/Y4ydiEjuCX6cavm6rgz5XD1BjtKw4VCzZjahFAiDhxuNxz9Q36ZU1WarI469RnC0+IpON7CHWGJRfMSypi6HTxHH+LkPwCAOPwuRkAT9D42PLAk8AbhK2/FeXro7aVhfPMH0x X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:19:41AM -0600, Michael Roth wrote: > From: Brijesh Singh > > Before SNP VMs can be launched, the platform must be appropriately > configured and initialized. Platform initialization is accomplished via > the SNP_INIT command. Make sure to do a WBINVD and issue DF_FLUSH > command to prepare for the first SNP guest launch after INIT. ^^^^^^ Which "INIT"? Sounds like after hipervisor's init... > During the execution of SNP_INIT command, the firmware configures > and enables SNP security policy enforcement in many system components. > Some system components write to regions of memory reserved by early > x86 firmware (e.g. UEFI). Other system components write to regions > provided by the operation system, hypervisor, or x86 firmware. > Such system components can only write to HV-fixed pages or Default > pages. They will error when attempting to write to other page states "... to pages in other page states... " > after SNP_INIT enables their SNP enforcement. And yes, this version looks much better. Some text cleanups ontop: --- diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 85634d4f8cfe..7942ec730525 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -549,24 +549,22 @@ static int __sev_snp_init_locked(int *error) return 0; } - /* - * The SNP_INIT requires the MSR_VM_HSAVE_PA must be set to 0h - * across all cores. - */ + /* SNP_INIT requires MSR_VM_HSAVE_PA to be cleared on all CPUs. */ on_each_cpu(snp_set_hsave_pa, NULL, 1); /* - * Starting in SNP firmware v1.52, the SNP_INIT_EX command takes a list of - * system physical address ranges to convert into the HV-fixed page states - * during the RMP initialization. For instance, the memory that UEFI - * reserves should be included in the range list. This allows system + * Starting in SNP firmware v1.52, the SNP_INIT_EX command takes a list + * of system physical address ranges to convert into HV-fixed page + * states during the RMP initialization. For instance, the memory that + * UEFI reserves should be included in the that list. This allows system * components that occasionally write to memory (e.g. logging to UEFI - * reserved regions) to not fail due to RMP initialization and SNP enablement. + * reserved regions) to not fail due to RMP initialization and SNP + * enablement. */ if (sev_version_greater_or_equal(SNP_MIN_API_MAJOR, 52)) { /* * Firmware checks that the pages containing the ranges enumerated - * in the RANGES structure are either in the Default page state or in the + * in the RANGES structure are either in the default page state or in the * firmware page state. */ snp_range_list = kzalloc(PAGE_SIZE, GFP_KERNEL); @@ -577,7 +575,7 @@ static int __sev_snp_init_locked(int *error) } /* - * Retrieve all reserved memory regions setup by UEFI from the e820 memory map + * Retrieve all reserved memory regions from the e820 memory map * to be setup as HV-fixed pages. */ rc = walk_iomem_res_desc(IORES_DESC_NONE, IORESOURCE_MEM, 0, ~0, @@ -599,14 +597,13 @@ static int __sev_snp_init_locked(int *error) } /* - * The following sequence must be issued before launching the - * first SNP guest to ensure all dirty cache lines are flushed, - * including from updates to the RMP table itself via RMPUPDATE - * instructions: + * The following sequence must be issued before launching the first SNP + * guest to ensure all dirty cache lines are flushed, including from + * updates to the RMP table itself via the RMPUPDATE instruction: * - * - WBINDV on all running CPUs + * - WBINVD on all running CPUs * - SEV_CMD_SNP_INIT[_EX] firmware command - * - WBINDV on all running CPUs + * - WBINVD on all running CPUs * - SEV_CMD_SNP_DF_FLUSH firmware command */ wbinvd_on_all_cpus(); -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette