From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65378C4707B for ; Mon, 15 Jan 2024 14:26:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA8B46B0080; Mon, 15 Jan 2024 09:26:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B58F56B0081; Mon, 15 Jan 2024 09:26:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A21E16B0082; Mon, 15 Jan 2024 09:26:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8FE976B0080 for ; Mon, 15 Jan 2024 09:26:44 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 191E51A08E9 for ; Mon, 15 Jan 2024 14:26:44 +0000 (UTC) X-FDA: 81681771528.18.F281075 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 348B780004 for ; Mon, 15 Jan 2024 14:26:40 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fTLnPY5W; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705328801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c+AgqPT1yRF7nplxdLHxfTFfqV6C8yg9/yypQbcOtfU=; b=SJUyFxvewCoPy+ijBJKcZ6J1uKU/sKkYG1/Y4zrFiRgej6VbALeOq3TLd6r/jUgzaY0h4x NRzriDMT7Z4FYLLk46YXX6yuIio3W6GBDyTLoPEE21/p3WH6NLso0VYFgO9lqOB34VBZZh eNfQDQP65ZNOBE/m58+SbXYl0+MyyFs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fTLnPY5W; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of oleg@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=oleg@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705328801; a=rsa-sha256; cv=none; b=J6vPGe4x8ZIMV5Pv9fOlgX8eS3YU+eXSJv5/E62dAeeI3T1C5qNPCBU7D+5pBiOwClsuAs EleJDIusSPoFzEs/zLbnFFx0wt+LCRxCv7ZmL2ss83vM03Z6iwUmQPpX58VpmGicyhrihC CKys8Kyu72TlNtEeYofVuS2sgMUjMpM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705328800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c+AgqPT1yRF7nplxdLHxfTFfqV6C8yg9/yypQbcOtfU=; b=fTLnPY5WzPs3FsztyLsyv5EmXLY9vC8xqvcDAH963lIftp6ULtOmDU56763gtRdfHfOndp P3iyHJbQuFLFGGXk2qyqL5VJnhQMuQqn1Q7E3WEeay2ReKAOK2/2/z8b5UxPrDNyjz875Z K098wJzAbcUI3/WqzY8yNHJ+KpLnY5A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-XIHLj4hcNSWG5cYndluMWw-1; Mon, 15 Jan 2024 09:26:35 -0500 X-MC-Unique: XIHLj4hcNSWG5cYndluMWw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 769BC1025887; Mon, 15 Jan 2024 14:26:34 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.7]) by smtp.corp.redhat.com (Postfix) with SMTP id 007421C060B2; Mon, 15 Jan 2024 14:26:30 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 15 Jan 2024 15:25:22 +0100 (CET) Date: Mon, 15 Jan 2024 15:25:18 +0100 From: Oleg Nesterov To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, Jiri Olsa , Ryan Roberts , Andrew Morton , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Namhyung Kim , Ian Rogers , Adrian Hunter Subject: Re: [PATCH v1] uprobes: use pagesize-aligned virtual address when replacing pages Message-ID: <20240115142517.GB18072@redhat.com> References: <20240115100731.91007-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240115100731.91007-1-david@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 348B780004 X-Stat-Signature: ne89asbphm8ifjn9kd3xt5n4zdhu1q5f X-HE-Tag: 1705328800-362037 X-HE-Meta: U2FsdGVkX1+etDIMh1TMOwCt5kAosOiRpFg4c3MnxvOLNY8KhmKQSPy6QSh9H8pPR2j+9EXyAPfwf2Vrmz9kVrstr2Q+xSVxhOicpB9xgelMv8hmCoXBpUCHByPe5xcCdzZxZo7GiRrYUBGz5uOZIUFGPqvHj3f9i/umaNo7SeRqDfqi2UD7iHJez37xQmMHfZmUCIYEqC8qX4Opv/FVTlUoSIT94J0o11W2cHmnEn4WSGRTJIXh2X2dicjdbTMxCf4LVidT2RnZS4lLOYK8pv7anaRK3TlvD9BETEs27E6LTAAJEIo1kh71vRoKs3ySVspYALOePnb3DSKqrxBkJ+NVnklA8BL3EzxPfbhjJ5rdMapwwks7pGAyjQcDlRrr7KrCNwW3+AdmvbE4iiySqMTzKj+yTjORLPpiArXJuMrY6mqZH8wNfddf03W3RrSHctMiHdIaWqch1zw9E1fv3rCtawFw9mOydb+VgSQNd68SHw1jphlLK3zzoNVhGO6mdW6TO1seXV2579iv6avmiNanK4GCmo5iKp7mt8xU0nkxbHwdH0ruLGgmsegQEwauA92mZrJRSehEvAhQy57jzpv7iZPBzzBEkjkRF1i7uTO/PfKJdoN4Lra1LzAvqlOkJto8iRw4fZbmDbD9j4wqhZcLHClwYhsmo95lpOrbi3Km1WqbvJ59zGdGyD5qEoAsSvV5Ky66fOsU+QleHO6fHW81uEnkgH6GSlbjR2AOEoMBcFmJRXK+t8xUWYWaSlcch22tE/SiIJaVq+2e5K7BBSX2HbughXac/hJAkh/ivy49cXOWaPM4+Fwn7E2K2Lja7UsPJBBpXmYbrdDppJ0T7IJ0Qf090NdJzxvSuwQiyTIHeJAjdWeuBd6ktHC+h1na54I8rXwAqdpjRcwOecAmDerMe4FRXxzd41+18rTRhGu754AIprgIDHxMYg6tMUk4NG1qzXr2SuZ6ViVzVrX x9lJrkoE HbzZhqMjsOY2TqNOD+GQTYHY80tjxRkEoeqswYYTvXXjcKVzoewwnuHJW7v1n136nnzMZTtOpL5NH7d9eNDYdzKuJOhVX4UTFFFTbr1cZquikADOHjtczF3fFM+XzdHCKi4j7UyZVfYCmLelwTYXy6mL79Vh+T9ZYEmci8jRyOTQbP9QgWviivh5hu0rMYYtBiKLUgeQIhvjGrurVdreLV7n1sQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01/15, David Hildenbrand wrote: > > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -537,7 +537,7 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm, > } > } > > - ret = __replace_page(vma, vaddr, old_page, new_page); > + ret = __replace_page(vma, vaddr & PAGE_MASK, old_page, new_page); Acked-by: Oleg Nesterov