From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32436C3DA79 for ; Mon, 15 Jan 2024 11:20:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C3DB6B0074; Mon, 15 Jan 2024 06:20:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 54C256B0075; Mon, 15 Jan 2024 06:20:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C5276B0078; Mon, 15 Jan 2024 06:20:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 266306B0074 for ; Mon, 15 Jan 2024 06:20:30 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E9C21A086A for ; Mon, 15 Jan 2024 11:20:29 +0000 (UTC) X-FDA: 81681302178.17.56BB6FF Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf30.hostedemail.com (Postfix) with ESMTP id CEFE680009 for ; Mon, 15 Jan 2024 11:20:27 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=c9ibmYOW; spf=pass (imf30.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705317628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nCwtoIhn1fv1DIHX6b7LJt+v8CCENhFJbxBqG4Uf3iw=; b=PP+T4we6JcaZRR7l/ii0vhs8ovf+O5GOADr+/VsHhgz2uPsEM1F88l+7Pisw9mJio5MXK2 MOXG7jGziPebQ3Rk6Ebi9q68yH2OHxVQTYL8qYZMhqC4lYXVI2LCrsISOZ5EC+Aqag2RMk KZ82QtmT24OQkmXqAlh5/7wOFcPqtaU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705317628; a=rsa-sha256; cv=none; b=2WAaQb9D0HaLRMDobaExWfZb3FhswpD/lc0SKkV3EGcCE/mU0CkE3eDZ240WQy+ZxAuIlH OBumaYtPVkuJYK9T+kB/KHpx9uMvVJF6Mx1cIeTibMQmvbUhWddQqyCmzDusHdH0PIrYb9 FJcb27p8AH5rsXkBPTKDZUuetifoAJw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=c9ibmYOW; spf=pass (imf30.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id C7BEE40E016C; Mon, 15 Jan 2024 11:20:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1FAqnwMpb_Zd; Mon, 15 Jan 2024 11:20:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1705317621; bh=nCwtoIhn1fv1DIHX6b7LJt+v8CCENhFJbxBqG4Uf3iw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c9ibmYOWC60KK4KJuKNxRjp9cTDl/t4NGMCh/hIKwI8C8n85ZPub0L2koL6V6bEcL DnLO99QtKwXchL36UkyaqZXBS5DH7fP3jHL9Q/Ctm4+fh8YQ/Zi44hPI/hQd/pdAI4 hF/dZoekSuQo4hLubKrITPpOBld2No3hKm8/53/0LY+40mMrigZM8I3pfNjZm2DoIk UROnl9HdofZnPLJ6LMgGqBqaDafsnEMfGqPyc1AfVYJRxj4jSf2YNhaeWiCk9E/3A2 a3kH6iByD969PW9vbwfK+YiMd0D9SY1TtpWky0g3RTJAF0hq+BELR+pCArKET/9zsi qWGNTjOJNmElWJ+LYDgjQXdiTHPiLtkxN0MZLSX8sXLtARN3Gs1imoyDUCgjd7VCZC J9vT3kwHNvW4Kf8TVcvfdGoJS6jNtP7zMsdEveUfXAGsMoXMdd0HGdiWKiEuoKaYNA EPtLG2zJlKmm50rZEOmCQzZpToDW7Nw49E+B7wCUUoN+R/Zp/A/UYJ71G3L+X51uGD 46T9n5gOcZdmqK0u48Y8hXTy3YOBjU897Pw0gioBU1PMLttNUhCbrT7GUSTA/Bnr02 Mj7zI4H0tzj0gA4NTS5FNbwPFc3ylTElAZVRO6fzZXitlK8u8u1qXnQK/5HSONYAJJ l7i/ggtKLhd5cb4XvcaoXjgQ= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1B87140E00C5; Mon, 15 Jan 2024 11:19:44 +0000 (UTC) Date: Mon, 15 Jan 2024 12:19:37 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, "liam.merwick@oracle.com Brijesh Singh" , Jarkko Sakkinen Subject: Re: [PATCH v1 13/26] crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP Message-ID: <20240115111930.GGZaUUwpmmZqxVcBEu@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-14-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231230161954.569267-14-michael.roth@amd.com> X-Rspamd-Queue-Id: CEFE680009 X-Rspam-User: X-Stat-Signature: 6spmfc39jgqu56fmkpuieqnjrzfwrisc X-Rspamd-Server: rspam03 X-HE-Tag: 1705317627-137227 X-HE-Meta: U2FsdGVkX1+wqnWaRTj+5OAVOvEk7/g4T5lY7k6n8HaFYBCEiGBeNb+1Ivy1NaLNKOc64/fxnsmUQD2uYhsh7Fo0cFpxxHbYowaaIW9egIdnFPmbA2UpZxJMkbtAex2DYAIJqeUy4dxlgpKCGlKaB7Rhg9eg+dGNQ6rzkMdbJptMKcKqL4teYqpOn+/Zk4Lc6o04bQmf+c7EP58J41s89NExY3rZfvrGx/z+e6bIeFXFCmE8p4zJfRmj3ttYU4Bu/tcjAGfTzY/rjT815KX/ysOIQsdX607givAESYedzvnDNPygUpB0UePdMjOXuu8j62gOEmD9a8jd7Y165nDrgnywv3s+uaXR8TXPbtQIMPs1IdMq3eotpfKhpnpCnGvrOjoflx12a4cdRTwtUpx1ppcRJc+FfmXzx9gC64Mp5TZ/PTvjxioAXn+r3LsSOXwJjeMoAmx1Cp9WtrrERwB4Ts0RQQIBIcQMeclFvgm5+M8VJbcC4JGuAWhx7VGPMi/DLL7SRSnZNHTJk6Sfjcra46ksVGa2EMDytzCHtxPN+WsnGWPLxKfxuPOAiWvLvFcApXE87ZGvXljAr6HO19Fk1V83A571LZ/qN+MQB/v4NshCuS39Vf/CVxrHeIysSwDRHLO/wG8Y6DtkS5jJy6ey0RatnsnWIezjs+t5P7/QPJsYd+Yrwc3aN63APa/Uzw5F7gr4xyzeWO8+uKf25P85xY2lxWP4HfjrOGl6myLSw2aQSvuBln95bmRpmkj0tZesPxcu4z6jhouzB55Q/BTXf03Vl8XNSX0cCWFwEZolRiV76RoxaeRR1Ep1mQDMrWPX7fo7Dcuf8HBhBGeJNzvS+jFy7iCoTKGJDs72V/BKiSKGFca/USosnl4xleAAcvKv41WR+VKR/5iDrHW1qBzfUZOq2x4vf2cEgisw5b8k3kv5MYOonu9p+fVz78BYOKzT53wbNDy3mfie0uqEcdN JtPZlNR0 +c4b7Rd2xff7DqoOD53km+d+dkg2IgEvPOPpFHKKbAoSqN5v+a087eDFqE4qXmL1k1pnfvLXXluVD1DoQMX3klTTYKVixRxkKuRyx2x4MeGph3FLbbZ2R8LeBS+4CB96J6XDf2iEE/djpHVwLubIGV+q51wSBGoGHmMi6Zaz8nA9ZzUHAOtEThLAAYhn7QePP58FQEz8csxukrIo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:19:41AM -0600, Michael Roth wrote: > + /* > + * The following sequence must be issued before launching the > + * first SNP guest to ensure all dirty cache lines are flushed, > + * including from updates to the RMP table itself via RMPUPDATE > + * instructions: > + * > + * - WBINDV on all running CPUs > + * - SEV_CMD_SNP_INIT[_EX] firmware command > + * - WBINDV on all running CPUs > + * - SEV_CMD_SNP_DF_FLUSH firmware command > + */ Typos: --- diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 85634d4f8cfe..ce0c56006900 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -604,9 +604,9 @@ static int __sev_snp_init_locked(int *error) * including from updates to the RMP table itself via RMPUPDATE * instructions: * - * - WBINDV on all running CPUs + * - WBINVD on all running CPUs * - SEV_CMD_SNP_INIT[_EX] firmware command - * - WBINDV on all running CPUs + * - WBINVD on all running CPUs * - SEV_CMD_SNP_DF_FLUSH firmware command */ wbinvd_on_all_cpus(); -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette