From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A0CC47258 for ; Mon, 15 Jan 2024 09:42:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E073E6B0080; Mon, 15 Jan 2024 04:42:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB7276B0083; Mon, 15 Jan 2024 04:42:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA69A6B0087; Mon, 15 Jan 2024 04:42:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BA1F66B0080 for ; Mon, 15 Jan 2024 04:42:04 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8B2211603C6 for ; Mon, 15 Jan 2024 09:42:04 +0000 (UTC) X-FDA: 81681054168.01.D18E0A6 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf05.hostedemail.com (Postfix) with ESMTP id 84567100019 for ; Mon, 15 Jan 2024 09:42:02 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=kZq7oIgp; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705311722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XBIKxlNsZUJPRPkrxlOi1GzgwTad37xoV2mYozz4U4g=; b=P1LcwXMJYj3UXz+MUPPXdMBJiiKP1hcN8Vy4OmazZzKsm3vyJLswC5TvJi4xk1W8VCfVr3 gRM02dU9mZkr9M30ADCvqsEYSzYMDWIVqQUL46Sr4/BhTDMxztxVTysEkTMNxPexzwKp16 u8g+LdkTGtL6Hrs0NzBOERO/xJpU6Mk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=kZq7oIgp; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf05.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705311722; a=rsa-sha256; cv=none; b=aqkilOwlr/7ieZ6VzUAavgZpMJmE+o6q+7IzH8aRrtms4yvPCtpbY122iBSPId2qwr/+Hu 3Q6h1nrQmkdm64WdyeRMIek6ZepcqUzhjdnpW3MrfYqOeWvSo8iN3Xd742403rr7LjdUD3 gHnbgyzjCuYk8xvGOHjgjN79Llc1JvM= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 367D240E016C; Mon, 15 Jan 2024 09:41:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id gbcYK8KndIZR; Mon, 15 Jan 2024 09:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1705311716; bh=XBIKxlNsZUJPRPkrxlOi1GzgwTad37xoV2mYozz4U4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kZq7oIgpoPYNJEFRmQ9JE48d2cPjKOwShniYdb8svdbjNuXaCXgkI4vm7t9jN3tk3 0SyquZx6f4o+581UG8SQEF/a5JXBrhlewfKVgs0DWSPD7Xhu3x7KPorhxYHOrW/ZkW /WkS4JM23S0qQa6J6k/PMJ9/UFQC3c3EAtxAAudXnxy2OfmMr6GryU5ieNcRB0VUqF Kk56gR6BWxDGFlGlKPXEkv3AS1x2RjKgRjF4rN71FCEKHAR7JQV8a9ePmr0epXg4nr +K8OUef+fdVPdl9dDUwxnKAIEtAaEqwy5hTxtLcpu+fZI3TyrfY91wAV77MqGaQJX+ I9TV8Vr7MDR6A+XR2gzKocxtwZwUaUPYPtI71n52jydUwNRUFbuLfcJmGPHLs6vmCc GT15I5hrWJ5oS44BqXuvuQz7Gn+RxvthADl5Xqp7KraalD4OGnhM3sIkHtrlPoA+SP ElIlzTj3x2wO4UdsT9YEgQcRKXep+r2BCZohCYiRrppaZJ8uagtla5VglupvrYmOSB Uz8ExwhjAP5m15h1O0Q7sQH1RYxDEBqFCXtAiJLE2g5DCXhPEhpyNgmdJIGvMFTeRG 6p+xjuV3jBjkoXBYS7fHf89rG4lL2UmaOvBIU5i6yOHaa7F3eHhKV/VzYkAGlTfiYe I7Bqk/56DF97nG5LMUix8SaU= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AC6A940E01A9; Mon, 15 Jan 2024 09:41:19 +0000 (UTC) Date: Mon, 15 Jan 2024 10:41:12 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, "liam.merwick@oracle.com Brijesh Singh" Subject: Re: [PATCH v1 12/26] crypto: ccp: Define the SEV-SNP commands Message-ID: <20240115094103.GFZaT9r4zX8V_ax8lv@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-13-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231230161954.569267-13-michael.roth@amd.com> X-Rspamd-Queue-Id: 84567100019 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1mn3qc7yzqt88u5iotqhidm1x1wf1cu4 X-HE-Tag: 1705311722-411795 X-HE-Meta: U2FsdGVkX1+HcRZKk720Rzm7JbhOY3PlbqjKPdUZMQtKMAEHz2dK8/iT4W6adii3mep6HfMobfDYNnFGhgEP2MU8OTDaPMhiZtpYAcN0iy7o+LpbB1+qR9pY2hV9+g+W1fpPSlwrz5JHykSG05MpjRvZ2fRJ77IVev1noPdWnxIiKo+cwwYWlLpnqFdxUt9Y8C1yBunoUbYKX6Qydgv/GMTqqSNvK3KIvN2OkTvpwtEPItRPMkjEOgGvNSHJAqKARnNhxwvO77PcrnoQr0UG5VgzzDeIP5ZZdbPHrO/cdfFGL0mbiFEXkBsfNcxG6jQFDXbwFZngMNcFx9K07kPbOuNh3gitjOonJCxxIxhGFqSlp0jxn3fPrNZ8xXnvmqhY1sivEtpofl5Sh4pZPTlIskZ1qVhsnO9q6t5KwjY6STjWlMInhhWObL35sC7/4JmzzdrcNxkp+OJmg1zruAxXlE3FJ2sXvfNOWFW/o6PVa9IfrDO8HBZmjYbZRjt5EV+yEdNeOXdMcoN//ptPraFuoHCCjR43iQcK8P90qXBhu+Bjhb1cf4r1IynF56Nvlnb+aBbEZUlRxVL4UapFyyayNS0XGcXvIt3lGLy0Z38aR6l6UdkIgB2KIXy1Sft+dg07ePRaOQOR2t6qO+cChGw9jPzUtnSsB9tCk6r3R9/gCqPtTS0Ex9vcoWZ+SDsfquYtIhN+dIJ+5EDmwImSnXnxM7+TrYxvCWw1XYxrEnZ+0EtX01YFQNahzaJRaDnbbgMedAixkQbzBa3QNsV2ILM4dkY/ReEhl08qNTueewthr0+sT27YswhkYrUCtbp3U7YwePdrDRIeb+iNV2jW+6q/ccWEoAbC/m/6rrNEy84wyfe157gVWBx1PdRvO0unu8+67px0aDWyfTIJmKc0jxQtK0cuVf9FGkqYMqkKS6qSkUsyaDEHrYReCW7U8z10tBPlOfwfGf4DgjA3dFXSXqD AT781COG Sohal7POhyZSrgV4V8C6T94+diFEedvVVa5loXnuQaGo4qmBBtaoZeX0c4rxVQAUfAFaUMuV+cd2FPGgsYrnziPj8eetD/G40Y1ViPgieI8KYgzMSzCCfDHVDpV4eWGU97eQ8eWN2ZiO0aVUGBkeSS59wlCoiV8Xp7wFBzoAfQ+C20BIqg/E7kg+yFqsKPl32dVdw2yFCYiZbCkRegDyjR0PCjkCOACNw0pqX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:19:40AM -0600, Michael Roth wrote: > From: Brijesh Singh > > AMD introduced the next generation of SEV called SEV-SNP (Secure Nested > Paging). SEV-SNP builds upon existing SEV and SEV-ES functionality > while adding new hardware security protection. > > Define the commands and structures used to communicate with the AMD-SP > when creating and managing the SEV-SNP guests. The SEV-SNP firmware spec > is available at developer.amd.com/sev. > > Co-developed-by: Ashish Kalra > Signed-off-by: Ashish Kalra > Signed-off-by: Brijesh Singh > [mdr: update SNP command list and SNP status struct based on current > spec, use C99 flexible arrays, fix kernel-doc issues] > Signed-off-by: Michael Roth > --- > drivers/crypto/ccp/sev-dev.c | 16 +++ > include/linux/psp-sev.h | 264 +++++++++++++++++++++++++++++++++++ > include/uapi/linux/psp-sev.h | 56 ++++++++ > 3 files changed, 336 insertions(+) More ignored feedback: https://lore.kernel.org/r/20231124143630.GKZWC07hjqxkf60ni4@fat_crate.local Lemme send it to you as a diff then - it'll work then perhaps. diff --git a/include/linux/psp-sev.h b/include/linux/psp-sev.h index 983d314b5ff5..1a76b5297f03 100644 --- a/include/linux/psp-sev.h +++ b/include/linux/psp-sev.h @@ -104,7 +104,7 @@ enum sev_cmd { SEV_CMD_SNP_PAGE_RECLAIM = 0x0C7, SEV_CMD_SNP_PAGE_UNSMASH = 0x0C8, SEV_CMD_SNP_CONFIG = 0x0C9, - SEV_CMD_SNP_DOWNLOAD_FIRMWARE_EX = 0x0CA, + SEV_CMD_SNP_DOWNLOAD_FIRMWARE_EX = 0x0CA, SEV_CMD_SNP_COMMIT = 0x0CB, SEV_CMD_SNP_VLEK_LOAD = 0x0CD, @@ -624,7 +624,8 @@ enum { * @gctx_paddr: system physical address of guest context page * @page_size: page size 0 indicates 4K and 1 indicates 2MB page * @page_type: encoded page type - * @imi_page: indicates that this page is part of the IMI of the guest + * @imi_page: indicates that this page is part of the IMI (Incoming + * Migration Image) of the guest * @rsvd: reserved * @rsvd2: reserved * @address: system physical address of destination page to encrypt -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette