From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 403D9C3DA79 for ; Mon, 15 Jan 2024 09:02:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C658F6B0078; Mon, 15 Jan 2024 04:02:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C12756B0080; Mon, 15 Jan 2024 04:02:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB4746B0081; Mon, 15 Jan 2024 04:02:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9A0F96B0078 for ; Mon, 15 Jan 2024 04:02:19 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 65974120810 for ; Mon, 15 Jan 2024 09:02:19 +0000 (UTC) X-FDA: 81680953998.17.3D896DC Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf12.hostedemail.com (Postfix) with ESMTP id 1427A4001B for ; Mon, 15 Jan 2024 09:02:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=SAOPBhxw; spf=pass (imf12.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705309337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=StldW18DJW9RHvhpFLIMw8/y8Xdlf7u+BI435bxm9gE=; b=sj+P08Qgp5SaG/SA3FPEJ0NpE5i5SmKYmD6Kp8eclXy6ZlLGXBtu0OiyEppZSJSFX3Dfvn tjpLJPZg8nhdBy0LpMalKMs4TNdAzEQYEs6ZtvTo5JOPEgWo1kUaDIAxawPiY+HRklQC2K h4cButifN+hD5dr27RqpUit1Ah7gOmM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705309337; a=rsa-sha256; cv=none; b=4TOeWQm06CtrCFufJmOu73q/nmtlT1tIf8fbrDvBZqpHrqiWWIRkdydX04fnCJtNZRvFht LxcydLJVWXbxMfVw7FyYKG083Y+olXpOCDMs1gMGX2/JAjNr7Cxn4enY+pRIXsp5l4kYZl O7FiFN4ENUBzEP7cNI90VasemkMCRSU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=SAOPBhxw; spf=pass (imf12.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id AD92740E01B0; Mon, 15 Jan 2024 09:02:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SUKdvpsWbZhK; Mon, 15 Jan 2024 09:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1705309330; bh=StldW18DJW9RHvhpFLIMw8/y8Xdlf7u+BI435bxm9gE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SAOPBhxwbXpACDVHP9Vgo+tBOgk6enmMbPub2YjCJOSM2Toof/rV7Tf6Q7KI0mS1g ZEBocmEh81odQ2fQbDeCt9YY3bAHX7XPTnpw7Un7NF9qjc3oa1yXKaibzSuoQDj/x3 evyCIOERFXEiSoe5cyAhmDl1c1pRyM8HLcaLyzQMdOF72dHMjbbRjLv0doHYVPOaCh hlygnPuXr/lh3jKPd04u9kqpmeR2RvvB11xD0OZbMX98qSlIrtzWdjd/EJwIPPXF/e 3B4uJK5neFbWsFBfVhuCn823FkTrBaGCd/C4SUl+MIBS8hD67NvSqMRUxA5BhQzE5Z olACYu2A9zCwGqxAR/dxdJtbefC0pED2yvzcvoMizdVumW2bIrH2gaqeVecKt5LeEE kvQxK5TJeeXq+Xc+DaFxh0DsavN4p3n6NNrZ2GYRoMMaOelAuNsYdoTKSLlPViMhxn so7gePgLsENHGpjy+x/C1Wi41H+Rl5T+SVHS7jKFXTVmIhciNEDlSkcfMY61sFbJI/ o7VSoCVXWZv8qrKkhvxKf8e3Yh2FnNPraaEj7B872YIPUs96dShqtLXjHEgZWG9QqR 6jgVxJglFNO/ETzSN4Oz4a+qpYt6yB52z6q81wpRVsI+ElPGIVMbmNf/lhjYS9V2T+ oygAXEbBHHh/kshvJixLCzlI= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 008B940E01A9; Mon, 15 Jan 2024 09:01:31 +0000 (UTC) Date: Mon, 15 Jan 2024 10:01:26 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v1 11/26] x86/sev: Invalidate pages from the direct map when adding them to the RMP table Message-ID: <20240115090126.GEZaT0ZnSPIPsnUiyt@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-12-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231230161954.569267-12-michael.roth@amd.com> X-Stat-Signature: rospcpdzyj31i1ni4jyo7mz4xieeiftf X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1427A4001B X-Rspam-User: X-HE-Tag: 1705309336-310368 X-HE-Meta: U2FsdGVkX19+2HGrmklgqjB+9maqU36GTd4E+4tbBK+KjuQ7UqDdi5HSz73JptvxgbuqlLXO6UQeb1Ddsqeodk+Ar6SuHHJ5UXmayHFXT+WhfKXRGeCAfVKtY5taQTJ+vEiXM24HKD51Q3enpd2eX4nOuIRSB9l7CyB/ahII7RGDI8X3LBnmNWcujcMWuclkVpr4ueojUxqLZ40JK4N+P7ug/CWZhbxrOBR+Vuh1tNQLKQn/2++eygKEhnLLO0O7h6RmlidnDlQbtYFdtMUFP4hNarj4JNTntdZoMtEWeXsnRYVolo6/gC7ZCQG6ZBkdAVDLXy+vDkdKLXRPOcfsyM8lmQNT6btjXmvpY8e/uYZzg6OWjSRmKDe1rD4neEzn02itWTuH77es+GDdr1VOVCZgNlPeJEFjGtqVxk+/4+/qA2TINyGn89dxnOwYHMgSHIWL7xNmJSxreZqCAGlgCQh8nEwptj+Gc2L5EycMYqGmQngchk4r3kDMPzQIjTtQVSTJ6eTzyodyQgqngkmrRgddh3RKpt72rWMSISG54AeDxhhchWi6TF/JcX/PouQWjJX19rDlRavf4E/Heq6FwXZD0q6JKX2fGRwLXDL4PsOroOu+j81r+FfdpJyUVrL+H4DbR2bCroZaXsZrdf8BLziwUMeuYMuaXtGay7CBz7ClqbC3F72GUPbP53dXSN15T8sfPlwYuPTX+0JnCsRPI32VpcDd4ZGc5c06PuvLk3/dIui3vyQqqNbMJDViyXEc6e6j0rz+Q2u6z+8GFiGcHf1R2u1qQU3Xn/C8niJ+RTJ4W54LgYEJIuFFa0xf9hN/MhwL9FzsWyFghswLpCR+nAtSB6QHRePUckpNlpxF6Vbav9ZyyyikvW9XifE2uDwYBVsLQx3PJVEWwfZ134peBgHZI6kdHOb8fFeeXuWoS9OAKHwG0q0Ha7xxDnmrN3LVHm5L2jmBqY+xCcCQWTc 8cuCAF0A Go0cvqVttfA3bUQ38f9QTKuaKWzJ6CzWbezn9Dmug6DKVrnGrarlUY2YtZhNkKEn0Tl6pzRKKlhrE63RzBe8ueOxmIsjipoIlLqF4JBZy+FomelOMpeeg5cyP/yYPf+JVubd4i966388V2VgRm6/qNY0RlVau2urd60geP6DWX/1603b6QQR8CrMlwI5i7lCWtlK6wDKGvn5phvI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:19:39AM -0600, Michael Roth wrote: > + /* > + * If the kernel uses a 2MB directmap mapping to write to an address, > + * and that 2MB range happens to contain a 4KB page that set to private > + * in the RMP table, an RMP #PF will trigger and cause a host crash. Also: diff --git a/arch/x86/virt/svm/sev.c b/arch/x86/virt/svm/sev.c index 7d294d1a620b..2ad83e7fb2da 100644 --- a/arch/x86/virt/svm/sev.c +++ b/arch/x86/virt/svm/sev.c @@ -415,8 +415,9 @@ static int rmpupdate(u64 pfn, struct rmp_state *state) /* * If the kernel uses a 2MB directmap mapping to write to an address, - * and that 2MB range happens to contain a 4KB page that set to private - * in the RMP table, an RMP #PF will trigger and cause a host crash. + * and that 2MB range happens to contain a 4KB page that has been set + * to private in the RMP table, an RMP #PF will trigger and cause a + * host crash. * * Prevent this by removing pages from the directmap prior to setting * them as private in the RMP table. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette