From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A47C47258 for ; Mon, 15 Jan 2024 07:58:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F3076B007B; Mon, 15 Jan 2024 02:58:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A3526B0085; Mon, 15 Jan 2024 02:58:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46AB16B0096; Mon, 15 Jan 2024 02:58:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 36C4A6B007B for ; Mon, 15 Jan 2024 02:58:19 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 00A071207FC for ; Mon, 15 Jan 2024 07:58:18 +0000 (UTC) X-FDA: 81680792676.19.CFA1D2D Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf13.hostedemail.com (Postfix) with ESMTP id C826D2000C for ; Mon, 15 Jan 2024 07:58:16 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705305497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Oh7CuhtXf5I+puZrb1xi9EarzZ87iQovjtM99pmbsHM=; b=hDiScXWZjJS6FGsfRETKt6lb9jlVwK7t80/SQ9ghq52Oa1jCY8ztPyLmfSMY8NLqapQVqU fIWcWARb+HUJ7UfsqCR5ufQJaiqUeoKtK9sQJYTB8VawMPVJMqgNijbzT1PZ9Ye0+EeLhC Ka8HX5Gx0755JT1ympnVgtWHHTYmOeQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705305497; a=rsa-sha256; cv=none; b=W8M26YvM9T528Q8Rgc9H74LZEp7+mhusdWMcqOWGpeR+dvFGteDvpMOEURalIN/VP3dn5W 7Ar18iH+YiCsvtDqM37YAVmQT82VF4ZRxeeF7sQNg0uOg7Rb12uLSG1jKJdVGbmADNQCLF YNFeXCu7+1qwDKc4jUiJGRDdTb+Y3QA= X-AuditID: a67dfc5b-d6dff70000001748-6c-65a4e5960a1f Date: Mon, 15 Jan 2024 16:58:09 +0900 From: Byungchul Park To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, namit@vmware.com, xhao@linux.alibaba.com, mgorman@techsingularity.net, hughd@google.com, willy@infradead.org, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Subject: Re: [v4 0/3] Reduce TLB flushes under some specific conditions Message-ID: <20240115075809.GB56305@system.software.com> References: <20231109045908.54996-1-byungchul@sk.com> <64cb078b-d2e7-417f-8125-b38d423163ce@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64cb078b-d2e7-417f-8125-b38d423163ce@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsXC9ZZnke60p0tSDdr+WlrMWb+GzeLzhn9s Fp9ePmC0eLGhndHi6/pfzBZPP/WxWFzeNYfN4t6a/6wW53etZbXYsXQfk8WlAwuYLK7vesho cbz3AJPF5k1TmS1+/wCqmzPFyuLkrMksDoIe31v7WDwWbCr12LxCy2PxnpdMHptWdbJ5bPo0 id3j3blz7B4nZvxm8dj50NJj3slAj/f7rrJ5bP1l5/F5k5zHu/lv2QL4orhsUlJzMstSi/Tt Ergy9v+uLWhlr5i15SFjA+MR1i5GTg4JAROJuccvMMLY/0+2s4HYLAKqEgf+XGECsdkE1CVu 3PjJDGKLANmnVi5n72Lk4mAWaGKWuLZ+M9ggYQF3iV2n7oAV8QpYSFydsRusWUggQ+L46zns EHFBiZMzn7CA2MwCWhI3/r0EquEAsqUllv/jAAlzCthK7G94BnaDqICyxIFtx5lAdkkIrGOX mPLqITPEoZISB1fcYJnAKDALydhZSMbOQhi7gJF5FaNQZl5ZbmJmjoleRmVeZoVecn7uJkZg NC6r/RO9g/HTheBDjAIcjEo8vD/+Lk4VYk0sK67MPcQowcGsJMJbfWdJqhBvSmJlVWpRfnxR aU5q8SFGaQ4WJXFeo2/lKUIC6YklqdmpqQWpRTBZJg5OqQZGeUUOD7bL169ZqfoIm9U3+qSK 6Oyb9iOsRDpdame0Y9ReF0a2W6/ke+LMLRVfNn7r9ps1mSOSaU++cKC/bl5i1O4ZrkffvwnN rpnOGrwpgl+wIfXJ3MtF9/e/Zt/Qdd487aOIUFrFlwcnTtqZxJ2ZPy95peS8H2c+HK5n+v59 55YfdpPDlospsRRnJBpqMRcVJwIA74qV9MICAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsXC5WfdrDvt6ZJUgxvbdSzmrF/DZvF5wz82 i08vHzBavNjQzmjxdf0vZounn/pYLA7PPclqcXnXHDaLe2v+s1qc37WW1WLH0n1MFpcOLGCy uL7rIaPF8d4DTBabN01ltvj9A6huzhQri5OzJrM4CHl8b+1j8ViwqdRj8wotj8V7XjJ5bFrV yeax6dMkdo93586xe5yY8ZvFY+dDS495JwM93u+7yuax+MUHJo+tv+w8Pm+S83g3/y1bAH8U l01Kak5mWWqRvl0CV8b+37UFrewVs7Y8ZGxgPMLaxcjJISFgIvH/ZDsbiM0ioCpx4M8VJhCb TUBd4saNn8wgtgiQfWrlcvYuRi4OZoEmZolr6zeDNQsLuEvsOnUHrIhXwELi6ozdYM1CAhkS x1/PYYeIC0qcnPmEBcRmFtCSuPHvJVANB5AtLbH8HwdImFPAVmJ/wzOwG0QFlCUObDvONIGR dxaS7llIumchdC9gZF7FKJKZV5abmJljqlecnVGZl1mhl5yfu4kRGFvLav9M3MH45bL7IUYB DkYlHt4ffxenCrEmlhVX5h5ilOBgVhLhrb6zJFWINyWxsiq1KD++qDQntfgQozQHi5I4r1d4 aoKQQHpiSWp2ampBahFMlomDU6qB0XBH0AqTgptvGY8pH5AIcS8svSnsdeVYv4q8t7q494OV LcHPk+TnnXhRqswXef5Lx33Fy1dsNaOVmkWbd6ixXNxae0xzwhWemXzqLHk3vsQtL668kVon luWY6vJJYabsrAkKkqdXLNmzXys15v0J64Ps24srfG32p/DPLd3z4lTyurSQT8nxSizFGYmG WsxFxYkAiMxD0akCAAA= X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C826D2000C X-Stat-Signature: u5myrsrp3ypkdxc3aziu1dow14ot814k X-Rspam-User: X-HE-Tag: 1705305496-68584 X-HE-Meta: U2FsdGVkX19RHAIS87OFE8XW86nrRvllrCv2WUw4RI9FjcRfs0LupUoFNh+BOYCDVScCZMhD4sVm+05CtD++qqank/wQOFSNP9FGquGTOiKlUhRmx2wJkSbb1fIyfUxRBzyu8W0h1bqw2G5oPQIaS7OROTR1ipMr4VIG0bb/Nst+OljAqkxbTGtsqviCBpzmc94RuNzgxhbYZzG4kJAX6SB4BPgs0Ycn4ni4SKFyNE05OnccgTKQYHl9nwiZ+v1K7Tzf33BGFGj/WcxilYOWmbWpGScWof9A6jaWIq/jo0mZ0n430gyXTKQ6Y1BF+02XA2NnD0uhJBSEZ/gnJcEOi5V2fkbzdefMkm0EqvB0mn7QJJt/Zk2YFhYw4jsGcm0rlELuhVDXu4PyUncwA0+P2yGMoLHpKZTE6sgtM7cRmEAsZlHeo7f2A9gH4FOX5VwoO0T26RGlK9K8ys24bPqrVjMlsEeutV8WKZZxDj8bU7ibzW+nFlP+pKo+GN2sMV8ALoNkomF7sEs+R65NrRu629KeFCifwKD/APAtrAsgf9wkT88Va71Zx4fjrJQ7Qgc6J/8rubRpTcbGa4rVh3/D30/toyuEY6Nb6TXLw8x1/ikcVqBUPJbhRytAMautajDehDwqWUuaMfnBiEEoAuGPBCQqG4iby/z/z1AAdsUtZuEJ/2LNegWY6KRZ+RObBOKf8ocd7lX+w2ynIitYamysItmzEULa0D0eXgtm0MGjZ987ktk9Mnv9yi6mthCj93XptDlpWlsiNnwjiSzrLi0GYwhFVRxASikGnpoRS55KEFIxytqEpMEwViimXKnhqGiXfD3zZXXiR4EaP1PSDMoCGzPsJZtT8OkXdTAXhsGk+6GquQlvxFhYC42HqpN36cFtBV7LbmUI9CAyG8AcMGiMbabmba4X2Gaa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 09, 2023 at 06:26:08AM -0800, Dave Hansen wrote: > On 11/8/23 20:59, Byungchul Park wrote: > > Can you believe it? I saw the number of TLB full flush reduced about > > 80% and iTLB miss reduced about 50%, and the time wise performance > > always shows at least 1% stable improvement with the workload I tested > > with, XSBench. However, I believe that it would help more with other > > ones or any real ones. It'd be appreciated to let me know if I'm missing > > something. > > I see that you've moved a substantial amount of code out of arch/x86. > That's great. > > But there doesn't appear to be any improvement in the justification or > performance data. The page flag is also here, which is horribly frowned > upon. It's an absolute no-go with this level of justification. Okay. I won't use an additional page flag anymore from migrc v5. Thanks. Byungchul