From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3CEBC47077 for ; Mon, 15 Jan 2024 02:08:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00BD96B007B; Sun, 14 Jan 2024 21:08:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED7016B007D; Sun, 14 Jan 2024 21:08:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D50666B007E; Sun, 14 Jan 2024 21:08:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B7DD06B007B for ; Sun, 14 Jan 2024 21:08:31 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 81FE91C0D97 for ; Mon, 15 Jan 2024 02:08:30 +0000 (UTC) X-FDA: 81679911180.18.118E06A Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf01.hostedemail.com (Postfix) with ESMTP id C2FE24000D for ; Mon, 15 Jan 2024 02:08:27 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705284508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nPY0qYYVanxqiYvM7J1BKrG1YclVwJ1djZ1V+97DKkQ=; b=0LNbODcFe1P9y5XWPDr/4yyc3ok26m/5uF75Ybnvo/b7FGi0TnklH9dQxiB27s93J7ARMf yU1orJVhYSXtuCju2oCfnnm3HEtYmarjN+jMPUk81mAQlknQSfiwMWbcHUwih1RLgM914e 8oBtvMPqtURco2mgtrfCDT0jNCcbjC8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705284508; a=rsa-sha256; cv=none; b=2oni6T5c9zytw3VeJMoJASXgegVF/0qYz4bINbxJEAzNu/yUulfzYjVbTdP5JqIp14d/73 osUdhqS3gZyK7hQd/Z2fg1nViSJ0kEd5RA+KaPURa3VsPUpMjTh7x0sKhBugxFO2OrcQO1 shR/tBMCYvnb2wSG5yV3OtQsW9WyU4Y= X-AuditID: a67dfc5b-d85ff70000001748-cd-65a493978fc8 Date: Mon, 15 Jan 2024 11:08:18 +0900 From: Byungchul Park To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, akpm@linux-foundation.org, ying.huang@intel.com, namit@vmware.com, xhao@linux.alibaba.com, mgorman@techsingularity.net, hughd@google.com, david@redhat.com, peterz@infradead.org, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Subject: Re: [v5 4/7] mm: Separate move/undo doing on folio list from migrate_pages_batch() Message-ID: <20240115020817.GA56966@system.software.com> References: <20240111060757.13563-1-byungchul@sk.com> <20240111060757.13563-5-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsXC9ZZnoe70yUtSDbZNkLGYs34Nm8XnDf/Y LF5saGe0+Lr+F7PF0099LBaXd81hs7i35j+rxflda1ktdizdx2Rx6cACJovrux4yWhzvPcBk sXnTVGaL3z+A6uZMsbI4OWsyi4OAx/fWPhaPBZtKPTav0PJYvOclk8emVZ1sHps+TWL3eHfu HLvHiRm/WTx2PrT0mHcy0OP9vqtsHlt/2Xl83iTn8W7+W7YAvigum5TUnMyy1CJ9uwSujKvd p9kL5nBWvO+by9LAuIK9i5GTQ0LARGLj5XvMMPaRxpmMIDaLgKrElI2zWEBsNgF1iRs3fgLV cHCICGhIvNli1MXIxcEs8JpJ4tn/fUwgNcICsRIfT28Eq+cVsJB40P6HHaRISKCbUaLj9U42 iISgxMmZT8CKmAW0JG78e8kEMpRZQFpi+T8OkDAn0A2Pfn4Eu0FUQFniwLbjTCBzJATWsUuc ODmVCeJQSYmDK26wTGAUmIVk7CwkY2chjF3AyLyKUSgzryw3MTPHRC+jMi+zQi85P3cTIzAK l9X+id7B+OlC8CFGAQ5GJR7eH38XpwqxJpYVV+YeYpTgYFYS4T34fEGqEG9KYmVValF+fFFp TmrxIUZpDhYlcV6jb+UpQgLpiSWp2ampBalFMFkmDk6pBsb+Pc8mzRBueuW+n/Xu9T6Fx06L tn299JI/c1Od2Jsd/qsrdioZtE1/27KnuFciZMGT+F6Ov2cjEgWaBOZzeCxauGnFQseJkr9d T2q6c7y5zsZ/Lm1Niq274IcrmS8zcjymz//Hknjy4fty5q1v3tbp5xbcvjzZ10xtaqTq/fzf dx61u9xWfBShxFKckWioxVxUnAgAVlQlk74CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEIsWRmVeSWpSXmKPExsXC5WfdrDt98pJUg0MTeSzmrF/DZvF5wz82 ixcb2hktvq7/xWzx9FMfi8XhuSdZLS7vmsNmcW/Nf1aL87vWslrsWLqPyeLSgQVMFtd3PWS0 ON57gMli86apzBa/fwDVzZliZXFy1mQWB0GP7619LB4LNpV6bF6h5bF4z0smj02rOtk8Nn2a xO7x7tw5do8TM36zeOx8aOkx72Sgx/t9V9k8Fr/4wOSx9Zedx+dNch7v5r9lC+CP4rJJSc3J LEst0rdL4Mq42n2avWAOZ8X7vrksDYwr2LsYOTkkBEwkjjTOZASxWQRUJaZsnMUCYrMJqEvc uPGTuYuRg0NEQEPizRajLkYuDmaB10wSz/7vYwKpERaIlfh4eiNYPa+AhcSD9j/sIEVCAt2M Eh2vd7JBJAQlTs58AlbELKAlcePfSyaQocwC0hLL/3GAhDmBbnj08yPYDaICyhIHth1nmsDI OwtJ9ywk3bMQuhcwMq9iFMnMK8tNzMwx1SvOzqjMy6zQS87P3cQIjKlltX8m7mD8ctn9EKMA B6MSD++Pv4tThVgTy4orcw8xSnAwK4nwHny+IFWINyWxsiq1KD++qDQntfgQozQHi5I4r1d4 aoKQQHpiSWp2ampBahFMlomDU6qBMXpxcaXPzysvg70EpXd4/lZf8jUzIH/p4csve4LeSirz vtMQSNRz7lrOsbKiY/LDQ8Ff2cxNmN2D5mg95/wuoHH/RH5M0dzwmSXnQ5e7LEhaOq3LItFx 7q20Fw3Nl97mSHH9z3slz15+Ly05OuXCm2jxlITjnB/4Ft2Wt88+mt9hfF8o65a6EktxRqKh FnNRcSIA8ieXD6UCAAA= X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C2FE24000D X-Stat-Signature: gi7sf5g8ckzzaobx1jmprutyy5cdy98b X-Rspam-User: X-HE-Tag: 1705284507-276864 X-HE-Meta: U2FsdGVkX19e+Z55D3z7EiB3Q+PFQdkrBB/n+FedWej0UiOQaxTItiwN29IgIC3fZsVkY/oey+c7NCJEmpmmSDcfXqoiGiIbLvYea6Rx25LbFZgqYiESz5VMb/keuQPMtJiHFlHalMWyv0+LtFuo2lWC+aqsPGdur0rFGLA4qpk6P2BorWZvIAO6cLupyROffJEZvB5W6lUFsO4nrFWOugZ0rH9zLk1crDJJX1bXYscHTkm+c2brzSvyvL073f4zebrmIH13BBTdlN+fiw8M8UxhXpNV8x7eUazigEz4noD5OX2YOCJk9PuwpYA0zdDZCv/dfrToYeHxnpeSQoYYKBS3ZFcJyN43WDw2k2StD4x9qQ5THMpqIzKfFGYUEmFVEXKn/HX6MxyH4JUla6fCY2QaJA+aNs8oMKh7lNJU9VhRYKIJV5Wj7KG5dd8EC+tgguZHTzuSZx4eWWboVn/NgCe46MIxYYelqubX+QcymXTEGs6K8ZSaceFlHD7CFNqd0DlVDyrUmo+Y91n2VEkMGZxA3e0qcE7ZK64K06U6F2GjtNotuCLmzhpmMG9SuYnhUEx/kSGNWI1VWSgDDLBpkpD3hqTw980TOtyrbClXiib8S0yqON+w8V9/HgrkesmCFdCP5fw4HuD8PvSLEI8r7Gl0D9+gni5f4fmFDMjNF+IrwM+prCL8SP12bJMOLv/IpvAPOKYvieQt+oyXGQyu+vlsVyFCEE8emlMGrU2mNmw4bCL0wSqNyWH7gejYBx9q0CYrhE604RsB7B7IHXKaA9H1AmI3Nx0Xvj306c3ry+C3kQnTcG3OeEvlBoyrhLulM2s7z+Hsk1ld6U31pPFUS0uOKV3h18wwgs6N/doZNJvZXmfdSgdk9A/5m2Uj6j/bdZFR0E6Q7I/STZ2v0dyRjQcpuOV9J/7cWKvyJID78l2ROyqBGPiiQuyhvFTfKvIrOte27fz1rltt+GPAIKA jgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 03:42:55PM +0000, Matthew Wilcox wrote: > On Thu, Jan 11, 2024 at 03:07:54PM +0900, Byungchul Park wrote: > > +static void migrate_folios_move(struct list_head *src_folios, > > + struct list_head *dst_folios, > > + free_folio_t put_new_folio, unsigned long private, > > + enum migrate_mode mode, int reason, > > + struct list_head *ret_folios, > > + struct migrate_pages_stats *stats, > > + int *retry, int *thp_retry, int *nr_failed, > > + int *nr_retry_pages) > > +{ > > + struct folio *folio, *folio2, *dst, *dst2; > > + bool is_thp; > > + int nr_pages; > > + int rc; > > + > > + dst = list_first_entry(dst_folios, struct folio, lru); > > + dst2 = list_next_entry(dst, lru); > > + list_for_each_entry_safe(folio, folio2, src_folios, lru) { > > + is_thp = folio_test_large(folio) && folio_test_pmd_mappable(folio); > > You don't need to call folio_test_large() first. folio_order() includes > a call to test_large() so it can return 0. > > > + nr_pages = folio_nr_pages(folio); > > ... or since you're calculating this anyway, > > is_thp = nr_pages >= HPAGE_PMD_NR Cool. Thanks. Byungchul > perhaps