From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C926CC4706C for ; Fri, 12 Jan 2024 20:08:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A8D36B009F; Fri, 12 Jan 2024 15:08:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 132266B00A0; Fri, 12 Jan 2024 15:08:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EED816B00A1; Fri, 12 Jan 2024 15:08:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DA11A6B009F for ; Fri, 12 Jan 2024 15:08:38 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ABCA08016B for ; Fri, 12 Jan 2024 20:08:38 +0000 (UTC) X-FDA: 81671746716.14.A73CE58 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf30.hostedemail.com (Postfix) with ESMTP id E76118000E for ; Fri, 12 Jan 2024 20:08:36 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=KNNfilfS; spf=pass (imf30.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705090117; a=rsa-sha256; cv=none; b=yE7ugoUWVGyU6WyDDHTMvskamzHviz8PLt9++PGQmeZc9cqmI2PWarnXql9/7y+Q+SOs4D /2gA7Qd+h2NWJ5HL1nalSUsM/zRm8lHD/XxBXnkD5lOBIoPFmFls8eEZqDNiUmp3f7/aY5 T41sD9iiztG2a3xMFpHChIMrA0gX7Tg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=KNNfilfS; spf=pass (imf30.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705090117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e1SfatK6kMuNuuwBDPnqHfNy3+Q98jf/weW6sPVIkD0=; b=TDYdLd4AWS4CrNwTbpics8QUOnkM21MjC1hCfg07Sq6Jf3CJW3Not20ebUKWCr0gAUaYPD wztONxGbc6Fy1VweMPdH5YLYj6H+rncMel7KZQfw2H6DxZTnlDQKg5OxOVT20jGCgfveUQ HPsvvzRlNVHx+Y1Tw4EW8+IzH/aHEXw= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 77B0540E01BB; Fri, 12 Jan 2024 20:08:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8kA7_vDH_yh5; Fri, 12 Jan 2024 20:08:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1705090111; bh=e1SfatK6kMuNuuwBDPnqHfNy3+Q98jf/weW6sPVIkD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KNNfilfSV90nTYo01g8OipC9QBf4EsV5uS9Xh50yk1Yr/QWJAE4vpzA35JE3Nm9jG K0Q0RGMJS81gbue1mMgxIQPF8PZ9hs45zU2p05e8jyHqp5+5F385NOYXSI7LSGnyfw VodDIr+WPeasUIY4n93LC1K/wYVm8GHl2vfE9zBKj7PAkAocnwrYzjeWzldE2R29Go oMH30Yk1lxnm5za+ZQ1ShL1YQ4x5+Bd6Hd2X8lp7YLVJPHGCOtSExwNftBX/22cgWT Jb+R+FkOZGi1ibwlHJ8CDX67dOtESWRxXAHL3wjLzxxJ15WlLJD7dOBUUPSlI011pt YNYY+FUeS5kK2E3roloMIFvGd9F0ASqwfkms7Tgi94Np8PV8o/dmv/41axAi3xEqXc bMFohTfAYalOMlv/MRyfLsm6FhqzZg/0b/iiPmNyIJ9krTZUOkVYjkubIGTEjq59/4 OkhtzKGnhXsA9rWEKO/KX1QZ9AhzRtZ1Kqioqkdg7qjPjq5SxqXYUZQezqU2groGuN T/8uiUWLxQhK86uU3X7YZb3PpoAnWJ+jrGnu35UajKR2lGck6bvk7b8VvNDqVEB9d0 BvFgn/IBTM8lchd34kUpkgHg1dIl6e7ldu/5XcXG0HhNmap/MhQ383+sgVTB3IictL 9g8wUqDg3EIOHRw8iFm8pukE= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id F3A4240E00C5; Fri, 12 Jan 2024 20:07:51 +0000 (UTC) Date: Fri, 12 Jan 2024 21:07:51 +0100 From: Borislav Petkov To: Dave Hansen Cc: Michael Roth , x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v1 11/26] x86/sev: Invalidate pages from the direct map when adding them to the RMP table Message-ID: <20240112200751.GHZaGcF0-OZVJiIB7y@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-12-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E76118000E X-Stat-Signature: g9qk3noacz519n9edgp7ixdtapg6hc6b X-Rspam-User: X-HE-Tag: 1705090116-406462 X-HE-Meta: U2FsdGVkX1/TcKCpGSs+mGNDtqQuUIyb3ncbthSRUb0SIsqBNRYtaWhNZSIy/XT4z8wCyogBH+WwAWgOEjcWq6RwER3wtZaWvZvYSRI3RTNRCUn+sWj7+XX3kvBwazBm4EGNi5JT0oUNdORa11bIuLBBBQTBniusfcVFe8Ztzevq5UpKPyi8nEI/jKe2IEH4vE38mQeUzoTbz6CIQoT47/kaqIGKdN7SOBhDy6fyy53fOlJlitafc0mTYV2D8nqx8CSkpc8fyOhMMVcXqz3o47vDDeWkvWjsMxKanGZmiq6pVEIvZ3DtQZpoz/fAVdGMHR9qEYiF9AQxl/mHWZx5iEaT7aGqY3MZGDNVUbjogubn7FtRqfy3e/ms+0VL2Khg1vTR4aPqq2lq4KhnXzYYavoi+jAurol9pcIeZvBzMHU7K4xzpEqppLUjj538QWRGVj5v7Z4Awd0RdHYO/3dfZqj74fEl5AzoHM+hWMifgT7oTHfY+GujDQIZ4xaJKDQjdRSnytff5C6+J9biN4FBIVINBwAAHTX08i4b6AfkYS43I0Ip4+3XsMgyXHzcpROmdcsiWzyYdkgqYu6pHHag+gJoncUZfzC6pDtALeiy/RGf/lnfu82RqEy75irrXwvWXEhr9mEdftn9aKq3ySps7Uc1vGgYDvIjErjRdg97lAB/UvZijla9ODg7ENLZIiPabL+0YjBClEMTvMJ3zbSvqvn+QTdtARLVf+4AIToPaOgG+CgyrR7oy/YgwheS0jTHIfRkJdxe+S/f1ACdlKJxnS3sLfCRIc9DNVEeG9Qj+fqwDysqRMj5k2OAEgrT8ojOitUE6lDeF+5Pkhn7K1hSbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 12, 2024 at 12:00:01PM -0800, Dave Hansen wrote: > On 12/30/23 08:19, Michael Roth wrote: > > If the kernel uses a 2MB directmap mapping to write to an address, and > > that 2MB range happens to contain a 4KB page that set to private in the > > RMP table, that will also lead to a page-fault exception. > > I thought we agreed long ago to just demote the whole direct map to 4k > on kernels that might need to act as SEV-SNP hosts. That should be step > one and this can be discussed as an optimization later. What would be the disadvantage here? Higher TLB pressure when running kernel code I guess... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette