From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: David Howells <dhowells@redhat.com>,
"Jitindar Singh, Suraj" <surajjs@amazon.com>,
"rohiths.msft@gmail.com" <rohiths.msft@gmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"stfrench@microsoft.com" <stfrench@microsoft.com>,
"pc@manguebit.com" <pc@manguebit.com>,
"jlayton@kernel.org" <jlayton@kernel.org>,
"nspmangalore@gmail.com" <nspmangalore@gmail.com>,
"stable-commits@vger.kernel.org" <stable-commits@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: Patch "cifs: Fix flushing, invalidation and file size with copy_file_range()" has been added to the 6.1-stable tree
Date: Fri, 12 Jan 2024 15:54:53 +0100 [thread overview]
Message-ID: <20240112145453.GA8959@lst.de> (raw)
In-Reply-To: <ZaFQUzBBEz7RifIX@casper.infradead.org>
On Fri, Jan 12, 2024 at 02:44:35PM +0000, Matthew Wilcox wrote:
> On Fri, Jan 12, 2024 at 02:21:55PM +0000, David Howells wrote:
> > Jitindar Singh, Suraj <surajjs@amazon.com> wrote:
> >
> > > When testing the v6.1.69 kernel I bisected an issue to the below commit
> > > which was added in v6.1.68. When running the xfstests[1] on cifs I
> > > observe a null pointer dereference in cifs_flush_folio() because folio
> > > is null and dereferenced in size = folio_size(folio).
> >
> > Yeah. __filemap_get_folio() works differently in v6.1.y. There it returns a
>
> Let's cc hch so he's aware of how much pain this change caused.
>
> Never change function semantics without changing its name or arguments.
Maybe the maintainer should have pushed back if he feels strongly about
that?
That being said backporting any fs code without first having done a QA
run just feels horribly dangerous to start with. People need to stop
doing that.
next prev parent reply other threads:[~2024-01-12 14:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 12:57 gregkh
2024-01-03 23:40 ` Jitindar Singh, Suraj
2024-01-05 20:50 ` [Regression 6.1.y] From "cifs: Fix flushing, invalidation and file size with copy_file_range()" Salvatore Bonaccorso
2024-01-06 10:40 ` Linux regression tracking (Thorsten Leemhuis)
2024-01-06 11:34 ` Salvatore Bonaccorso
2024-01-06 12:02 ` Linux regression tracking (Thorsten Leemhuis)
2024-01-10 16:20 ` Salvatore Bonaccorso
2024-01-11 11:03 ` gregkh
2024-01-12 8:12 ` Linux regression tracking (Thorsten Leemhuis)
2024-01-12 14:25 ` David Howells
2024-01-13 5:20 ` Steve French
2024-01-13 8:47 ` gregkh
2024-01-13 9:31 ` Salvatore Bonaccorso
[not found] ` <2024011316-cathouse-relearn-df14@gregkh>
2024-01-14 3:23 ` Steve French
2024-01-13 17:02 ` Matthew Wilcox
2024-01-13 17:08 ` Steve French
2024-01-13 17:51 ` Matthew Wilcox
2024-01-13 20:38 ` Greg KH
2024-01-12 14:21 ` Patch "cifs: Fix flushing, invalidation and file size with copy_file_range()" has been added to the 6.1-stable tree David Howells
2024-01-12 14:44 ` Matthew Wilcox
2024-01-12 14:54 ` Christoph Hellwig [this message]
2024-01-12 14:26 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112145453.GA8959@lst.de \
--to=hch@lst.de \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jlayton@kernel.org \
--cc=linux-mm@kvack.org \
--cc=nspmangalore@gmail.com \
--cc=pc@manguebit.com \
--cc=rohiths.msft@gmail.com \
--cc=stable-commits@vger.kernel.org \
--cc=stfrench@microsoft.com \
--cc=surajjs@amazon.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox