From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F5CC4707C for ; Fri, 12 Jan 2024 07:21:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9841E6B009E; Fri, 12 Jan 2024 02:21:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 931526B009F; Fri, 12 Jan 2024 02:21:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81F036B00A0; Fri, 12 Jan 2024 02:21:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 726926B009E for ; Fri, 12 Jan 2024 02:21:42 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 31DB1120CFA for ; Fri, 12 Jan 2024 07:21:42 +0000 (UTC) X-FDA: 81669814044.29.C3226CB Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf12.hostedemail.com (Postfix) with ESMTP id 7B26140018 for ; Fri, 12 Jan 2024 07:21:40 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=F+XHcFcW; spf=pass (imf12.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705044100; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=KEdkNivyIg3PurhJ3VjHntzXTr+Tal6Xval7en+bt2s=; b=8cKpZckRQf2tOYsy7ejwSxmFThLPscQBmddghwah2kBhedmoSo72b0/nmpxL8k36ifQiom uum7kS/uejESzQwRrOc8npDh8WAYW0QHZsjGJrJUvsCfkOgWrFzXQD6/eIQsDwUNhltjp4 988Y8fFg2raFMgVy8VQE+gI7mxVZ47g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705044100; a=rsa-sha256; cv=none; b=15zkXfxvzTxuqobfOKonoWHo0TT3RVszU6epeE5st3vvdZkA6wy2OWWWDtzsp3GQHM9HnW MUfmldbKPoiH5YP7AypthI4FJ+WkZVX9nrJeCbpNwIbt4mrq7dqTyL2Mz/Y1KnZng8nztq Guz05qHFQ21pwd4rxkzPTlC/Nbb9q7g= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=F+XHcFcW; spf=pass (imf12.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1705044099; bh=rRQZLwAtR4o/VCOAcxTzVSxdZ70bLgI9faWJJSJCsAc=; h=From:To:Cc:Subject:Date:From; b=F+XHcFcWnw2ojCsRoBMmjj+t+/NROO0ERHC+NcXTC1y95tjpFGNQU9p+yDqGag/5c Sja7dnvAsNlzLkXnNtZ3CbGpZnInpGXWKBWs+VIO0QL887i5YfauEdXtQW6p2NFRwq Wd0ZEJmxdHeGgbXpmzLCAgctyEjN5rg1lek5IMCtX3q/3Vg/NG9K5nSRpVzRjULXMb akMZWrWUkeNfSIfxFRj/vyeljJ3YB024sgNgqiCBAhxIzZWgxDIdWjHmRDJEKVDUPB 4o8d/C6KimRHHjhxRqWvg0vUQOZu1HhrMrAof2aos5eNOIBqE+EsHDjsaG0i9o5tYW C8JpWe7vqaB1A== Received: from localhost.localdomain (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id A39453780894; Fri, 12 Jan 2024 07:21:37 +0000 (UTC) From: Muhammad Usama Anjum To: Andrew Morton , Shuah Khan Cc: Muhammad Usama Anjum , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/7] selftests/mm: hugepage-shm: conform test to TAP format output Date: Fri, 12 Jan 2024 12:21:34 +0500 Message-ID: <20240112072144.620098-1-usama.anjum@collabora.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 7B26140018 X-Rspam-User: X-Stat-Signature: hi4u58xzf8xtj6an93cnqo6mg4abyosj X-Rspamd-Server: rspam03 X-HE-Tag: 1705044100-918509 X-HE-Meta: U2FsdGVkX18DDOlO9vH72iaLOYB1t+66NU3SR141H2OrZkkRkZIrP/F9gnxkgqnESOHXspZa7fk3yfnHCDlzjsKLlasl2ZBstvoNqDN8K39iFf9cZmddZR8SqWo+DRdGg9yYyJgWPrvj6UB8CxCSmAbhAr4T1SNzmbpeEIkyoU8eTH9KIGfw03Pi+Pn6vtuIv9o8LFVSPh15jLc2+iBJuWb43R4NGgz0jGVqTgv8xuSlM52ePOtREkGIwOd15dzWj7SYqEX9h6+IcVagyTWCfy3632EK4k9Eb4ub6Aa665BnAg8N1gbjQMc6bkDLh6eTivRLJJM2+i+6HUS2Bkd3vHImceY7hYBRfMbzAond//YXQfPJJgsfD4bOvReOP4EQzqyPLhE8YkFJVWWzuQHpaEmH9yzaTNllU8Pzq7VWMNJ4mt9BPy3DFPjWhJXWLVAybwTeMvc9ToZedxjs2tYBMf2upUhwM9JpYp3TukYXrjOzk3GCjmFzjlmukNdVQ4R60Ov7+OxXoGjZeOK4WQ0w8XQzxXR+qcJw9ytHdf24syO8dX8zR2mJYncdAttc+PnTAeYz+aVpe/5ZNzg5ahqr18mL1ffcgfdGmJDtdxVt/2QGySlvRSjqeM96TPnGH8gbPzNfBX+pJPhQZdplihx4lNdY/RSJk5GM1eM6QUu+TVmHrPtsxvSx4kapLgO32bL4JHZdIdwv2r2CKCAiFEBFph9noEO5PH3r2fLQ4aEWOgzLdDS/H8V5Uw2zYUhasZLq9w1d0SNwAjXqx/ZU2mT91aK18wZaVfvW+ysUOlqYwAAJIFWeWffOhTBkjx8w/qemBuYo8b6wx8SwBE/9eUyEOisdcevM8nyzT7fkB0HJHpmxJt7c6/BE4xPm8qEk0Ov22nss6dHhAO3pP5g4RCXI0xuYvfBDrwxjxxcvxvZ1oMW9xcf+f/e8A99NYP6oi26XYbJd7+pmT3QWBJ/NWdQ 4DRBCkV5 Wu7s+pfHd4pOyfz9hAob3OZchh8URBMXvC59Umv7sR3SiPHijT59b0Q5SXGmSMy22TuEzPxe68Rg8i4+3XxBUg4RJGNS6VrEZ0HVaTv1cTuLMdbietEDLD0i1ICrA+497hIGaJ3ABbJTmrgtlS49qvPLL/XuiO/RIgUD6CpZCHWxQTu0/V9XReFrsysHq5npHyLCH36naAMLeRcnnQLKr3p4p7PkLhNq/cUFV58mvw9dI7yRqBUBUm+2kpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. The "." was being printed inside for loop to indicate the writes progress. This was extraneous and hence removed in the patch. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/mm/hugepage-shm.c | 47 +++++++++++------------ 1 file changed, 22 insertions(+), 25 deletions(-) diff --git a/tools/testing/selftests/mm/hugepage-shm.c b/tools/testing/selftests/mm/hugepage-shm.c index 478bb1e989e9..f949dbbc3454 100644 --- a/tools/testing/selftests/mm/hugepage-shm.c +++ b/tools/testing/selftests/mm/hugepage-shm.c @@ -34,11 +34,10 @@ #include #include #include +#include "../kselftest.h" #define LENGTH (256UL*1024*1024) -#define dprintf(x) printf(x) - /* Only ia64 requires this */ #ifdef __ia64__ #define ADDR (void *)(0x8000000000000000UL) @@ -54,44 +53,42 @@ int main(void) unsigned long i; char *shmaddr; + ksft_print_header(); + ksft_set_plan(1); + shmid = shmget(2, LENGTH, SHM_HUGETLB | IPC_CREAT | SHM_R | SHM_W); - if (shmid < 0) { - perror("shmget"); - exit(1); - } - printf("shmid: 0x%x\n", shmid); + if (shmid < 0) + ksft_exit_fail_msg("shmget: %s\n", strerror(errno)); + + ksft_print_msg("shmid: 0x%x\n", shmid); shmaddr = shmat(shmid, ADDR, SHMAT_FLAGS); if (shmaddr == (char *)-1) { - perror("Shared memory attach failure"); shmctl(shmid, IPC_RMID, NULL); - exit(2); + ksft_exit_fail_msg("Shared memory attach failure: %s\n", strerror(errno)); } - printf("shmaddr: %p\n", shmaddr); - dprintf("Starting the writes:\n"); - for (i = 0; i < LENGTH; i++) { + ksft_print_msg("shmaddr: %p\n", shmaddr); + + ksft_print_msg("Starting the writes:"); + for (i = 0; i < LENGTH; i++) shmaddr[i] = (char)(i); - if (!(i % (1024 * 1024))) - dprintf("."); - } - dprintf("\n"); + ksft_print_msg("Done.\n"); - dprintf("Starting the Check..."); + ksft_print_msg("Starting the Check..."); for (i = 0; i < LENGTH; i++) - if (shmaddr[i] != (char)i) { - printf("\nIndex %lu mismatched\n", i); - exit(3); - } - dprintf("Done.\n"); + if (shmaddr[i] != (char)i) + ksft_exit_fail_msg("\nIndex %lu mismatched\n", i); + ksft_print_msg("Done.\n"); if (shmdt((const void *)shmaddr) != 0) { - perror("Detach failure"); shmctl(shmid, IPC_RMID, NULL); - exit(4); + ksft_exit_fail_msg("Detach failure: %s\n", strerror(errno)); } shmctl(shmid, IPC_RMID, NULL); - return 0; + ksft_test_result_pass("Completed test\n"); + + ksft_finished(); } -- 2.42.0