From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA5C3C4707B for ; Fri, 12 Jan 2024 02:23:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3BF076B009C; Thu, 11 Jan 2024 21:23:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36F1E6B009E; Thu, 11 Jan 2024 21:23:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2363A6B009F; Thu, 11 Jan 2024 21:23:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 13C146B009C for ; Thu, 11 Jan 2024 21:23:00 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D2625140505 for ; Fri, 12 Jan 2024 02:22:59 +0000 (UTC) X-FDA: 81669061278.10.EDB5513 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf30.hostedemail.com (Postfix) with ESMTP id 0D63A80005 for ; Fri, 12 Jan 2024 02:22:55 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YKNsFv9k; spf=pass (imf30.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705026176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IOY3Epy4FOHajS85t31/gWqJAZ4j+QAY311QoYrT4dw=; b=21aTj09npKH1oCHri/fF4Ac5si4Q85S76ang4k3OY9QgTFqk7QqmmJS1LIwqyr5wPLw/bb JfwqIk/9obq/lxjA67p+LuiAY5L/rOgGdQojsUBZJFxFeDm+K83fD0ePB+yClG6rnUEOuA kTQ6pItCuOvYbdyRi3Zzv0S5PMzATI4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705026176; a=rsa-sha256; cv=none; b=w+gbxXyodsIxEzbM/wTaL6Kv+0jD+I82RXH2wr0Vn4N2Ja4SLdin7N/Ucl5bPIyV9GyzB1 jmc0t7pZuWeXqCwvfGT9Ewc2UGV+RO/G/zTTuGfWcyJPm3oX7eXQ+IYpMUezZ+RQCslNM0 pMJ6eyjPR+pvtmlTiRla/ZJG68RritI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YKNsFv9k; spf=pass (imf30.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 116E2CE20CC; Fri, 12 Jan 2024 02:22:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3CE15C433C7; Fri, 12 Jan 2024 02:22:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705026171; bh=tyTBV9IdekZEBA9xRLni4pD40DGjP3N58wftXn8ECG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YKNsFv9kgq5yYP/cIwrMz0dnUCYFA0JwvReXfKnhB6RchpvGmsAMX2ImUNInYSbgy 0MlIM5a6ChjbnWvGg/mMwr0MziKA+O4JdGkHyAFKZ6wqINFKUcPz/BfJ3s2YVBCCsl uDY11gr6C0B9G2Pw3NkDcWFKHJJmOnl8QaplWAE4dD+btdy8IedQvLy+g81SjRzopZ tP9ybX81j0pP7w+ZLI8qhv7/NhA9rS/yGXioHOISF+2caZdUoPDJ+RFG3KbrXsGD5z UDXQeHGHZd8y+6eHOCw2cgsZcDpl2uqRxVBJFnqHlNqe6+44bi3i9FKpv2pIo0+eMs xiRW06EpYwf1A== Date: Thu, 11 Jan 2024 18:22:50 -0800 From: "Darrick J. Wong" To: Matthew Wilcox Cc: Andrew Morton , Christoph Hellwig , Hugh Dickins , Chandan Babu R , David Howells , Jarkko Sakkinen , Dave Hansen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Christian Koenig , Huang Rui , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, x86@kernel.org, linux-sgx@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH 2/2] xfs: disable large folio support in xfile_create Message-ID: <20240112022250.GU723010@frogsfrogsfrogs> References: <20240110092109.1950011-1-hch@lst.de> <20240110092109.1950011-3-hch@lst.de> <20240110175515.GA722950@frogsfrogsfrogs> <20240110200451.GB722950@frogsfrogsfrogs> <20240111140053.51948fb3ed10e06d8e389d2e@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0D63A80005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ragyacp1m7rotyr7cuoiuweonk4msy74 X-HE-Tag: 1705026175-129925 X-HE-Meta: U2FsdGVkX18/vXdIu52opMLuxgy2owU4cQjod3EbLYUNOfIiGNSyLaSlpnbAR52o25rnmldIM18QNUBOGdGYLR36YOA2VEcv5kTZTqCYeQOUKVlg8K9xI/Ar/hixHwV8rKTOGhvoGXM55V8bCTL3e++FKLaicwEepc+KCiDP1up7eba2Sqp9BGmkpz9iRSonPw+/yj/iz1vABGgrRI3LiV1x4fh84/9wW5CjVhOlNQOrp2UIAbmHh34x144VTcMxxbfW01ZWmpmi+DOylAcicPIAzfz5FtY4nL+aIyeZ/+URdo61l6UBN6OFD1TIln0J+UbFSnKM7McKu3YKMiFhNurZYdo9zNKJNKbIIHqV1sAglS+74QJwCQ0KdGEZRR5aQPWKxRVng+hZrVaiQe4cDmu7vGmEiHDOc1nY2KAdh6vPDslFCByamASBUJ4lPZZupIddYOslfz/qnHhrvKRNBRix9qXtM3kbmB9laMTAqAjCYwXVvVVTVm8Q4hOHprpXofnVJHce1PLsULsXdEfYCpTpeplHapsgvxChC8mjiZ3Oj8fTy1n0lc6u0/69RxXKGnWr7E8UoDQ947A0s0ZJYwBc+ZBJRrxvPHDZD2TQtOhHL36KkZNFx18JrtrE6xV2mdnOhaHK+ifsSWd/vHlxfHSzN67oJy5aUSbnASKmHUdqqUXtPkwko+kpEAULdxxb4AfKMtxN71CNFm8dVTr91w78BTDd2qeA4bd/SfNkuSiRUDhtvQoxPlCnw6NYFa2juknTa059WFt4hEwdshzpr+OS1I/GSKvsdFyvZSw/u+YEic0w9ys6e5E82MFC0A10bgIJ0z8iIwXfe+C9XJiaFsfVvePubmHuZfD7DCtKfV1XSl2h1GnAv+TaKRXVSqJiUpOh9iZwOTt9q3Mn8EFwTOEVxj2WDmdKK3PcBrMq8LJDyG65egneX+o3N0ynSQdDLsCRd1iWvcqldhvRiR6 jrB3L24G SX6j78zCvNdQ5k7Hl2+fwv558uyBgARX/OSDkJAe/vSaNegm2oXZEUL85E9ToRsGjELYWmOjyC+3Q7tdowYBEqbHyi7gnUX4ktQQr8sU7g/6d1PkHsrGHn45CN8tTa4deDeGvO61ceIxk/jep8B4qRPFfDSIYGxJCpJ90vSLLc2JOpwirEiJEIy6eiLiQQA13HBS21Q5Jejo/PJFtncCeZM9NUl9gCOTeRM6JPO0Odb2As4xLeaPAHy7tFnQY2KEBcA6Gf3blN+zZV0MYAZ7a47FTOO9bQSKaO8PD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 10:45:53PM +0000, Matthew Wilcox wrote: > On Thu, Jan 11, 2024 at 02:00:53PM -0800, Andrew Morton wrote: > > On Wed, 10 Jan 2024 12:04:51 -0800 "Darrick J. Wong" wrote: > > > > > > > Fixing this will require a bit of an API change, and prefeably sorting out > > > > > the hwpoison story for pages vs folio and where it is placed in the shmem > > > > > API. For now use this one liner to disable large folios. > > > > > > > > > > Reported-by: Darrick J. Wong > > > > > Signed-off-by: Christoph Hellwig > > > > > > > > Can someone who knows more about shmem.c than I do please review > > > > https://lore.kernel.org/linux-xfs/20240103084126.513354-4-hch@lst.de/ > > > > so that I can feel slightly more confident as hch and I sort through the > > > > xfile.c issues? > > > > > > > > For this patch, > > > > Reviewed-by: Darrick J. Wong > > > > > > ...except that I'm still getting 2M THPs even with this enabled, so I > > > guess either we get to fix it now, or create our own private tmpfs mount > > > so that we can pass in huge=never, similar to what i915 does. :( > > > > What is "this"? Are you saying that $Subject doesn't work, or that the > > above-linked please-review patch doesn't work? > > shmem pays no attention to the mapping_large_folio_support() flag, > so the proposed fix doesn't work. It ought to, but it has its own way > of doing it that predates mapping_large_folio_support existing. Yep. It turned out to be easier to fix xfile.c to deal with large folios than I thought it would be. Or so I think. We'll see what happens on fstestscloud overnight. --D