From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57B0AC47077 for ; Thu, 11 Jan 2024 19:40:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD53D8D0007; Thu, 11 Jan 2024 14:40:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5E8F8D0001; Thu, 11 Jan 2024 14:40:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C25B28D0007; Thu, 11 Jan 2024 14:40:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AFF7F8D0001 for ; Thu, 11 Jan 2024 14:40:08 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8C19F160381 for ; Thu, 11 Jan 2024 19:40:08 +0000 (UTC) X-FDA: 81668046096.22.36D7AD5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id CEE0112001F for ; Thu, 11 Jan 2024 19:40:05 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SPPtBjPT; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705002006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C3hlMFdn+OQb4M9O1Nzy0ZVGgF9XSI1qalBPvQ9f1+o=; b=0UEW37aQ1QtIVSNl/jlwdYXURVbhpCde8vOdnIuHR0ZCUyXy+hxjPDqOu96rT5s5p+gQTb Bx56TZguOhJjYh58GdY7TAYr12fz7+cKgsw6lcCBiLFn0pg1GdrxNJ/x/p/vuyI+RkC/Gz bxdPiAU3YfpZ00cG+mlBjW3vwktF/Ds= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SPPtBjPT; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of nathan@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705002006; a=rsa-sha256; cv=none; b=ZfL2GebNg+5NJox10TEMklmHgHHwfDIj5/3/lE652RTBYyMTlbv0CeyofJXOUzufcTCqIM uXpdCwsSb81qEVBdO5jmDG+ZcQzq15nDJG0JYbb7E5ZKvXTSOkRQLBpQA3ugcSWpr8/BrZ 2h/cXprTRThhqyIwFhSu5kMdyb+1mz4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A7724617A3; Thu, 11 Jan 2024 19:40:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFE49C433C7; Thu, 11 Jan 2024 19:40:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705002004; bh=DmkLUwPO5pHCJHvVcwPy1P4sgjTzQNNak+Eq1cUdG4A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SPPtBjPT+YAd4ocTNd3PGbSKeEby62sm5DsaPgCv2HqVIW9AA61WpCKjUG1nFowUj 3KfWsd59L33mr3lPW1pODJ4DxPp3c0FvcL65M+M43Xd0dsozkiXoWTzMQXYyp+ok+1 Cb30aWs3Sxk5AodiSlMI4eMG+NABT1HgniB893pjpYDswpLiHA/yPSOP9UoGeJLbKt bnTkQNlGsDQqy8YOmI7KSXeLlghLdU+zlsbZoTu+RaMYkcWjxf+xdeMOQ8myzu+KXS 4DFQ7cH+eAqKWFGmhszUBwC2NDKu/wiPRUDEP+5/MhjNc4xXnfccYuJTOa5a8NwKDV Z7nFRX4xsl/qg== Date: Thu, 11 Jan 2024 12:40:01 -0700 From: Nathan Chancellor To: Yonghong Song , akpm@linux-foundation.org Cc: llvm@lists.linux.dev, patches@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-pm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-efi@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-arch@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, bridge@lists.linux.dev, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, mykolal@fb.com, bpf@vger.kernel.org Subject: Re: [PATCH 1/3] selftests/bpf: Update LLVM Phabricator links Message-ID: <20240111194001.GA3805856@dev-arch.thelio-3990X> References: <20240109-update-llvm-links-v1-0-eb09b59db071@kernel.org> <20240109-update-llvm-links-v1-1-eb09b59db071@kernel.org> <6a655e9f-9878-4292-9d16-f988c4bdfc73@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a655e9f-9878-4292-9d16-f988c4bdfc73@linux.dev> X-Rspamd-Queue-Id: CEE0112001F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: hbph376xdzo7imiqtg675ad5z7mh7kjs X-HE-Tag: 1705002005-914660 X-HE-Meta: U2FsdGVkX1/MVfjQAvvHhNYQOicYnz2a/vjT+wKOG9jo5LA3HydPAaSu3KG7f0TKVFlOXldlwSLDMhC0QmTencGZS0fqWLN1+M5y6bk/53j0eAy7HQ4IuuvM7Wll7B1a1INLz8Sp9Y7qyLZGow090vnB2mDyRE+mZSbdUOB4+XxSHxs9weHgonZf9Rm8ogeg83DuLiYzwGDBaajWxsRRJn4S3SrigBtWpDlQYnc/C0UDX5ZXGWMWxPXXloK608f0UcQ1Rkx19bh0o4Fsd/OZYZLmFgfSLS99M9GnMXkBeL8a1apq/u05MXtOFmCGMfRLR/HDdxiNtXKMlVmlMDkzvlMnihHiynQLLLfKUE2f657h17O0CcDMm5rxdXCEYkM42Vo6ic6A4UdbCMnZxzo1vkzxA3iTTa5nmRYJx3aR5yEmRR34b1oYoSiCGhobI/ak1CpBNBpA7ODMNxJIW1o6qOw7Pi22/540ZycUfMwK7werYadRCUr8VoMJ81VmNgiMUm+/DNGb7DyL6wsC/WSKlm0A5ErCdLJIcgtE9q0Pb6V/XtPzq3d4n2TG+YnkobRQJ77jg8XSEtA3UBhASznbhnpcv8t3iLJAXQ/sKcfJn1eqmyPOqiGVcnqXqnhviF1WfDbPMoZrnswsLZZnl3moXxrxG2Qh+XQSP+WMb3tNYR6HpK0VODUFmsjixc7ngezWp+nn/aGjlVp+kpXauImxbkaTLtcki/amflzhzpZ4f1KeL2AjPxqrPdwYTuykDLDATPaUbJl1wqyofViWrWkZwnUu4bsT5lZNP49F3w9k0TICfXbRVY5F3rQPJmgOh/KM/VGy2D0IH0dfdelwA8O50wLsZEAFyZiiJ/4JPS5SepYGIxpo6iAuainAGib/MG5hl81O0LRtT+pjv6qBl4NNnfxJbUSdNEGAXBGYoUmAQty2wKeJ8lNGib5MKd1bPc1mhF1dhcwcNM4lCIRyaT9 jiYBdQyw GGqkoxTUdICiXprNOMHAiTFeV+/80SIyNbmRIbzUD5QaX5E6OV9CE7gkxm9Ug5tljyPIDYhQuoyL6jsjQ3lXERkqj6Ir82LfTrk6xroRBF5CZ/PgQ/vHqOKEr8hzEsSHoMfYZzdUH8rS2FcgkWcwHYYR98rjqASO+jVM08+bqv9cM+cKwqV+9LvefDPgnzq5Wcam5Z12ilwusaeM5s79mprVVPD4XKzfWAKEqVHWBwTTBrjz1Sy5GC61ohidlmBLq6fzpCHa3HlVnLmDe0ytS2wD5kXPft0ho05HzpAWpJa03wPeAOIDTVPGjWx++zzomm2a749RDfgVBwY0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000156, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Yonghong, On Wed, Jan 10, 2024 at 08:05:36PM -0800, Yonghong Song wrote: > > On 1/9/24 2:16 PM, Nathan Chancellor wrote: > > reviews.llvm.org was LLVM's Phabricator instances for code review. It > > has been abandoned in favor of GitHub pull requests. While the majority > > of links in the kernel sources still work because of the work Fangrui > > has done turning the dynamic Phabricator instance into a static archive, > > there are some issues with that work, so preemptively convert all the > > links in the kernel sources to point to the commit on GitHub. > > > > Most of the commits have the corresponding differential review link in > > the commit message itself so there should not be any loss of fidelity in > > the relevant information. > > > > Additionally, fix a typo in the xdpwall.c print ("LLMV" -> "LLVM") while > > in the area. > > > > Link: https://discourse.llvm.org/t/update-on-github-pull-requests/71540/172 > > Signed-off-by: Nathan Chancellor > > Ack with one nit below. > > Acked-by: Yonghong Song > > @@ -304,6 +304,6 @@ from running test_progs will look like: > > .. code-block:: console > > - test_xdpwall:FAIL:Does LLVM have https://reviews.llvm.org/D109073? unexpected error: -4007 > > + test_xdpwall:FAIL:Does LLVM have https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d5? unexpected error: -4007 > > -__ https://reviews.llvm.org/D109073 > > +__ https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d > > To be consistent with other links, could you add the missing last alnum '5' to the above link? Thanks a lot for catching this and providing an ack. Andrew, could you squash this update into selftests-bpf-update-llvm-phabricator-links.patch? diff --git a/tools/testing/selftests/bpf/README.rst b/tools/testing/selftests/bpf/README.rst index b9a493f66557..e56034abb3c2 100644 --- a/tools/testing/selftests/bpf/README.rst +++ b/tools/testing/selftests/bpf/README.rst @@ -306,4 +306,4 @@ from running test_progs will look like: test_xdpwall:FAIL:Does LLVM have https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d5? unexpected error: -4007 -__ https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d +__ https://github.com/llvm/llvm-project/commit/ea72b0319d7b0f0c2fcf41d121afa5d031b319d5