From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8002CC47077 for ; Thu, 11 Jan 2024 15:55:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 013086B008C; Thu, 11 Jan 2024 10:55:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EDC128D0001; Thu, 11 Jan 2024 10:55:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D557D6B0093; Thu, 11 Jan 2024 10:55:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B5C526B008C for ; Thu, 11 Jan 2024 10:55:21 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8EC03A1526 for ; Thu, 11 Jan 2024 15:55:21 +0000 (UTC) X-FDA: 81667479642.06.2F42E09 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf25.hostedemail.com (Postfix) with ESMTP id 6CF41A0002 for ; Thu, 11 Jan 2024 15:55:19 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iMYt55bf; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of nathan@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704988519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f80aj1snn84SI4nj1xZZePKJZBrWGQOfQekJaNo1C9o=; b=NiancKeh/r89JBZuXGK5Xz050Mo7LYkRYsdT1S72qnoBBQX9xXPoz/AW/cofskQTlo05nh R0tuwm4Ojf0jxRQrHS8THoTimDXADM6Iq2MItFv+J/lLDj6+vyIe/+qiwWUYft5J2xtuOY Acq2VVubWniC9jBUvRbloe9cDzYXmr8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iMYt55bf; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of nathan@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=nathan@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704988520; a=rsa-sha256; cv=none; b=OZCogCDc81wO1lmTSmm7rytVrW3BVEo/2ykCF1zMKvvFZTYXmey84QOw5/Bq0hsJseORmi 27slNertFUrhW+vggPqX0+SC8iWWhpZ1CIkEOlzuatoCFGW8sRaKlHkz4fwzH4XnqwMidh 0bw/uifAo9fyCIiaMozMhpNZON2tHkI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7E802CE1FFF; Thu, 11 Jan 2024 15:55:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BA56C433F1; Thu, 11 Jan 2024 15:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704988513; bh=DnXBtrvk/IS9GuQJA1+8G+V0JxY/FRS95VNaOLPHcEA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iMYt55bfOJZKlbU2ajfSYoGf/KPFvSFtYDJlxru2THpRxBcS6JV0wbAu+z0pvoKnY UPMgMyzr4sOGWbu+o/sz6hwTubjtToDFMiOKahOF+FFw3GxnYpCAeFVGkRJ/7hdR0F ECbvG0PGpI+ABpSBD/ou8lOCzb+lepZ5xqoO2dSZkFzdBe25pVgs0rXQD8oSqwv24k dYErq6ggotivkRG5qW8DdAcjDbc/uH6GeQ1v9OWk84u5HjCMVfaXq+2OsYxeEg9std /M4qh5v8mtK2CTihhTYbX6YVtoFFzUW8rKezQVvNRNo5T+qzn9uhzOm4MqNKD4UWmi fvfxCVqVhSJyw== Date: Thu, 11 Jan 2024 08:55:11 -0700 From: Nathan Chancellor To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , Oleksiy Avramchenko , kernel test robot Subject: Re: [PATCH 1/1] Fix a wrong value passed to __find_vmap_area() Message-ID: <20240111155511.GA3451701@dev-arch.thelio-3990X> References: <20240111121104.180993-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111121104.180993-1-urezki@gmail.com> X-Rspamd-Queue-Id: 6CF41A0002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 4cjomj9erbki59owwjirbstiedq6kk9n X-HE-Tag: 1704988519-869606 X-HE-Meta: U2FsdGVkX19JGcXSkC/a64YFH8nqhsmMMVj4d4HZ4FhJT1hhe5BmVCmJG1+X9GVgmuJo1FNxQ0xaYL2ui6X1QUagWy4DoSGsEzhA0cVgmusbFJtkX4i8sClGdEN2NqV9oFmoddpsdLCWTJ5/res1JA1vLH6X9AW2jlYXaK0hCwhnd6XYkyj+tcQWSX8HaizSHxDkSwJVmvFmiZtHfEe6EQKI3Ohl24uMK5axD9z4hx3OK3+wHQ5EMv6cGqbdDrtFXDXWIZYIuErz75vj0CKAHldZ0C8V/559UtjRu1jcICuJLg7/rYD6vIbtLxmjbWXL4K1c53usQLHjwz32iB9mdzw7/NoJBh5CTy6YcIwIvdw430MZRNG/i5eHqmYPVTH7G1I6el1aHmbm1bQgfgIl46coKpvYNxWbnxzLKlouFcBvffeXMOkPofEFpmHVEIsJR49F5WPVVqjAwVSyR505q3ltPomE8CZv6u3yE0Mvw1rpe1y1RiNFbDDzg1QA331fTZ7sRP7Afjwj+ZyrA/WR+ZUH/uNOQZNoO/X/XRQ3rAV0xG9f6PKQmpqlA4lVJ1fqboZ3OaIElgch+nvQ2W3c3qi3PCZzzYGgR+8fTxKChnAjIij5MJD5UrI+5qVgIUMAjpxgiiGjF3MgEt37g4zd9OT7+oGTV2PoMEloT5/Zx27RX1y30KJtbwhhUB8bcgrQF1uBWAzOKJ2zuYPw0/sdGjMPwZcskih5E5btzF+YFWACNxjH3/Tc9Z7s4BYGoihAXiOUizRhPkqmRAOfixg807Yydch3yIPgfKQmBzDydONbSwshgsSUp+0ZCMoZPD7LBgwW3SL4sDUf+iUOi0ylzKyKpjDNp/Q6MuoIE+RmyIX+SKBecAJX4FoFGRdBvkwjvY2J8cz5gsfo2bVyo+vqSr6r3euEgEL3vxdajaFzwrx36a7UOgIryohSuGQEpDp1h9+6XEZABFi68/uqbl6 dNtfxtXB O/8t1T6ZIRT3apbACMyIbFxzTZbD0LCcrLfceMzeaw28dwEfZqj7e9s6cKVa8N0ipY4c2kMr1eFjz2/xiBUmaXGZ7zIVzoqUKNT2QOEt7Cg9SKXDJH/pj77Mbsd8Uc0BpgsagBupBpHj/vtvOOrXqLX6/seh8KhjlZnPv45Fu84gF4ieCXCjU0AC8mEEytBnw3jWQImsQINBMEWOcAYc8wtGxszUL//t63R4XOlNkuHByB8viSWCdcIgG88SX1VY4HtZCNBWUW5vMTCM3mx7dbYKHDSVFqdfWF1UWYWyRLf8W72BstU06i09n5SOO0SQ4sJHtzUhIImigvDITwDai3FJ4+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 01:11:04PM +0100, Uladzislau Rezki (Sony) wrote: > There was a type in the vmalloc_dump_obj() function. Instead > of passing a real address which is "objp" an "addr" was used > what is wrong and not initialized. > > Reported-by: kernel test robot > Fixes: e88b85b81d5 ("mm: vmalloc: offload free_vmap_area_lock lock") I am not sure that e88b85b81d5 introduced this. Based on the diff, I think it was actually commit 86817057732a ("mm: vmalloc: remove global vmap_area_root rb-tree"). Does not really matter for the patch text but I think it does matter for what change this gets squashed into. > Closes: https://lore.kernel.org/oe-kbuild-all/202401111810.TKPIXLCs-lkp@intel.com/ > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index e30dabf68263..43a6608e1397 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4688,7 +4688,7 @@ bool vmalloc_dump_obj(void *object) > vn = addr_to_node((unsigned long)objp); > > if (spin_trylock(&vn->busy.lock)) { > - va = __find_vmap_area(addr, &vn->busy.root); > + va = __find_vmap_area((unsigned long)objp, &vn->busy.root); > > if (va && va->vm) { > addr = (unsigned long)va->vm->addr; > -- > 2.39.2 >