From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FDBEC47077 for ; Thu, 11 Jan 2024 22:01:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C0E56B0098; Thu, 11 Jan 2024 17:01:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 14AA96B009A; Thu, 11 Jan 2024 17:01:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDE216B009D; Thu, 11 Jan 2024 17:00:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D72E86B0098 for ; Thu, 11 Jan 2024 17:00:59 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9462280D1B for ; Thu, 11 Jan 2024 22:00:59 +0000 (UTC) X-FDA: 81668401038.28.013842F Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 94F4A1C0012 for ; Thu, 11 Jan 2024 22:00:57 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qIvPiOKi; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705010457; a=rsa-sha256; cv=none; b=YNJYSKvrc68mNi2T11p4vzaTkmw0kmBKYRp3aNuQnlNayvL08CbQ01VOsb7XyEdfTjqxGn PVo/h/OHy8AaUtIMsxrd26euGG+ZDrMpObG2BWTbGc4+rsEQMvbDPhPBAy/eV95FgXB2ua 5p+SB9vYwE6jNnTI6BOMohNdeMeRMmk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=qIvPiOKi; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705010457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S7oYDf60c5CsmtZsW4gdsv95k5+vxDLF3RmlwUVSvok=; b=ySoglsSqVGC1Gt607YgoShwQXC2CpRCatoLifMsME/w0tmRd7rZKesbg2OQATvLsU4Gfsi ccziM7pR0kprR82srninrClfn43LFh1HvbIJ/fWPntwJGM0EpfsEdNASTMq4wwAfyy6CUr BtqBRmETF6QdoEA/wv4Pb0P5Dn4fIHE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 2314BB82167; Thu, 11 Jan 2024 22:00:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95314C433C7; Thu, 11 Jan 2024 22:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1705010454; bh=vlcXcSpUY2+iSpuukyjIiihCIi15p9GWtN159qEPSmg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qIvPiOKiywb3qKHwOw4AhxARGX3rVExMAkYo9hv3BHT3igPRSW4BaNs/lMgeuCScm OMsg/kzkPq/hxRZ/bZeoPwvh42KWA/I7luc0doLezbSsgxia0Ctm69ZJlaEzbOp9kf lV/bWz9fIPnphKtgLncv+J9AiA29wA4qUYIWfEOk= Date: Thu, 11 Jan 2024 14:00:53 -0800 From: Andrew Morton To: "Darrick J. Wong" Cc: Christoph Hellwig , Matthew Wilcox , Hugh Dickins , Chandan Babu R , David Howells , Jarkko Sakkinen , Dave Hansen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Christian Koenig , Huang Rui , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, x86@kernel.org, linux-sgx@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH 2/2] xfs: disable large folio support in xfile_create Message-Id: <20240111140053.51948fb3ed10e06d8e389d2e@linux-foundation.org> In-Reply-To: <20240110200451.GB722950@frogsfrogsfrogs> References: <20240110092109.1950011-1-hch@lst.de> <20240110092109.1950011-3-hch@lst.de> <20240110175515.GA722950@frogsfrogsfrogs> <20240110200451.GB722950@frogsfrogsfrogs> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 94F4A1C0012 X-Stat-Signature: nqodon85j8o4u4patpk5rpcbeh1egtbg X-Rspam-User: X-HE-Tag: 1705010457-330253 X-HE-Meta: U2FsdGVkX1+unqyJRETEGLNE9Gmn/1S4mgsBKBnon1pWz3l2jSbKHHbALcTKwxf5Qg44CVOkQAL3g0iNEpUK1cestyRxtJ64ta8wQDQM9KjFPbXJnSEr+W9VmnYJMsJfSxyaToD2M9DQy0cqdP55D2QRZE2L9cw0L11rJutBwDhlBYfw4HkX618Alr0Ik/j/iV/ba84owqB3+viLYMdXDLk2zzkLZGVloUvxNyRZqqlo2m45FVH3O+clUERD+BbUkyp7E6AXzC9IebszpjHhqFwN6B2diwpax85K2x648pxV5j4eQakWKJtxUAI37sjfy5lAUhOhd0HF/zyNnAJV1YllT4EIegzaUMcsGtCycdPGd2JKxihQz+QTwWkh+0BDd+oWN6aIB5ryPZEeLAG4oqEqzLSWrv4rsTnXIuHy4JmxpXxT8QIIRngAPgGMdM8/BzTnC82dLtwGeVi2gVi0RrxJM0IG8cH99tNnZqDaGhYIYs7XIHvbtfqja9b9AT+POKZkcZdTyRNFZ6ke1L/HQO14aCvkdhOXuzxlMlN5b4e2qXmQ5GEGnqsyyY7zW0afF9IA+/RScq5Eio2Lh+ELzIaF0eeFl2j//6QU5VanzBh5xxNb/uvTyAlEO36mny5iABVJMe5P346oF1sUfT7w52ZLTDhUgx5YIgvuE9kWl47SAIEotTm62RHvUSiZFEkABqv100YsmfeNnjqB8E9ZvFSruji3rjhMSkT4b0JGu0i8/hjg2edduJWOy9jyvx1DejSef2w9+374xJ4FqvBKWo9u1QDzFQVp8ZxxAIMMqqkRRQHR78r9leHd9PutfAj6r1fp3D/zjlAdINEh6vMdUOXxpRDPg+s6TA4vk2U5wejEEy3Q8bcBPIB9xEqOgkVn/mk7EHI1vSzAYjX/KwD1vC+U049PjJfwuKk4pVT74mwhfpeLYneXXj9Pxi256nTMxytry0AxEFyZoA3RInu AWUJUjmK 6/K2W+JMt3PzcfUk7RbDLU4gvzkYSfVXPMYc3BCrCMkSEvTDngNKckdmNihwF4WG/0Q2yefft8hp+rwrVlFcEpLTigiS9/JgvPwRm9ouZ72aKAbIhoxfVVu0zgDav36PmAg2GNutcsDZJBpRpA8+SLnJQ1aJHnIq8yQx0SBqZiEO91IJmBvhpRcKrS2N8L7CYts4qYFMdL/szJa/akdubmhWByxFPfXFDMyMd5friQyzyAwoLokrMtI3IAFheT0ZWmle6HWVMex1nWj4sAEJJn/fcrQT/FEDg3t37GyPJZC/0g3Z7GQtldziBfEFrz9OgtmeNfidtgaEQgPQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 10 Jan 2024 12:04:51 -0800 "Darrick J. Wong" wrote: > > > Fixing this will require a bit of an API change, and prefeably sorting out > > > the hwpoison story for pages vs folio and where it is placed in the shmem > > > API. For now use this one liner to disable large folios. > > > > > > Reported-by: Darrick J. Wong > > > Signed-off-by: Christoph Hellwig > > > > Can someone who knows more about shmem.c than I do please review > > https://lore.kernel.org/linux-xfs/20240103084126.513354-4-hch@lst.de/ > > so that I can feel slightly more confident as hch and I sort through the > > xfile.c issues? > > > > For this patch, > > Reviewed-by: Darrick J. Wong > > ...except that I'm still getting 2M THPs even with this enabled, so I > guess either we get to fix it now, or create our own private tmpfs mount > so that we can pass in huge=never, similar to what i915 does. :( What is "this"? Are you saying that $Subject doesn't work, or that the above-linked please-review patch doesn't work?