From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2272C47077 for ; Thu, 11 Jan 2024 13:43:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 926186B009D; Thu, 11 Jan 2024 08:43:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AF0C6B009E; Thu, 11 Jan 2024 08:43:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 750286B00A0; Thu, 11 Jan 2024 08:43:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 61F046B009D for ; Thu, 11 Jan 2024 08:43:42 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 25221120C5D for ; Thu, 11 Jan 2024 13:43:42 +0000 (UTC) X-FDA: 81667147884.06.3D0940F Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by imf11.hostedemail.com (Postfix) with ESMTP id 5A13F4001B for ; Thu, 11 Jan 2024 13:43:40 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=3PJR6IG6; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704980620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1KFXDERr3pDZlcRyum1ggEXEmpPYyroR1nfySc9tJl0=; b=3XCCDbo03i0WJ+ey7vHcC1onTnlYfamD1NRpqegee9qrgb34A2/osbDWA30+U483kvWEl9 THAngcBfTQAgAEGjAsbWEAUTEswQVriueQfq62m824TPhL1mnKrdef3suv8MAojlquWV0e fgEkaXapCbjHfRlI2GNp786zQqlWvmM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=3PJR6IG6; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf11.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.160.171 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704980620; a=rsa-sha256; cv=none; b=mShCDud8KmOPDZ13Ak7GhwfCO64/Hr+FnnRrgCFA0UYyfzRjfRkdLAIvUNwrrJLfCgOMlG +glMWoJUFkh58JuKHmbmEdGV7t15iaUbLGYZBJeaec9tOKXA4jzowzaTVqRAQvilS2MM5H e/aXNrzj3/I25JzTa24VCa/ujGPyOqQ= Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-429be992974so4890891cf.2 for ; Thu, 11 Jan 2024 05:43:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1704980619; x=1705585419; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1KFXDERr3pDZlcRyum1ggEXEmpPYyroR1nfySc9tJl0=; b=3PJR6IG6Vbti+bKasqhsHA6+pNIZbJjUQxtiL/+R97ZAWOKrTV7DcIHKTK3lGpbZ7J WnHmpRpESaZxkTR4cyzlCw9hnPVlgXuf9LWEzaiHlOiVIxkFrD/QkC1GVH9WZ8EvoTC3 gjy8zhArqVD9pNVNOrU11IF3tVjS6i5Kc+FU9QGvQJUtNKMwswffuH2PByYmwNASD647 voqcnKQGdRi58N+R8r2cvYmDZJ3MSLFGRvhRBTQY0+8ei0FQ0WH5o4M+uOIxo5O77/MV FVqSkVdSE9NOh6ourZh2XODrJlmSTKJqKWED8bB1JKOAFGDbsXZLHUIIriqVT2brUk9U hzww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704980619; x=1705585419; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1KFXDERr3pDZlcRyum1ggEXEmpPYyroR1nfySc9tJl0=; b=lzmRDVps5JGVlVYErt2usI7gdlFgd3ebrhEg4lHLkSxABI2Cu+NT3H01TaqpCu9QnM lSZ6Gn4bmrkqPafIG0AYl2HVkQRubi6svzuzSyW2MwBzBRt9U/IutZ6lo3Dqj0SOxl5w GAJb1wekS+DY0ZRRxKVIK7ba/fC3LNUVhfdKAZNSAaLU5H9usZVTxSaLCmTRRYsqXYCZ SMCVCEVX2tBuCvtajIyT/dzAZaiwYuYd7PI/sAA/Lw8i1LgEQZDP+zq2hLCccSP5OxP7 AjU81qZnB/QXbqcGEc0odzqjUru74gN26WFH8LEJmKAoCoQumqCBDcsKjkk4dCCZ1jZR +FDQ== X-Gm-Message-State: AOJu0Yxf4h2gqvSBaC4nUR12wAumFkIRHrCPUysC9A0KUGjzqafQV3a3 e5C4PwasSC9fSDf1dUXiqK89Xcut6Y+Eww== X-Google-Smtp-Source: AGHT+IF1SDgwokzxyx1Lo9I3aSo2nbw9Nk3i7W+ba4rDycvJdrMVL4Kmi9FdBM0vduMgOwrl+YPC2g== X-Received: by 2002:ac8:5945:0:b0:429:be1b:fd8e with SMTP id 5-20020ac85945000000b00429be1bfd8emr701915qtz.33.1704980619331; Thu, 11 Jan 2024 05:43:39 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-da5e-d3ff-fee7-26e7.res6.spectrum.com. [2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id wa6-20020a05620a4d0600b00781de2da438sm341939qkn.107.2024.01.11.05.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 05:43:39 -0800 (PST) Date: Thu, 11 Jan 2024 08:43:38 -0500 From: Johannes Weiner To: Zhiguo Jiang Cc: Andrew Morton , David Hildenbrand , Matthew Wilcox , Chris Li , Michal Hocko , Kefeng Wang , Dan Schatzberg , Yosry Ahmed , Yue Zhao , Hugh Dickins , linux-kernel@vger.kernel.org, linux-mm@kvack.org, opensource.kernel@vivo.com Subject: Re: [PATCH v1 2/2] mm:vmscan: fix shrink sc parameters issue Message-ID: <20240111134338.GB390292@cmpxchg.org> References: <20240111122451.682-1-justinjiang@vivo.com> <20240111122451.682-3-justinjiang@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111122451.682-3-justinjiang@vivo.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5A13F4001B X-Stat-Signature: jqsadiqifp3qho5h63u1sbwqrebfmtge X-HE-Tag: 1704980620-95691 X-HE-Meta: U2FsdGVkX1/SByjFGmBia9R/HzMahVTUvrrda79rEqedsFk+iK0FAXJblc8jqB8AEGdOrBTsuNWq/LemB5HePTjaak8qPmDaT9TEUyE+0sKb82WIEInGsvA0lluBaywRTNddEon5lbCVTb0L9a4JWa3ieXi1jTIrl0P767w6P0b9VWOXn2EmmKz5HzFy3vKtix/WL3bMGP3GzG9Eek0c307X5TJHWRfLBLExOZpS+8s4/0FqQgpgw+6xSIoY7LHDgruzIqUc5cKFu/dp0oAn0w2wMvHj+3jIa7nS542CMDAGkzRPK1OFdx9JUsK+GqAMNc+Yyx4mUwcaLVUuXHtd3Hf58jV2cUIKLt9nC/S/mvsfsCspaq1iX3wTYzESfxlhKkvGFQ10QFyh0U018ZXyYjcWHadWNbR3hSCZJRvnJ9bpbWILTsYMAPVD5iVQHOMvxIroNdmNDlhXM9wbcCxQm5/mjd0I60te3TcjE/pGznHKH/f1q3iFhiENCS6R3xlcXIQjlRv4aedD6H5po9BIcP9GnFvTP4+9CsWPjAEAzo4uMeuuBHAKVy85k3RcJtOJL5RYhhG2wJUQLvuloax4I2Ljf/+4NCWgPSE6lpmpRtgXxrjsn/aWODAS3OoAY75NfA2DqM3Ft5EGF03yvehKrWwG1F0tbWHCz4m3fP9Lau8nQ255GeV14xa/ieZOyCAZZXAL7sQPVklVW+cUFYiVun/5ZoLmnGcMio6nRadKXPsbqdR2YPo1o3NFV19IzKqmittmdKzkgkJM+0URaGNE79hE9Tkr3f0wshakPw+VQkNq28Y66UDalvdW7qXdUs6EgwVAmsCDcQsn0jYvotWxZu8W1mEwZFSj5ZtHqnOlNUc1GSd5VcQIJsyCgcTgOBG8ocTr86RRk56NgTcpJHTLqm79ljTdyq7DbZ6f69ikcuUjNEm51dSyS4DN0AI6w1gSK0EvBF7+52cDOiOSQCe 72STJdnD wW4WnfaxSjLIyE6rl5VcTJR9JH6IFIXgwAYU7hp390ieUTlJGUkE6hxpA5iAfvV5d0CF6Q2LirGqu/s5L8iisRZ4KBrg1PA/5bCOrqaQl/wVHRv2QCMiuxB05e0M+xKKnWy9Cdt6tG5gxge2pY0uAARwB+Ab1tPif/KnpRtCowQ8ayzHj3W2BYIhD45dTc5hnV2kBLN3lzAVha7lV9FwfE/JTq6JHL07JtErPo1uQ6NFcfRd1LHzrzqtNLNyn03yOZw7wZ84sCIVq8/u7T1UKx/J1upD9iaBwtfOY03jjLIGTKrvke8rMAEjjb1n3Hv8/5YMgxPDGbD9E3QR151hntm/TB2XLTbm03jxzSrnVCr11s89nMJBP4pBCHUPyad93dquyBlODrJdEfO3mEeb7nmto2V4wx7qgIzfMLRdPks9oEJEO7nIypOwD3yBJmaJ7FwYP7OJHXFYD3A1zgPnMNaoYfh7cue1/HdojguEgVdUVpsmTb9A0DH8WApS12+NNp3a2j2BNDTlkVzy4hfC153RF0Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 08:24:51PM +0800, Zhiguo Jiang wrote: > The values of struct scan_control's members obtained by > prepare_scan_control() are always from root_mem_cgroup, rather than > the memcg where the shrinked folio is actually located, such as > sc->anon_cost, sc->file_cost, sc->may_deactivate and so on. This is > an inaccurate sc values for the actual situation of the current > shrinking memcg. so we need fix the values of struct scan_control's > members are corresponding to the current shrinking memcg. You don't seem to understand how cgroup reclaim works. Nacked-by: Johannes Weiner