* [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag
@ 2024-01-11 13:26 Uladzislau Rezki (Sony)
2024-01-11 16:16 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Uladzislau Rezki (Sony) @ 2024-01-11 13:26 UTC (permalink / raw)
To: linux-mm, Andrew Morton
Cc: LKML, Baoquan He, Lorenzo Stoakes, Christoph Hellwig,
Matthew Wilcox, Liam R . Howlett, Dave Chinner, Uladzislau Rezki,
Oleksiy Avramchenko, kernel test robot
The vmap_init_free_space() function is called only once
therefore tag it with __init. Apart of that it access the
"vmlist" variable that is located in ".init.data" section.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202401112056.I41bELL4-lkp@intel.com/
Fixes: 86817057732 ("mm: vmalloc: remove global vmap_area_root rb-tree")
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
---
mm/vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 43a6608e1397..257981e37936 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -4834,7 +4834,7 @@ module_init(proc_vmalloc_init);
#endif
-static void vmap_init_free_space(void)
+static void __init vmap_init_free_space(void)
{
unsigned long vmap_start = 1;
const unsigned long vmap_end = ULONG_MAX;
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag
2024-01-11 13:26 [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag Uladzislau Rezki (Sony)
@ 2024-01-11 16:16 ` Christoph Hellwig
2024-01-16 21:23 ` Lorenzo Stoakes
2024-01-17 6:08 ` Anshuman Khandual
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2024-01-11 16:16 UTC (permalink / raw)
To: Uladzislau Rezki (Sony)
Cc: linux-mm, Andrew Morton, LKML, Baoquan He, Lorenzo Stoakes,
Christoph Hellwig, Matthew Wilcox, Liam R . Howlett,
Dave Chinner, Oleksiy Avramchenko, kernel test robot
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag
2024-01-11 13:26 [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag Uladzislau Rezki (Sony)
2024-01-11 16:16 ` Christoph Hellwig
@ 2024-01-16 21:23 ` Lorenzo Stoakes
2024-01-17 6:08 ` Anshuman Khandual
2 siblings, 0 replies; 4+ messages in thread
From: Lorenzo Stoakes @ 2024-01-16 21:23 UTC (permalink / raw)
To: Uladzislau Rezki (Sony)
Cc: linux-mm, Andrew Morton, LKML, Baoquan He, Christoph Hellwig,
Matthew Wilcox, Liam R . Howlett, Dave Chinner,
Oleksiy Avramchenko, kernel test robot
On Thu, Jan 11, 2024 at 02:26:28PM +0100, Uladzislau Rezki (Sony) wrote:
> The vmap_init_free_space() function is called only once
> therefore tag it with __init. Apart of that it access the
> "vmlist" variable that is located in ".init.data" section.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401112056.I41bELL4-lkp@intel.com/
> Fixes: 86817057732 ("mm: vmalloc: remove global vmap_area_root rb-tree")
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> ---
> mm/vmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 43a6608e1397..257981e37936 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -4834,7 +4834,7 @@ module_init(proc_vmalloc_init);
>
> #endif
>
> -static void vmap_init_free_space(void)
> +static void __init vmap_init_free_space(void)
> {
> unsigned long vmap_start = 1;
> const unsigned long vmap_end = ULONG_MAX;
> --
> 2.39.2
>
Looks good to me too. Feel free to add:
Reviewed-by: Lorenzo Stoakes <lstoakes@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag
2024-01-11 13:26 [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag Uladzislau Rezki (Sony)
2024-01-11 16:16 ` Christoph Hellwig
2024-01-16 21:23 ` Lorenzo Stoakes
@ 2024-01-17 6:08 ` Anshuman Khandual
2 siblings, 0 replies; 4+ messages in thread
From: Anshuman Khandual @ 2024-01-17 6:08 UTC (permalink / raw)
To: Uladzislau Rezki (Sony), linux-mm, Andrew Morton
Cc: LKML, Baoquan He, Lorenzo Stoakes, Christoph Hellwig,
Matthew Wilcox, Liam R . Howlett, Dave Chinner,
Oleksiy Avramchenko, kernel test robot
On 1/11/24 18:56, Uladzislau Rezki (Sony) wrote:
> The vmap_init_free_space() function is called only once
> therefore tag it with __init. Apart of that it access the
> "vmlist" variable that is located in ".init.data" section.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401112056.I41bELL4-lkp@intel.com/
> Fixes: 86817057732 ("mm: vmalloc: remove global vmap_area_root rb-tree")
> Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> ---
> mm/vmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 43a6608e1397..257981e37936 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -4834,7 +4834,7 @@ module_init(proc_vmalloc_init);
>
> #endif
>
> -static void vmap_init_free_space(void)
> +static void __init vmap_init_free_space(void)
> {
> unsigned long vmap_start = 1;
> const unsigned long vmap_end = ULONG_MAX;
LGTM
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-17 6:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-11 13:26 [PATCH 1/1] mm: vmalloc: Mark vmap_init_free_space() with __init tag Uladzislau Rezki (Sony)
2024-01-11 16:16 ` Christoph Hellwig
2024-01-16 21:23 ` Lorenzo Stoakes
2024-01-17 6:08 ` Anshuman Khandual
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox