From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1FCEC4707B for ; Thu, 11 Jan 2024 21:14:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 595196B009B; Thu, 11 Jan 2024 16:14:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5468E6B009D; Thu, 11 Jan 2024 16:14:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4362C6B00A4; Thu, 11 Jan 2024 16:14:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 33B1B6B009B for ; Thu, 11 Jan 2024 16:14:14 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F16831C16D0 for ; Thu, 11 Jan 2024 21:14:13 +0000 (UTC) X-FDA: 81668283186.14.E1AEC87 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf27.hostedemail.com (Postfix) with ESMTP id D52F440014 for ; Thu, 11 Jan 2024 21:14:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=m20FhbrG; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705007652; a=rsa-sha256; cv=none; b=vpaBG/nV1j2RSQd9PMnGlZk5kFmlxLTB2ciidHz7t2aY67QUWUkOl7oMJZ2BbDDs9yonWI yGnk431YXKh5MU57Hvoh0CC2g/sgYfcVRVYCIs8Nzr08rCe7CRWHTX76I9+Myyoc6cAMTC V/5xYIEe8LOalRWNMglGqT0qYrd6QWM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=m20FhbrG; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705007652; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fMNWxGLYarDxoCYeBLYO5leROVlCBrSrwjOxtBO8Zls=; b=6/T7lsKTt0usnv6eiEU+BSongpncZMeU+M/FcESvNCKvH2WdDKNkLFuu8tQATQbomEkYlz iShkJ+wQac7DaSs0NGoFbE787VsrALLG1KNEfNi7IdAmijTEPQohocqTd1jDjsAKzeyy4R oBTgwq2n+z4zK+2WT6AzmCByQan9Wn4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D4653CE2112; Thu, 11 Jan 2024 21:14:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C515EC433C7; Thu, 11 Jan 2024 21:14:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1705007646; bh=KluFjsv67Zzv4EJRU7xqsvgiJikPQyze7Cf8ZgqSCis=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m20FhbrGGOqwjqsNEt1pNssDuYEn/rXR5ntOE7yUlw8vd+A18DdEIgwGCmySqsWmM HTwPiklqO90WP0flT96lpytIYRuz5r6zQQ8DR6byWK4Q5kLUJjTPdrmX5mgdu+005A InqTak3NQpyZOm/ZvA2N5W9ZuESSbJDhonGj5ulU= Date: Thu, 11 Jan 2024 13:14:05 -0800 From: Andrew Morton To: Muhammad Usama Anjum Cc: Shuah Khan , "Joel Fernandes (Google)" , Lorenzo Stoakes , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: mremap_test: fix build warning Message-Id: <20240111131405.4b47521fb8884760d712e93d@linux-foundation.org> In-Reply-To: <20240111082039.3398848-1-usama.anjum@collabora.com> References: <20240111082039.3398848-1-usama.anjum@collabora.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D52F440014 X-Stat-Signature: d4xafiksqkw3csw4h1bxorkc6naay6o3 X-HE-Tag: 1705007651-914198 X-HE-Meta: U2FsdGVkX1+PW0hfVANHnlBok8fKH8lT3J0ZLPlp8oVE7J+wc9yixVFjNCF7/T27DgxNOhLtoD5G7AVyS09MXhkNQv4IRL3g8XrO5sHjFWfUb1Zr7TTlbqonactbP+cGGqUM+udepLbkriQF3WT0uZk1jPucilju4mJHu8Jrb0vseG078KyWl6D4bPCvkMqlx4JTXANXiQRaLaGzIep5qzyradYMW7Ru5iggn+WGin17eA4NHeo79QcYhSm/JkY8H2T+UGvJ6byduCYY7Oaart2VmBD+S735id2bRMUrT+IjiFHkAAj2+RRFCyfbNKYaNYOfGqhRhBM5BULAInz5EIaR573Rag+JrdIEQPi6xCFHcK9tUUVK/y/yG4rQZtTL0ckHxESDAv3J8fFF8s8JgG3btcZ1GwiBhFiGSwwF344XyZyv0VsUFISYfAR6+IWtpCBM3NM2ipZwi20eC526rVb8bsutgzbUyetjFYQ9xVGZSxBupcBWlXB/p4hDpa/bvMkcX4MO78qLyNYOOOL87LKJDblAdjbZlhD4YXvTDNopLWQUSCmPJldwVfeOuApR2hTphruM6SX90maUHXrJQ40de84htoxPtppZOE8Nf371xachmMgtbuIlQ6KMQ7Gwd/NIZZ9Sa6GjXZ4Z4ApYP80DmMywSchoHj6hBxY5V7XgKZoqiRx/zP4AZcEelXED+6CGj+S242nytNItOgKVVIUr36lNExoi9glqJrlmmMfJzJy9kps3XiblEwiCP7AMJCClUNPjO/ACyp4FGmu6CZjSykfxFM909R2xjfUeObr6+N5pZxBk18zlvXQuxedZqGlCRDF+zwCLo0gU6/1IQhjniRzZ99rF43voEk7WxqcEcMTCaPceAFxM+jtt5q71CpIVAnG6njlV9dshN2KPTbcJ32wu8jSY6C2llQijLbFBVP+Zs/Ryl1+jjPgVKVTvePPm0nyslYvgwLVS9d6 ljx0kcme 1zTV8S0Wgmcm3TcmbqjUcCUZhmZficAwUmKwtTQWWJrx3HRfyB8kmzYnORBzo898NNC/LzAnDCi1OXP41HPGZZlo/9NnOADreT9m6St2hqh/adbmvb0VlaeZy+gI7F8WAQ53d5UOYRwVa0pYi8iAz3q0TkRogQgpLewFXoWRlLq2gH7ExX0b7U2KKAn9TOFsQNwUWfPM6XYoNbCeoEJeSdQ6+rryHo0P5LI9TepjvS+tSX8CAKF1K+XvHlvK+fZb8dphGzZOQP9tvl8gdlOeryzmn1Dqxm6RiFShecLin59s0W51rPrJlPRIY2CqzD4z9i5Sx X-Bogosity: Ham, tests=bogofilter, spamicity=0.001705, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 11 Jan 2024 13:20:38 +0500 Muhammad Usama Anjum wrote: > Fix following build warning: > warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘long long unsigned int’ > Looks good to me, but... grumble. `i' is an integer. That's just how it is, Blame Fortran if you like. Discovering that someone used `i' for an unsigned long long is like seeing struct inode *page; It is surprising, and readers shouldn't be subjected to surprises. `i' is used in two ways here. Twice to iterate across threshold values (as a ULL) and once to iterate across dest_preamble_size, which is an int. It would be better to have two different variables for the two different uses. Ones with more appropriate names than `i'.