From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 148CAC4707B for ; Wed, 10 Jan 2024 22:15:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 831E66B0088; Wed, 10 Jan 2024 17:15:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E1FA6B008A; Wed, 10 Jan 2024 17:15:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AA226B008C; Wed, 10 Jan 2024 17:15:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 572E36B0088 for ; Wed, 10 Jan 2024 17:15:09 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2E1DA405D3 for ; Wed, 10 Jan 2024 22:15:09 +0000 (UTC) X-FDA: 81664807938.28.CE7BC5A Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf15.hostedemail.com (Postfix) with ESMTP id EAA5BA0023 for ; Wed, 10 Jan 2024 22:15:06 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=T7tPVLGj; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf15.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704924907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qzYKfx3de59+vgu9hb7XP534ekilIGghNG65JX231Xw=; b=5F8o/3/kkbQk+UfhhdGNZQyYGIpODdE+M6pRJhl784pz/z0jJPM849+OE6KJQr/3ceC5+b 6n1urcyqgWkjiKBCRaEpBCF/M3USY3C7FsRA7omCfrZtfalKvTR/Z0o9MsJbn9YA1AEIwi IkJ9D7nR1dOB5UyIMNM84Ce+jM8XxB8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=T7tPVLGj; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf15.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704924907; a=rsa-sha256; cv=none; b=VVtisrB7Ob1e5UqpS13lg7URqUWelEZbpAJm3a4QR2AI3CEoiE8uXDHza5Mjgv2AW5WhMx ACWaTKvpJaoALoLKVetdGEMnII+/RRPmWbNEQHSZvyGh+A1Lqbirz1TQkNROls9FUh6bkw 6wTdLKhnSW78Q6uoRIc6wUhkfwIek68= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id E2EB740E01F9; Wed, 10 Jan 2024 22:15:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id nyXwZKqd1a34; Wed, 10 Jan 2024 22:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1704924900; bh=qzYKfx3de59+vgu9hb7XP534ekilIGghNG65JX231Xw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T7tPVLGjEkG/q/m/oH7mkFdDSm4g2QnCZlUFWhO4EGnjXvMod93Xmw38Bn6Qb02r8 nVFfOtjpQQjaePLyFHocD24AWkK+eKheKufHm6jIuZsdberpp7cjLKTTTL4Sjip/lF Sxjy//bcTKZlT06vTRplCHHl8DqCr+tPTSlSQC0WQqDmdH0Hge0WZKgYQj2tMBe/Rx Xr91oVHJxIbJ0ZwzFk4MlIv7acdNiks925JUCne17jxQPHPY4amCgxM59vOSaZgezg YVUqIxNGgpKG0Fsr+hv2s33cd3ENnb7hSAX0Qvx065ZjUprPxuH7YkWvagW5+DR5Ot Kemo2oqFTqg6S4xoCIC3E3WweV6jc1c4lXvDZq2yciB5bqbXCghRbMmNeFPYcVgbar vnkdWwdyOwC4GbhSLTHRzi0hOajTdSUSGK/B5RLAW8Zt5ACALLmT4+pEaqb406hbZs iOl9T/u3ucRUZKWJJAc6B9oVbP29ud3il+OUf2RAvWYjNOHSppvfdr8eQ1XADoPpoi yD8LSFO8WizFfqBxIv4qNn47XIKqyWwIcQRafgo7sjlVZhQrKeWYPMrmMReiNz5g/6 pnB79G3kp/jjse4W92qGlxhmpVRliPceQSyedFqsoc4HfF/fnlUSNqjajDUxgDdX+8 y3b1JVQnou1C5kImEixUgwGk= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 72F3A40E0196; Wed, 10 Jan 2024 22:14:22 +0000 (UTC) Date: Wed, 10 Jan 2024 23:14:21 +0100 From: Borislav Petkov To: Jarkko Sakkinen , Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v1 07/26] x86/fault: Add helper for dumping RMP entries Message-ID: <20240110221421.GGZZ8WvTGdNrWkUkfv@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-8-michael.roth@amd.com> <20240110095912.GAZZ5qcFXYgvPrCdRI@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: qw8a1ybe35fkhuc9uk1id9sfyfydsprd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EAA5BA0023 X-HE-Tag: 1704924906-238788 X-HE-Meta: U2FsdGVkX1/6z82TTZZTXsmm82aok3KheuDcZdTTe4kJN6RaUpBNaqQ4f1pTyTy3M+tMzkOqfOv57QHOV0nvmevY9Fz3zN2gS7T8TjKuybQ4qyF0F1p3+C4MwOvSj+N7cx4NNYZ1mmMdWipLN0JN3JF7ClWSQqIBB9RFlTZNFkvb/BCSgvY6O+wYSpfSCJYGiiA/VAgWXK7xFJDyIrAPik9I0Gf+3oTGFQ0kRncwbDhTTrsq/hn59MMwUGRp3iz+3/6biWN29IWy3zP2HSNbRrxrqgzzJI3K6Fw/1HE0bXdHG0TTuqi4FWrTix9WN6iGYLJrjIDM2HAfckMBrA1W1faKcGYttzzSzOb3k7amG3IK54NxigimZVk2IvK0y/XK8mNLcahxEr/V3RWSDUi9bjIhZehE0Y122afuVV5LEw/5oswiLb3hEHgefNgOnqD2bdUtUzsFvVevdflRhixXCdgsZHEYf+oYFeTPpw/vb8ccXWwvJBLzPnA9yzNrr7hVud1SjSWwSiN7bpi/gWRUdVzXFwK1bpZ8WAKlJBbOEcbySGhDyHjZ/ptQV6J8Qn4v+cVDmhVHjHfiMN+v8WGy13zBUPyi7wuI1gBqAFfbR2Ehv2i+1iwbBQ9wpErYphzdGM3hSWPT+ESksibB5e8pkJRcU/xSbtIvO5EUzel49FJkej+dbqPoMVWM/tpeM9IIwEzj9YOYuQ8FzH8GPQ0CbDNmjMMTagmefVcFkgHu605yxh+PATsfkOs4DfTNzbSO7bisqDDEe6R1SjrzkSfeZqMkepJfJYcB6ggAFxzCtyO0LoMYb+zOZKKP11R3WGR+iyD/ZXeOPMDc4/OYZy7gbyvNVRpk29YoRK2jI3kupBrjGuRi+wOjndSWLC0l6zmKpor84sj7VnNJMqiefFo0+lFflJyVSj5L/jOzaRI2ssjDvYNDBBTyb5w8mBUl2rypoVm6jZtNBWMcECFM8Hc 7fTPAYNo d5GBZYpg4kX5vvJT1tmX8g42aU3+bHn0DjoCAlWSDe2iNO+D2CLWHAusxShyYqol8YMXdAJ/2wOhyzJNyVduEs51GameIbK+MtKiWPGnrhkkFev+gkHH1CERnrdKIAI83I1zDqb97dxzGmLO6InFZ8fQAjPA9p3tMcjuAAyLpWTuxq+wNUJeMTyWaFkr7vCNB0aCWkeFeTOf3DwU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 10, 2024 at 10:18:37PM +0200, Jarkko Sakkinen wrote: > > > + if (!pte) { > > > + pr_info("Can't dump RMP entry for HVA %lx: no PTE/PFN found\n", hva); > ~~~~~~~ > is this correct log level? No, and I caught a couple of those already but missed this one, thanks. Mike, please make sure all your error prints are pr_err. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette