From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB9CC47073 for ; Wed, 10 Jan 2024 20:05:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4E4D8D0003; Wed, 10 Jan 2024 15:05:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BFDC78D0001; Wed, 10 Jan 2024 15:05:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC5F58D0003; Wed, 10 Jan 2024 15:05:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A6068D0001 for ; Wed, 10 Jan 2024 15:05:00 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6C22BC0AB2 for ; Wed, 10 Jan 2024 20:05:00 +0000 (UTC) X-FDA: 81664479960.27.C7E7730 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf20.hostedemail.com (Postfix) with ESMTP id 19B3B1C0028 for ; Wed, 10 Jan 2024 20:04:57 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BVS4MaRM; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704917098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5qJLi47aSfJDQ8HFMsPxwsJzBziVrXT5NMWHepLLxAA=; b=CIUNIunvfuDNQ1ZhYNoG21/BRLrgYiXXT838tqJljjIc1pyzoSQ6ry/ESIJPBZgj8630YD lZvlhAhap22JtD01VZsAhw9TL7hhLlxj/R2qDHqUvW5N5MmBm0oLxzm6dWaQQGeRsUUG9q 69U+cAmkVpoZGP1Tiht3ERhqKSbMiLk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BVS4MaRM; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704917098; a=rsa-sha256; cv=none; b=jbeH474nCUySlef9LIclD+6h2tovDeYVW1N5U55LNsT4ykj+APv5B8re2TphEk+3JAYGAa IycJvfKTxLE+UUPGafCyOMvtlcBXVaPrXS0MWvbu8Jx42yp0nHwZhdbAPxZBFtU8me03yj PYDv3XFaONLlLCvlKGkifd468oL3SHM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EF19BCE1DA2; Wed, 10 Jan 2024 20:04:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C5DEC433F1; Wed, 10 Jan 2024 20:04:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704917092; bh=74bvc1MrtZiDKmQ/bu3C4RVeT5D3DZCGTl3NffxKvZ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BVS4MaRMctsxFwGuMyM23YFJV6gby6teko8iKECcrhunk0OEiqeoTkDr1l/TiVGJo D3PqK71jNSb9LbpdngAb4xBI+6SuDkZvu8aVnJYNxh/OMisBhHqJ1KhotiNpAmbU80 wgGpQlW/jizt5hj1i4Su4y/pEDtNZeoWx582CriSM2ffbCyVxzXepeD/lZhUpUFhEL 3pZ64QIq99+20Ie61mUYNRaPAw8gMJJKci/GPwmdlok9izzYq7VX5rwp35NC0GRRW9 PaQ/HQP+gcVFQn1ip2QVte75pNWIrnqTRTsBfuM9W4XhUOM/TRqAV2Ms7tnOQHiw6E Dr+uuHbo0VtIA== Date: Wed, 10 Jan 2024 12:04:51 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Matthew Wilcox , Hugh Dickins , Chandan Babu R , Andrew Morton , David Howells , Jarkko Sakkinen , Dave Hansen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Christian Koenig , Huang Rui , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, x86@kernel.org, linux-sgx@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH 2/2] xfs: disable large folio support in xfile_create Message-ID: <20240110200451.GB722950@frogsfrogsfrogs> References: <20240110092109.1950011-1-hch@lst.de> <20240110092109.1950011-3-hch@lst.de> <20240110175515.GA722950@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240110175515.GA722950@frogsfrogsfrogs> X-Rspam-User: X-Stat-Signature: ojtjc7aagifboh6zhu3em44htg1qw959 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 19B3B1C0028 X-HE-Tag: 1704917097-129631 X-HE-Meta: U2FsdGVkX18mng3UBgiahRxpCfdvAxoWTsemY9XER3UeDqbXuzHUJSum3KsET5T9gBhroEJaaP806pZpDaplER0cawnstk99ATj4objJF5eQP45BwLXTt0nTEAVwNanzJvO37oZhBImrQybgxEMlvjVOwm95Nb7NqnerY6MlL4WguIKMy5aiWqrN8bycZoHQzg80ehHjyfp5eF+R8WxZYcTmUVP+ZPDsOZQ1FOBEbMvSaxGdusVM9KbyP/FgzhByio8ymgpic064muwCbCqnSSZDcczfJQeD7A+Q0i8c9/d68g3jWCyG8m2nfrsk5OLjU4U1zbCSjxMg7r+D/zQvD0xGTI3frZR/FTvsXGwl00mShM8FGPgFWwZxtu7RS/DOKkmZGV2VwXyRD3xN0Cs/d9+37AII7TpFlm/sE1CCtBQiPMkoGYog91+2jn4SlTeCClfsZpDlumDf4HguGkM5tIkTRwUc8Piarl0wgN3Ul8FCk9MQBQZixQ1XmSTcF+75Lp+EqdyBHnV9QDcZCUQTB03n2UfOE7TO81NFKCqHT+eM0LldsBxLitB0KpyfCt7PcvfTCxNrFN4SWDHK5HGxXOJwYmhom45rqOsk7BpFjfStvlNIa5+kG5xYPHr69m4JudoBfwlUGbrCrq8U5xBvEoCuUb1Ag5SHO0liod7MXQAOe52BgK7qfnM1kema7KdUFNeGr8uNTYlVV6dmaPV2pWX7dqxgMVFPHMxnuZ9Qp4V9OiYdK0yYc6B3xkQupZ94Z+5QpchypHx8+QIATkUGEhKO6mqIAVgj9idZVLF8ODYfN65Ic6ASrpLQfJp2GGwHj8wlSF1OEug2q16D91LGBWedjeCBJYJEuwLYAUmoDWIKEykfUNI1v6K2MWWyQiDKSB81bx8Rr+uuLCjWQ+mEsaleCVB4sNJMWReii9XUN98r288jIm1I/aqFcIR+S4HzkSYIPCTXWOJbzjr78ng P6BYi2eS WxgLT/QPNxlA5ONVgxmgWHNBLin73LMlOu9R3BRSPIJQM3IoyiW0EPCCwaoRijERlEInhJq1n0OPalsP5Z2HfdSnohzLKqlspkBl1ogl+6dywPNMDXS+mCsXLs5r5hJdKWwAwT9qWkWplmcBI3/WICdBj3IFIz98MrQE2od6l8uvjMB5x6y/nXq1ZG22X/9xdJ9jw8EouHWE+Tdz2KxKrBrJqJiPKMLjgyCt45ClS8VX14lNH6r23gQXYZEaQTxdVI+e7LR6Bvs/3gg+9+XPxAKPlObHraL4N8nMm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 10, 2024 at 09:55:15AM -0800, Darrick J. Wong wrote: > On Wed, Jan 10, 2024 at 10:21:09AM +0100, Christoph Hellwig wrote: > > The xfarray code will crash if large folios are force enabled using: > > > > echo force > /sys/kernel/mm/transparent_hugepage/shmem_enabled > > > > Fixing this will require a bit of an API change, and prefeably sorting out > > the hwpoison story for pages vs folio and where it is placed in the shmem > > API. For now use this one liner to disable large folios. > > > > Reported-by: Darrick J. Wong > > Signed-off-by: Christoph Hellwig > > Can someone who knows more about shmem.c than I do please review > https://lore.kernel.org/linux-xfs/20240103084126.513354-4-hch@lst.de/ > so that I can feel slightly more confident as hch and I sort through the > xfile.c issues? > > For this patch, > Reviewed-by: Darrick J. Wong ...except that I'm still getting 2M THPs even with this enabled, so I guess either we get to fix it now, or create our own private tmpfs mount so that we can pass in huge=never, similar to what i915 does. :( --D > --D > > > --- > > fs/xfs/scrub/xfile.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c > > index 090c3ead43fdf1..1a8d1bedd0b0dc 100644 > > --- a/fs/xfs/scrub/xfile.c > > +++ b/fs/xfs/scrub/xfile.c > > @@ -94,6 +94,11 @@ xfile_create( > > > > lockdep_set_class(&inode->i_rwsem, &xfile_i_mutex_key); > > > > + /* > > + * We're not quite ready for large folios yet. > > + */ > > + mapping_clear_large_folios(inode->i_mapping); > > + > > trace_xfile_create(xf); > > > > *xfilep = xf; > > -- > > 2.39.2 > > > > >