From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 192BDC47073 for ; Wed, 10 Jan 2024 17:55:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 756988D0003; Wed, 10 Jan 2024 12:55:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 706E98D0001; Wed, 10 Jan 2024 12:55:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CE978D0003; Wed, 10 Jan 2024 12:55:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4DCBE8D0001 for ; Wed, 10 Jan 2024 12:55:20 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1FEE0160B31 for ; Wed, 10 Jan 2024 17:55:20 +0000 (UTC) X-FDA: 81664153200.01.0479FFD Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id 5DC864000B for ; Wed, 10 Jan 2024 17:55:18 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JAygTEqZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of djwong@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704909318; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KqWfiVE5iRvRitAwMLcrI3UhLIIWIQXYm5ZpFDPQcl0=; b=OWnCkrsqKRmUcHdAF/9I4HI8F7SY26DMuPYo7DC0yigSeKaazqfco0IE48XgJRuOQ00B2A xF19Hcp06LOPkgigWeRyKwxOjgD07v+WgYIEw0X4F6aSIHh3DcaGxV6ffR3D9Zi5W3y1XO LWV0rEiMQMjZmDbphgwb8VgA31V1nXQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JAygTEqZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of djwong@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704909318; a=rsa-sha256; cv=none; b=67305uSVeUa4uhzoGcRYB2gGQAI8j7DxSgFqyGoh1khG+862RZ0mT1UjzyNJ1RXdAxtief lPLxFolsUiEeE/Fcfyl42yljoQgL0t6AEU8An2iYa6lTsNeRfotNEUSIqp5msKtLYKroWG ml4To+rgo/d52NIx0u9Y97enGdxgQdo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 912EFB81DC3; Wed, 10 Jan 2024 17:55:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCE8BC433F1; Wed, 10 Jan 2024 17:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704909315; bh=fu4Rj/eN06CEkV5JbSMpnHawgZaPLeLIgtEFRQv1w5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JAygTEqZWVfylCFiDRG7P1l/VNgkre3NkIa+TSKWtjTWzTjqWxGd+6jLl9JLq9Ff0 HkUiC0YShB3RTedTUqQpvGmjzfg4QuMwsAoJ/Jdw+Tb8AoAVZ2vkZw9wgCj3kSgF+j yzwcPO01+qwLDH/Y73uLhuwWnuWnal0emVdoFNiftr94w2BLYKTYdnr0oMLshOaGDd NBbRCi0am1LWayVzGsz33cPYmCO/+nX7iUneIlV6CMd6eTt5zF+47RDDPWe+BOqgei Z9rVGGi0mIBlfrbcxwOpuT5Te9ccn5QkF6yosVtLxF4wzyuFarxC28PHW4SJAiMXg/ agoDkyYabdckg== Date: Wed, 10 Jan 2024 09:55:15 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Matthew Wilcox , Hugh Dickins , Chandan Babu R , Andrew Morton , David Howells , Jarkko Sakkinen , Dave Hansen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Christian Koenig , Huang Rui , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, x86@kernel.org, linux-sgx@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH 2/2] xfs: disable large folio support in xfile_create Message-ID: <20240110175515.GA722950@frogsfrogsfrogs> References: <20240110092109.1950011-1-hch@lst.de> <20240110092109.1950011-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240110092109.1950011-3-hch@lst.de> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5DC864000B X-Stat-Signature: 1symcii8gisj65wa5mi6eb3kzk9aah76 X-Rspam-User: X-HE-Tag: 1704909318-387474 X-HE-Meta: U2FsdGVkX1+mCaONt79BERqJNfWVSjrOkc179aXlJqlMSX6u8uFoVrhoJnMa/aF9LEu6TUrIYd+DzBhVXxiH1kkN5aOJpwUtLlKBvCuauubCTZMdA+mJXKtZYOSaUcvxlI1T26kY3PoH9ppQNL1jzak5KCOxocZqCoJFOhTCRkW5RzZYvr9CaU29APLeZFYP7aHr/+3AGKxXt/kZCmdXpEJiEBobfVKHSBKRm7jdm6xqX1ZZ/k+cZYn4uI2u2tRzvfQWOwbJ+HPuPAa5uSLfI/FW3QcflGd4UwX65nvhqymg7v+0ZoLqlWnr5VNHCz2dVgE8vjyBsTsgRoh5V2z0/MW1xS2CUGtqtR3ABV7KhbOMKbTfXpl5VJrZkwOBDwXQzmbWqDVp0OmEZvwv5x5WyB80KCCuh163u4qci0Me0YeQj3fT6Ay2Tw9m//8nOUzytTbKXe9Cj/xx0mVvPrxdfeR/YRM/7J1VRinp7zyNiF5f2KYujdY949FyQliNplKyZSI0EILn+zN5DYcCKtCMG3aZ6bC8XUn0DRo40d0yGWNq0XHhQCcw7BzdpGQSd41Uza4MMCMbCfgssD7I6qoxWK0NGieuDlBY44vc0b730LjU5KQQPEkAPoLgz60HbpAUilAruNkHZwWxo6Zr4f37SZNK4Szv1oTywcbbRuPde6XKKG2tyhxLuh/k7YYomZkauNjy8RQ/G9+SPr6WBsJzi33gje69SJo648wf1DXA0s+IqMoEZseIoQ+ejTgoDsfyP8CD9bX1gCOHP5zT/2muwrqbIxpCqKyHy1Vs26RyzfLIOKbBi5wttH4hNM/XHISxXQ0rUjWj0lFAPa3SZm69htM7EKqwBWJm4GNEslMRpRuJRSRG9hJRqQ/esvgKP5azCC/8TkHwPuSEGFJOGzgkLmo7n4v1mOwK/fSYw26vLudtMmBSxVOmtp5J/EFHr4MiE9SvwNMwQc7gSeiX2Jw ywyYgNhO xhlIlKAFNxHvMIdP+URPcvwoJzJdarEjtQ7aiSdwlkq5njiJ0zZ29nBllvcK+uQhYS8lkxBmhQeUkX3e48tJsjDeeryb23OPlNYOjOK3uxef8PORuXs7WmbFdTUxgvs1hy3arR+ee513cqdU07RCEpNGZ5JezpRQ5HRAIuJFMA/A8SDhJhjEZ//mJgxle4FfqoetPJaFyfQKP++RkEjDL9emYDtUrTEraYphCYfvy0mWTSrF80Yq0X18YyaqXv6a3DLLWwsC1yKzRunOzuh4616DbTQeIfCENK+EE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 10, 2024 at 10:21:09AM +0100, Christoph Hellwig wrote: > The xfarray code will crash if large folios are force enabled using: > > echo force > /sys/kernel/mm/transparent_hugepage/shmem_enabled > > Fixing this will require a bit of an API change, and prefeably sorting out > the hwpoison story for pages vs folio and where it is placed in the shmem > API. For now use this one liner to disable large folios. > > Reported-by: Darrick J. Wong > Signed-off-by: Christoph Hellwig Can someone who knows more about shmem.c than I do please review https://lore.kernel.org/linux-xfs/20240103084126.513354-4-hch@lst.de/ so that I can feel slightly more confident as hch and I sort through the xfile.c issues? For this patch, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/scrub/xfile.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c > index 090c3ead43fdf1..1a8d1bedd0b0dc 100644 > --- a/fs/xfs/scrub/xfile.c > +++ b/fs/xfs/scrub/xfile.c > @@ -94,6 +94,11 @@ xfile_create( > > lockdep_set_class(&inode->i_rwsem, &xfile_i_mutex_key); > > + /* > + * We're not quite ready for large folios yet. > + */ > + mapping_clear_large_folios(inode->i_mapping); > + > trace_xfile_create(xf); > > *xfilep = xf; > -- > 2.39.2 > >