From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A207C4707B for ; Wed, 10 Jan 2024 16:18:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EC328D000F; Wed, 10 Jan 2024 11:18:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 275038D0001; Wed, 10 Jan 2024 11:18:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 115A78D000F; Wed, 10 Jan 2024 11:18:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EFB4F8D0001 for ; Wed, 10 Jan 2024 11:18:37 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CA2A8A045E for ; Wed, 10 Jan 2024 16:18:37 +0000 (UTC) X-FDA: 81663909474.26.DDAA536 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf18.hostedemail.com (Postfix) with ESMTP id CD5F11C0014 for ; Wed, 10 Jan 2024 16:18:35 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704903516; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MMgmClYQP2rczBiB3HtUnm/WUl9c7B5Jst5/4IRekvc=; b=5IaV/ZeZCQqgznBLlpq8NVIa65xN8WXiuFvdYe+tnlSPRE6rFMWH7zFgwfH9oeXdYpE+gF OcZB9DPDiFkOfOivcf6Bl+gIG4l924rM1Po8sbf5mL3n3BvkXFX5MJElPvi5S+CgXHmVZL FDWSDRc6hlLCgAKgJbLb4bgaQm4r3Vw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704903516; a=rsa-sha256; cv=none; b=j3a5PV26usfNdIwySAC3suEIPAK9BmwOui8U/JqMe5Zwk8DoolMFlVmF0h+Vb1vVAVj/u8 kfH5sG3ukGQS4WSaXlNC8fV+vytFkO6QLpKfI7tECkzLqgtjCXT7qU72tXTmHVwsHT1Bje z+yj/niGd/2lxeY78TJ0Fcmj7LVYwhg= Received: by verein.lst.de (Postfix, from userid 2407) id 9659068CFE; Wed, 10 Jan 2024 17:18:29 +0100 (CET) Date: Wed, 10 Jan 2024 17:18:29 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Hugh Dickins , Chandan Babu R , "Darrick J . Wong" , Andrew Morton , David Howells , Jarkko Sakkinen , Dave Hansen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Christian Koenig , Huang Rui , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, x86@kernel.org, linux-sgx@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: disable large folios for shmem file used by xfs xfile Message-ID: <20240110161829.GA1105@lst.de> References: <20240110092109.1950011-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: CD5F11C0014 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1mb7anh8fd8yxfw1icqfsooja5ryrfdw X-HE-Tag: 1704903515-184870 X-HE-Meta: U2FsdGVkX1+ZHgKfMwbu/kbOcA3+pIlu8+3yiG30I7JIsdSZzdKwDUdwBoGfcbIBCUhO79IDPvFlHWrPjBRRBOvDovxKC9dNHnHzTanq6eQe3BFZZlTVAUJULu/mn+n4bEBa+7FI4pkWJxG7TRk6ZgGJzKJhk0BK8bAUqwRHmQ/y1M2LXa400GcjzL9UOnY0NNqOCJZWwqmIzkarepl/bgePPpYWzqzV9O7WgPCcVPV5aU80obuO2o3rSNqi1Xs2wU2XEvUML7lsy5LNZONfPF5J86Pr0zVHwJ0kx7x1RCskjZW5V1qnGEZLw/C9v5XnvsbDzO9E0ox4/qhOSx4ViqqoSDoqbn9LGav8NTuSVZ4Ebtyj05aPpatqLEoQVcsTAjWYl5h/nVQAoS2KBmf89m17B6gNnTlx8lF946g3mIXFiwsLI33tYepCF48s2dwtReyitAKqwQbV/3brpgglp4jShprO7haBKEJxhSEPsJJgDH/PD8RJ99M5NlQ53QTfi8v66xeDXIFZ3HJpsJQOrM4ljmrIeUR3dGCkJO6TOazzQxRkaEer5S8do3KJvFU2XXxLkfGInxtZDh2q7SY1gmyJd8H7ofFTdjRUA++QgqvsGsfRVgxY1jFOsEOYrRYsbEJysT+MxzvgKMe29ga0HGOqax5ovzTbBGkzsI7j42FtDuNDcCDsip21g84Sd3mxgtT3h/XX5cwF/pINp3Wk+aDLB0Pvk4K8NQVkManVWuYl0Mm7KWk5l8ErhPJ7pvwcvsjeSWNclAHmpeEVWpVFKyFIsa3nH/ibQ3ULyfRecOdIYLqweDRuvhBJWR0WfyWs46xqihJhQUX5nCK3KPktdQAGo13gXnGO9YYhEdN2PX0JDB9IzWYT/pN637IywnfuNnM65LILyG0NT6Hv2rZiesoQJ1kes1n7pjxj07z356sD/1nkMnCs4PLx/IuOR7c+YsOAdBelIM/C+AgvWja IzUYqE88 3dlEGzDBB4dH9Lf2L8i3Fh+11XHfr3wXRW8lWkzvyisMZLbQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 10, 2024 at 12:37:18PM +0000, Matthew Wilcox wrote: > On Wed, Jan 10, 2024 at 10:21:07AM +0100, Christoph Hellwig wrote: > > Hi all, > > > > Darrick reported that the fairly new XFS xfile code blows up when force > > enabling large folio for shmem. This series fixes this quickly by disabling > > large folios for this particular shmem file for now until it can be fixed > > properly, which will be a lot more invasive. > > > > I've added most of you to the CC list as I suspect most other users of > > shmem_file_setup and friends will have similar issues. > > The graphics users _want_ to use large folios. I'm pretty sure they've > been tested with this. It's just XFS that didn't know about this > feature of shmem. At least sgx has all kinds of PAGE_SIZE assumptions. I haven't audited (and am probably not qualified to) audit that code, so I wanted to send a headsup to everyone.