From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1082AC4707B for ; Thu, 11 Jan 2024 00:13:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 948AA6B0093; Wed, 10 Jan 2024 19:13:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F9836B0099; Wed, 10 Jan 2024 19:13:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C1256B009A; Wed, 10 Jan 2024 19:13:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 685EB6B0093 for ; Wed, 10 Jan 2024 19:13:25 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3D5221C14B6 for ; Thu, 11 Jan 2024 00:13:25 +0000 (UTC) X-FDA: 81665105970.21.CC9643C Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf02.hostedemail.com (Postfix) with ESMTP id 731ED80007 for ; Thu, 11 Jan 2024 00:13:23 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=WqXMVTZd; spf=pass (imf02.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.41 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704932003; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Szg0f43eSi80PlaeJTnnx43hn+vtfqy0TLL8cXLjBsk=; b=zIDa3v0mnpmPtkCaI+86Q5a5bguh9XYZcPVRl0mNyBXwTiZeVapC2dYjm1n348G0++oz/o BXDHcJlL+MmARFEwFROyuOIu2xWZFjAQv1ZA0VS74r0j0v1fy+Gb1lTsLIahKNAAnIMcpE NaR/7X0VYUKA7Js50llyhKa+6s4HtKI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=WqXMVTZd; spf=pass (imf02.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.41 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704932003; a=rsa-sha256; cv=none; b=7op9zAvmeE8/L7VZfbRKZ/2kHYXHH317g1or2jOcJj+Zy5mOrcXMowNOoaefUyINRFtUHc tPTzxeqp4GaoORv8zLM/4bUZRSg41yY0gKDFlSlRcAtrwV8IzEnXkmANwa82v5mzbU2GT1 XMEcAdyZys55kAS0sACUo/+jMdlPpf4= Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-28cf491b197so2540298a91.1 for ; Wed, 10 Jan 2024 16:13:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704932002; x=1705536802; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Szg0f43eSi80PlaeJTnnx43hn+vtfqy0TLL8cXLjBsk=; b=WqXMVTZd09WPfckmb7ECwENbKAogfzGyYaI8S2IeRmsReUGsxd66z20zLI+PQ3Etcb 30jT8cGUB3wAB0uksh0UHCAMp6rto2L1nL45v5uZHEFkSlDMrS+ZiHHkY1RtY0ojaIOs AH5tDyIyd9I4hSLWwaAVUSlAYmfPvNmn3OHCo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704932002; x=1705536802; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Szg0f43eSi80PlaeJTnnx43hn+vtfqy0TLL8cXLjBsk=; b=XcsaP0hb7kLkE+hw9/g2ItB/+9vH6Ga68zM7tKVp7XTe+AtOGbCt5iPmNNQfcfUglh j3aPBim8vcqApUkQZKEo2yKRDvQraMRrNf2YO9en+msJL1dWlbslckDvPEFIhlrYYeYU D4yZtO7GoFo9XfEWALT4Z7w+Zt3OLaYb5LP1S0X3dRuJRs7ootHkr757C9CBKoVw8+Ov hv+jGS99v7IuTNkd6mUV/9RcIiFXhKXFY3UR8w/EuKvn3VdQBNBwVEbh5/wujb106Kri xpdzc9zrfjqvG5vDBL06oM55UX/loD6tt3ly0ooW4wD2wc/zfKANYxXtdtSzR/lzzBWC j0Lg== X-Gm-Message-State: AOJu0Yww9G/c2rS4OLOkx7UHWuPws+4qXL1GuWmIVQIiHVDNckg48ZQw LgJhPgVjhDBZovaFtMjHz8dyYzNgi58+2ir79tJpqIv8tXOb X-Google-Smtp-Source: AGHT+IFCHM86VQlaYtIos2K1xjkZsI+quKbXvg3z4JeRWQcS/8T/4zDcnuAe029PeahrP9liZJV6Dw== X-Received: by 2002:a17:90a:6e48:b0:28c:ece4:f3e3 with SMTP id s8-20020a17090a6e4800b0028cece4f3e3mr268411pjm.85.1704932002274; Wed, 10 Jan 2024 16:13:22 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id bb24-20020a17090b009800b0028c9d359011sm2158027pjb.32.2024.01.10.16.13.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jan 2024 16:13:21 -0800 (PST) Date: Wed, 10 Jan 2024 16:13:21 -0800 From: Kees Cook To: alexs@kernel.org Cc: Eric Biederman , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alex Shi , Sergei Trofimovich , curlinhuang@tencent.com Subject: Re: [PATCH] execve: argument list space enlargement Message-ID: <202401101609.F791E52@keescook> References: <20240103130722.1551670-1-alexs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103130722.1551670-1-alexs@kernel.org> X-Rspamd-Queue-Id: 731ED80007 X-Rspam-User: X-Stat-Signature: qp79xa9z7mwafw8u5yfg7zuggebqp86r X-Rspamd-Server: rspam01 X-HE-Tag: 1704932003-426334 X-HE-Meta: U2FsdGVkX197+tkJIQgdyT6nbtkF/yfPihpqhP3C5JgJkJhj/3ac/16EEKLhyokPHoJXr4oAYXAa3EWJByaHwTqOdhFeVWfFAAGIIhjo11HtnR3KBD90PU7XYvCsUFzi5iCWLLaL+Y6A1ggy8IiAR6cb5EUqR46NCBiUYw1GhkGY8O+xmdW2G4Qaf51DX/83zRKOg/xBl852dXyXvrp7N7HnCs/+YTPY4TjOhRU1q6lD8o8IeNfTLOi7B3wk5V/et3WrVQGCjYIzLlZsXSeQPDq/xf9rNNV2iq9V9rI18sVRblyTAl8QHmGIJ9CN96g07H/3O7NmglvCfkRJGbiTYB0nQ10ioSd0yehKuWm3prvRx0Pf77C9bOggX8Ney1VNRKylWe0MFsiSq5xU6RL/McfkpzyLAhWXf+715svWA4ZfTpw5z4PK0lugS6yVI9AR9nlE5DTNBZouH5Fe3HkfURuvJdoDDk5K26UAkicG8hPDnqGqLQgHho8Q4pP/PZASuS98+V4WLL/FT+lXKeOL0yJvtYH8DrIK+PGAgJi3tBLiWM6Ppbh4m/cCyXBwhh/Bk/IVnFkXhloAteRzOm8SoVlIyB9oq2zAQYltnJvKX7TqRCtnXWEBfp0ET5VMB3iKJdz3WeUmF6h04M24zBfkuqcYNwfpYD2atVpCJ2I7mGlHmGxceocLQmyXTeqa5g6kjAgwNG53LMBEokzvfdwBU8r+yaSh8Woqn08VdAW0R53FhHL2cwXC/OWVbOHZH63XyKas1wGqxwX1hPbWmp1HXqJBza4tJV0NbV+qr1PNE684uN15uOpjNASd7EIHLe3fHTDmxoykTIHa4bb2KA7EF8+R+tNXUYAj15byT0GPyGefdCTFXjO/ECADsgt6R7HPl9jCu6pMlyrNd+mvVobSb2RWhbM0WYfc8yOKazbPn2jFCEkDeBsGKVkMUxr6WGRevISwM8RaTVD/Pv89+Vu W5cb3xAR H6XnY1QTHPWEhCtMtlJm1cEFw98oBr8JL8TEk6TLBlG6mcnQDE9Stg2e9YBLmsQq8cBWmNPtmibYhDv6igEIVHFJsHJDiVkYsBz6Ycn4yFohkBQs8kPAgGRxFcG/nubqD63DFZ7fk7JVTocmzCKCKkV+Z8zG1G4Tgi6XtuL+WPR4GQsJw5geL7n7Tf37AEGw10ozs5U3ef0IQlnL2P1BYy1xALDcFQzAZYQzbH6xUsxxQZ8Ig3Z85M/rPcI+tg2c0as++XckKPh/1BlZdcAqh3nFWX9Tv+t72z7GZkYx+S+HFAe0CRbVUoR+KjpLw1PXDv7+HpgM/kp8UhqyOK9zJdj8XCFPRc3MQqRF/0hTjWTaWwdnvcOOfIzzz28FMvSKjyc031ko3D6CWTEB80lTW+oIvGbJbYYf91EF5i7UE4bYzszin3CbO844KlBSUuxj8K0cAQFzzUA3/phC1UAqzI1QeYpu8qU7gtuuPwMRlP6h+aykjRGR63qRojS/yXPgc+mWX2YTsPRIU7W4VEUJkWQ5XdcsH+FGaWr7sKq6Nf04uRzvKaDQiqMNwSOyFD1FdRDcvskzV7amoSdDBWfIhJsLnDzfAmxaXlmN/qmvfvd17bIGiBjh/mlJfeItYHNbMf0Z8a/tGay97KMM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000466, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 03, 2024 at 09:07:22PM +0800, alexs@kernel.org wrote: > From: Alex Shi > > Wechat using too long gcc parameters, then get a strace complain: > execve(...) = -1 E2BIG (Argument list too long) > Have to increase the parameter space for this, stack has enough > space for this enlargement. This is the second request recently[1] to expand the argument list size, but I remain somewhat unconvinced this needs fixing on the kernel side. [1] https://lore.kernel.org/lkml/202310170957.DF7F7FE9FA@keescook/ If we do change it, though, as I mention in the thread above, I'd prefer to leave the UAPI alone and just detach the kernel internals from that hard-coded limit. -Kees > > Signed-off-by: Alex Shi > Cc: Alex Shi > To: linux-kernel@vger.kernel.org > To: linux-mm@kvack.org > To: Kees Cook > To: Eric Biederman > --- > include/uapi/linux/binfmts.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/binfmts.h b/include/uapi/linux/binfmts.h > index c6f9450efc12..717f6cafe8dd 100644 > --- a/include/uapi/linux/binfmts.h > +++ b/include/uapi/linux/binfmts.h > @@ -12,7 +12,7 @@ struct pt_regs; > * prevent the kernel from being unduly impacted by misaddressed pointers. > * MAX_ARG_STRINGS is chosen to fit in a signed 32-bit integer. > */ > -#define MAX_ARG_STRLEN (PAGE_SIZE * 32) > +#define MAX_ARG_STRLEN (PAGE_SIZE * 128) > #define MAX_ARG_STRINGS 0x7FFFFFFF > > /* sizeof(linux_binprm->buf) */ > -- > 2.43.0 > -- Kees Cook