From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 832A0C4707C for ; Wed, 10 Jan 2024 14:01:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93E9B8D0003; Wed, 10 Jan 2024 09:01:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EF1E8D0001; Wed, 10 Jan 2024 09:01:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B8678D0003; Wed, 10 Jan 2024 09:01:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6DC258D0001 for ; Wed, 10 Jan 2024 09:01:51 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 095F6A20FB for ; Wed, 10 Jan 2024 14:01:51 +0000 (UTC) X-FDA: 81663564822.28.FA0E3FD Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf15.hostedemail.com (Postfix) with ESMTP id 977E4A0040 for ; Wed, 10 Jan 2024 14:01:47 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=aXPEbR+h; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf15.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704895307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=PfxT8EmwmFjjW5GAzJtI4xhYCxTVYs+9fiE3LzkKW0M=; b=74u4NbUk4YB7TqUHE4QTtFqJ50AQTCQgLc6i4RHKgilDBHR79h4MjsAUptBPKT4FBk8I2C ZIs5QiyqoWHGnXxhG7DtiPY5H0KddgtE/xY+szQLS6x/P89q1aD6aC4vqe2aOgyuFCY2V2 pKVjQWFaOz/Qo1mJd5lGaYyuPuaOIvA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=aXPEbR+h; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf15.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704895307; a=rsa-sha256; cv=none; b=LPI1lqWM11inl2b3BSDRr7K8AIGLgQ6gVSDYhbBoAcZHCeUpGQU/4lPZw80S6hSXXWLUiZ DAtf9Xi31RAO/Z3c+ffqTXA63R5v0sr36y3KK5iMLCAGUe2RnU8sNO1sFabTKaxD4FL9q4 pfIIUDwY70VKNFLT5/n3DhDk39KMbWw= Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40AD7Crh007939; Wed, 10 Jan 2024 14:01:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=PfxT8EmwmFjjW5GAzJtI4xhYCxTVYs+9fiE3LzkKW0M=; b=aXPEbR+h7x2iTM4dXrKhvGGx9DczTf6raefRo5ojFWj+EhKTZkYnD+Bjn6p9a5Ndxoge N5VW28QlZBoH/Zl1C5WIzcjpwdcGjpY/LLMIRnhNMUj5HiwJaSMnS76hS9wHyebEmGJm WWowBOs4NJAIIWJ1v0BJ4OCJhSpLzUbMfKPxxxd9Byrz6ZJ6mQjQ+edXPfMW1vaDi2Af SCLvdPNi6yQ+BSNMMlbosNcmsb6h/5wB6NhehsqNYDv4o3Lw2x7uHong9dQFqLWN50FQ mzqnrz+SSbHG1OvrpxUv0F7fNrlTiSdQtOuD8LAgcE3N4c8iASnkn+5XOQBehaZtr6Ot tw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vhuu9h7fd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 14:01:42 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 40ADjlMe004079; Wed, 10 Jan 2024 14:01:42 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vhuu9h7ed-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 14:01:41 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 40ACSXXI004395; Wed, 10 Jan 2024 14:01:40 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vfjpkwcmp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jan 2024 14:01:40 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 40AE1bIF18350642 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Jan 2024 14:01:37 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 53D7A2004D; Wed, 10 Jan 2024 14:01:37 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2BA7B20043; Wed, 10 Jan 2024 14:01:37 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 10 Jan 2024 14:01:37 +0000 (GMT) From: Sumanth Korikkar To: linux-mm , Andrew Morton , "Aneesh Kumar K.V" , David Hildenbrand Cc: Oscar Salvador , Michal Hocko , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML Subject: [PATCH] mm/memory_hotplug: fix memmap_on_memory sysfs value retrieval Date: Wed, 10 Jan 2024 15:01:27 +0100 Message-Id: <20240110140127.241451-1-sumanthk@linux.ibm.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: akujshpMwAbrdtpK1D1VWpnTYq87mmYm X-Proofpoint-ORIG-GUID: 1ES3chf0hnl4bulp882nvtBk7J5ErQgx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-10_06,2024-01-10_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 mlxscore=0 mlxlogscore=913 lowpriorityscore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401100115 X-Rspam-User: X-Stat-Signature: 1qsi4fq4d34fx1mux8u5konofysbqimc X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 977E4A0040 X-HE-Tag: 1704895307-351519 X-HE-Meta: U2FsdGVkX19/3sTgept0mzv2TC39f8HfbVfBEqsRJNRXJK1r6yDcVTTzxMxOTbHHXKXMVZfgr44PWmsnUhudYRE3vQd3/lnbXIJVf55+Zf+V4PnqmsRfb+AnKVDb9zr2OJXJ3eLFTNNhZxBu4K6SZLBy2PsSpf3sZvn6COAnf9OC2zkYx0pHv0ZkQE/SYWtUOz3nsUNATwFxsThBC72a0HMOY2q6TDjFywbN35epcxlv0ZtT9cqpIq0qa50vdVGg9OMuA1+0P2/WlFyQj7AmcfhgPYcK5BBDSxhWK8McDHUPScWxWGOkbUCiql4VlrhmvV0KvwNuPSf9jhC1tMGSr8OGsyVfdTLQGebt5dwssqp4QiSlB+AEEVqZj2N7jm+gnxZg1bKLAnsioV+N3HFvc7s3r4acif/tk6qiLCGBnfhQCC6YbdMvWmbhQ4cj/vtkOJ7EET+2hT5XdoUghTUI0WUxU4XP0REEaeooz2wHPMnMwvDhnqZdIs+TRzxXlfMmH/0FBHtyJTIkvjO5ILht0uptjn28Td9UpAYKrYZ3AqzJwvr8MsvGhErqDJXVjxFw+U9ov9BLeG/+fCP4AT8zwQkk5cdF00ufXfYVC6Xf4mdsPNzVAzOZvThbRCtF3nZGItOd5ysPaxa5YSQzPdR2Y7OHQ5l+19T2o/cs2TF+Xw/Atwa3jabcL/X3RD4LLJ6ciKd2xez/HDzPUEPDdsoq6UjEbB39gMy12Innit8YX5shQPThxShflL99CL1eu+qDCRlkg9xlVDGiE087nPT821o/M2Thfv5h8edAb8gTO3P8O46WGbbsxvKNBBw2fY5BvSCI6AAe/rHpjUIOF6cqP6Pimn4KZkOLbfysTIv7IFiyAnCXJMV8dvXyR7o771/6qcdV5KtFAv8yNAlfAfDoTPr80Vi42kec X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The set_memmap_mode() function stores the kernel parameter memmap mode as an integer. However, the get_memmap_mode() function utilizes param_get_bool() to fetch the value as a boolean, leading to potential endianness issue. On Big-endian architectures, the memmap_on_memory is consistently displayed as 'N' regardless of its actual status. To address this endianness problem, the solution involves obtaining the mode as an integer. This adjustment ensures the proper display of the memmap_on_memory parameter, presenting it as one of the following options: Force, Y, or N. Fixes: 2d1f649c7c08 ("mm/memory_hotplug: support memmap_on_memory when memmap is not aligned to pageblocks") Suggested-by: Gerald Schaefer Cc: # v6.6+ Signed-off-by: Sumanth Korikkar --- mm/memory_hotplug.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index b944e8bf1911..707027f69150 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -101,9 +101,11 @@ static int set_memmap_mode(const char *val, const struct kernel_param *kp) static int get_memmap_mode(char *buffer, const struct kernel_param *kp) { - if (*((int *)kp->arg) == MEMMAP_ON_MEMORY_FORCE) - return sprintf(buffer, "force\n"); - return param_get_bool(buffer, kp); + int mode = *((int *)kp->arg); + + if (mode == MEMMAP_ON_MEMORY_FORCE) + return sprintf(buffer, "force\n"); + return sprintf(buffer, "%c\n", mode ? 'Y' : 'N'); } static const struct kernel_param_ops memmap_mode_ops = { -- 2.40.1