From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 641DAC3DA6E for ; Wed, 10 Jan 2024 11:14:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC9E28D0002; Wed, 10 Jan 2024 06:14:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D53298D0001; Wed, 10 Jan 2024 06:14:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCCF58D0002; Wed, 10 Jan 2024 06:14:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A6C0B8D0001 for ; Wed, 10 Jan 2024 06:14:37 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 70E714041C for ; Wed, 10 Jan 2024 11:14:37 +0000 (UTC) X-FDA: 81663143394.24.3F1A6AB Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf29.hostedemail.com (Postfix) with ESMTP id 2B428120009 for ; Wed, 10 Jan 2024 11:14:33 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=DRISGyRR; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf29.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704885274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fwWP59DQZ/MSSlZK6nSA8WJmcHMonAP5bkUAu0nzMfE=; b=5R2E4qO7DhCZ8mzzxKIVd2JwHwq8k4IOlrwyuaeXAfOUk1Ly5smqADaFdGgNQGeDkQ/2BM P+3vIY/CTeFSP4jAsaKlvkqlMGZPawxYwI3R2tVPrzES3ESvPxJ3Xuex4VwLK/d/IxBfaD BuqWlOvU+3oblmwcz0JE9PxfiC9Jaco= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=DRISGyRR; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf29.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704885274; a=rsa-sha256; cv=none; b=8cCyo93JoIsn1xvuAO0xP+uJIIAgXlKdSB8zuo4O/iNceeDrJc9nMeSpWSS+vkqZnbBQx2 X2+uUUAPifIgut/lDJp5T8jyg2j621HLDGQaFjp7nc1aTmKLVFZewkc/W9u09T+mXPabWS tdbUPlpcdqHfADsRPqtSuCQKvLP6d8I= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 2B03040E01A9; Wed, 10 Jan 2024 11:14:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rk1GXipRnNvY; Wed, 10 Jan 2024 11:14:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1704885267; bh=fwWP59DQZ/MSSlZK6nSA8WJmcHMonAP5bkUAu0nzMfE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DRISGyRRH2Yb8ljr7qzKxmjDv5PDR//i1JNCPji2bZmoSqvXC2CEFgz/un4zlwdOd 1gE3QpuxPCOS/AO49UojJngUhe+gslvuDort5mT6YKdB6PxdpW6SSQ6zI36SoQuZR2 j+RNLNTXzjvJQgrviDjXNmGcHbG5Mhmfs3WnhbYXRMEeLIMF9EE/Sfiam/v3lfpkqD jmyhL1yhBFmtW21wCivpy1KA++k78OC13Jex3T8KKx2xdYeruw7kBahsHOSGi83Nc6 zsmsThRTTmzDRmCRXhyv4Wh7snbFm9Jn0fzha+wd4J2CxbS65LeqhPk/ZyYjL29/bo uzu+pKOPJQzyhB3gyH2U0vw/1s2cnfvdj8f4glLTntMjkAbIhBlBYRxUu+5LM16j5D U55MFzVMl22H06LDmtwxnqgrBxOzam7Rf4F2Fu/NM/qSWgrU3fe+/dUsfjXHbxCZ5G e7qT409qJNtDLgXCJ76zb6Vl1icGQQwZPxoS/Wdei8VQcHsSvz5xp6cU2JEctfs62k 7S7u9Tu+1rKxVl8sIi+n7DFgdXO+dkjJJ2aOKwBMXd4jKb0z/ex7gzelEMo/Qew5t7 pM9QC4FIj9hngIZR138Qa4DFSWnFwdYzXo60YT4dvPw5Je2/cOL9wzPkTcg6JofhE0 8CJKjCNIb4GEyJfUyPXLgMxs= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 67EAF40E01F9; Wed, 10 Jan 2024 11:13:49 +0000 (UTC) Date: Wed, 10 Jan 2024 12:13:44 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v1 07/26] x86/fault: Add helper for dumping RMP entries Message-ID: <20240110111344.GBZZ576DpwHHs997Zl@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-8-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231230161954.569267-8-michael.roth@amd.com> X-Rspamd-Queue-Id: 2B428120009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3donjz5r13sftcnkkudmqwk9iahc5e6t X-HE-Tag: 1704885273-957956 X-HE-Meta: U2FsdGVkX1/PhMqLFHKUrLC6eeTpq0lmkakg/2dDwmm73O1lIGivcblpfC1vT0q3YL6W5SSp/xtXNgHY+fGTvG0skrMHTBajVrbQ4fu/oCfGYmOrWl1hoOY4ObgKeDD4Q817qdOZ1u2xwCAevE965wbjE4/+QFhr+Ak+MT7Z14BN5g5ZDgBuV/9nqDPOlxtlJOD1HrV1QttzQoht0nydNAjstdC0LMRTA5h4REAPeUyM8ANAxkZvR9ZUKFDBApuMsiQB3dWsa9dTIb85Y6U/rCJE7e0TPijvnFpH3XnSP6BxS2GXzzb6eaCkRGriwHdl7007DbFt2r9C7idZspylt6cy+f48HAOLJT2Re8v5F8dqedmWu1lwLbHav4If/GYduxqnAVe6vThPziFtAo/EqPyJcNb7v56Ugl0cBr0sfSYk+4BFDgPbEKFnu+cfdNhM9RFp3fwxuKH3L4ciqMD6o0V/ClvXo1+IUwHvhHmLMohk1mo2fZcrQ97IVC36MTM7/cf8v4Rvgln8r4u6MV84bWDTDsdGX3+Qw6N/jhFY0pj43ZGT+fKNBU1tiVI3art6keEwa4vSSQRPLGDW3R1rBbHS0phFpnd56ysjTTfKkF6aK60WGhNQ16Zu8cl3o9suE4UiRManmK62mL0MxYkNABlOGQ9bt1d/mjy/7j1joHOEDH756aCLX+LI4GB5Uy438M5lywSw04a1UPd8zUSiGMgN02BNcqzmIDiEtpDYGYFODHIxbQHKpc1bShUmJNc7aox8iQLgFgAbZPQwqscmfOa8poVLYngC0q+FCslfZVhDyLrHSjlqCettydble4Tmr5P4AI+ErPCDWv2zMeypWcXQNoTOSv8LAgb4369RCcYSGpLXi+Mp5ayt5iO0jVNXDoEaVxbRzcDltdW5oZ6j7+WpelXVHycrkAJkFY5WL/ldQLbjpYxKltCmx0ZOXqC4Dgp1qSOTm/EphcJd722 i1nhuoNP irR2n0NMNJ6DMVS2GGiH1CkLg6LM+b38GXLwN+/j04TF+CEMrWJVTSpo9Fms9ldCbEcW+9hUFaeFS+SwoORekQaTaNOj6vguAw/ia5tgxDAkMC0wNmcFyxZb2TPM+vrg0U4KBidB3jv/ahn7s+aerqCFQwSZzUztQnoiySMbi22C1IX2+AgXtsFd1+C+8kFNnbBud5zzarpiQu0E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:19:35AM -0600, Michael Roth wrote: > + while (pfn_current < pfn_end) { > + e = __snp_lookup_rmpentry(pfn_current, &level); > + if (IS_ERR(e)) { > + pfn_current++; > + continue; > + } > + > + e_data = (u64 *)e; > + if (e_data[0] || e_data[1]) { > + pr_info("No assigned RMP entry for PFN 0x%llx, but the 2MB region contains populated RMP entries, e.g.: PFN 0x%llx: [high=0x%016llx low=0x%016llx]\n", > + pfn, pfn_current, e_data[1], e_data[0]); > + return; > + } > + pfn_current++; > + } > + > + pr_info("No populated RMP entries in the 2MB region containing PFN 0x%llx\n", > + pfn); > +} Ok, I went and reworked this, see below. Yes, I think it is important - at least in the beginning - to dump the whole 2M PFN region for debugging purposes. If that output starts becoming too unwieldy and overflowing terminals or log files, we'd shorten it or put it behind a debug option or so. Thx. --- diff --git a/arch/x86/virt/svm/sev.c b/arch/x86/virt/svm/sev.c index a8cf33b7da71..259a1dd655a7 100644 --- a/arch/x86/virt/svm/sev.c +++ b/arch/x86/virt/svm/sev.c @@ -35,16 +35,21 @@ * Family 19h Model 01h, Rev B1 processor. */ struct rmpentry { - u64 assigned : 1, - pagesize : 1, - immutable : 1, - rsvd1 : 9, - gpa : 39, - asid : 10, - vmsa : 1, - validated : 1, - rsvd2 : 1; - u64 rsvd3; + union { + struct { + u64 assigned : 1, + pagesize : 1, + immutable : 1, + rsvd1 : 9, + gpa : 39, + asid : 10, + vmsa : 1, + validated : 1, + rsvd2 : 1; + }; + u64 lo; + }; + u64 hi; } __packed; /* @@ -272,22 +277,20 @@ EXPORT_SYMBOL_GPL(snp_lookup_rmpentry); */ static void dump_rmpentry(u64 pfn) { - u64 pfn_current, pfn_end; + u64 pfn_i, pfn_end; struct rmpentry *e; - u64 *e_data; int level; e = __snp_lookup_rmpentry(pfn, &level); if (IS_ERR(e)) { - pr_info("Failed to read RMP entry for PFN 0x%llx, error %ld\n", - pfn, PTR_ERR(e)); + pr_err("Error %ld reading RMP entry for PFN 0x%llx\n", + PTR_ERR(e), pfn); return; } - e_data = (u64 *)e; if (e->assigned) { - pr_info("RMP entry for PFN 0x%llx: [high=0x%016llx low=0x%016llx]\n", - pfn, e_data[1], e_data[0]); + pr_info("PFN 0x%llx, RMP entry: [0x%016llx - 0x%016llx]\n", + pfn, e->lo, e->hi); return; } @@ -299,27 +302,28 @@ static void dump_rmpentry(u64 pfn) * certain situations, such as when the PFN is being accessed via a 2MB * mapping in the host page table. */ - pfn_current = ALIGN(pfn, PTRS_PER_PMD); - pfn_end = pfn_current + PTRS_PER_PMD; + pfn_i = ALIGN(pfn, PTRS_PER_PMD); + pfn_end = pfn_i + PTRS_PER_PMD; - while (pfn_current < pfn_end) { - e = __snp_lookup_rmpentry(pfn_current, &level); + pr_info("PFN 0x%llx unassigned, dumping the whole 2M PFN region: [0x%llx - 0x%llx]\n", + pfn, pfn_i, pfn_end); + + while (pfn_i < pfn_end) { + e = __snp_lookup_rmpentry(pfn_i, &level); if (IS_ERR(e)) { - pfn_current++; + pr_err("Error %ld reading RMP entry for PFN 0x%llx\n", + PTR_ERR(e), pfn_i); + pfn_i++; continue; } - e_data = (u64 *)e; - if (e_data[0] || e_data[1]) { - pr_info("No assigned RMP entry for PFN 0x%llx, but the 2MB region contains populated RMP entries, e.g.: PFN 0x%llx: [high=0x%016llx low=0x%016llx]\n", - pfn, pfn_current, e_data[1], e_data[0]); - return; - } - pfn_current++; - } + if (e->lo || e->hi) + pr_info("PFN: 0x%llx, [0x%016llx - 0x%016llx]\n", pfn_i, e->lo, e->hi); + else + pr_info("PFN: 0x%llx ...\n", pfn_i); - pr_info("No populated RMP entries in the 2MB region containing PFN 0x%llx\n", - pfn); + pfn_i++; + } } void snp_dump_hva_rmpentry(unsigned long hva) @@ -339,4 +343,3 @@ void snp_dump_hva_rmpentry(unsigned long hva) dump_rmpentry(pte_pfn(*pte)); } -EXPORT_SYMBOL_GPL(snp_dump_hva_rmpentry); -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette