From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06DCFC3DA6E for ; Wed, 10 Jan 2024 10:00:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68D006B0071; Wed, 10 Jan 2024 05:00:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63D736B007E; Wed, 10 Jan 2024 05:00:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DED66B0081; Wed, 10 Jan 2024 05:00:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3BB206B007E for ; Wed, 10 Jan 2024 05:00:07 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 04FA51C1207 for ; Wed, 10 Jan 2024 10:00:06 +0000 (UTC) X-FDA: 81662955654.14.434E355 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf26.hostedemail.com (Postfix) with ESMTP id A99D8140025 for ; Wed, 10 Jan 2024 10:00:03 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=MZUF+eVm; spf=pass (imf26.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704880804; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KJvIW3wGLgeykBglh9gfqqbtZfBEiY8fY9XU3XU6k20=; b=vkvGKzPX7KYCvSjd7XnwyeXS1sVTsFw06Rk6ruxb0ye61r325uNMIftnH9fo2N9UDDIXyV LL4RNw9B00YLD4u81u41iBSCXu6G2+fb6ijR9AqB/MBOwSJ9tUv66MKpoVkihi+EtOllDV 1En6BZ6R0B5rr+tA0Dy1Mw6+03+T1y4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704880804; a=rsa-sha256; cv=none; b=p82Eo1NeebD2D98lkqYs4d3SowG/BgllQ+KiL5IpVFQVbwWBVnMAgdc4J3Ydv0OVqExRM9 vmgCUNDqwCAZ61UmJnX5Xj3elXcnxBqWsnesz3Uir4+NSWa9IFFGT2TBetUb5HFDcgDxwd 1qQ1Y/+2vrfesWPASMw/QIg5aLrYDLs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=MZUF+eVm; spf=pass (imf26.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id AC5AA40E01B2; Wed, 10 Jan 2024 09:59:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id t_Tn0inSc1pY; Wed, 10 Jan 2024 09:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1704880797; bh=KJvIW3wGLgeykBglh9gfqqbtZfBEiY8fY9XU3XU6k20=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MZUF+eVmMir+M1csoIULZxfauukcd7CIuBhSBhwBfhowq36E2RXi4e9gJ75fzZH9b Wg6xn7brRPR4AwnRuCsq63ewIR/Xd7XFj67bgKbdKeb989Hgb9jGSZeUDdRLdfG7kB WfsISTeUpUhK+LnBQkmPsNRbT0sOMv8Q8OQfrD6QLCHN/DQZpoTReSw82F5WpR//qZ BnysNvbWGF31/Flzzv+uQLZQE9GP/i48XSZWOFnCIeLTv0UDkMM8XwpEpUSjbtQ+in ytNul1/xz+BxbQ+322LEQcEVeh5I7sKfUzvQ/3PHa/BiTQX2YsmDlKSn3r3FJ2HEVo tAfW05x8P5pbsC5YfiyRWtBfpkQFgr8M1DaPYLouuX8BfM/HMK15n6sIPb++WoPywo yf2277q5vXXIdpe+FL1J6T2SCJH/lQEIdnLhwgQ4zFJxtufCyWXcVgfMax9BHQYREq ptClxSF7ifxh6Z2ojSIgdLXQx1zVF8cnZaJw6qS1Uokypca32F5hO6k6w/j62w1xNH Hv9ZDY3ZSUdUrwC+hrnXWhglinSkchD9uqSyz/Pu05OogRBjymaUWH2mLgixn8o8X5 a29JrS9ZsD6e1pt0bQjQlLXa4MC3q7a7wr2jbO3L2uGQ2u7+Ec5IaMh9WP0uztwh3O IfOfk0ue5sI4yXGKrvIRn+f4= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 22F3940E0196; Wed, 10 Jan 2024 09:59:19 +0000 (UTC) Date: Wed, 10 Jan 2024 10:59:12 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v1 07/26] x86/fault: Add helper for dumping RMP entries Message-ID: <20240110095912.GAZZ5qcFXYgvPrCdRI@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-8-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231230161954.569267-8-michael.roth@amd.com> X-Rspamd-Queue-Id: A99D8140025 X-Rspam-User: X-Stat-Signature: 4gjf98jouiyp8971z4me7nuzeb31oock X-Rspamd-Server: rspam03 X-HE-Tag: 1704880803-395787 X-HE-Meta: U2FsdGVkX19MJ4sf5jdPRlHe3qvwx511yy7LjU3pxEwx697yYUHN4S9nGehR0rto30PW8T8sZKKsdYtbVrGEWbDru2xhU02s4Vwj0qgvmfn9c+XDctEA7i1YMNPr5nPAIDSg2f84OucN2k/HuNB7ZC560+1ZxFrbg4IJm1k6O0efpQ7rgXzqv5sgQAwGzbgWTrxBpwgNVIxCMTCSi6iV5Ej+bIGq3vBqmchCRbMtKBfQRAbXC/ZCmQbsf/CyXN+g9vTt9lM1h9XkhHJOHmTU5/30bAfmiGhP3EChWenMgUiKj+mx6pgNplybG2hVcDALepbwuFp5p8BeFIjPhpTsRdDfL+oAaa8+ikNpgnNxCj0eOTsxdzbgALFZivzZhnQwKEKE4+SwSXQ5jDL+D5ZF+YCbUof6uKqTRrp74cw9DY5gyD5/X6DQxfXmnzEwOAcIbbkzTL4sXxUzwJXJQKIQ6GhiKHkYv3tavxZVBjcNVBzCFpSssr6Zt/pKdGX6Sgo4IHh50uu16+FaJ/CB0bffwd65Wi7HqsRxQJ/jC+fIqKQaAssIfdAWSuXjEcFONrL+uqQQMV0+1F/6gS3K2NB6X4VishZwsLhvrHZ9A1kmveWuCXTwPTkR4XqNzU31gMCJojCljjr1eQ7txVvrS6eRBEl4IHRQ0Ptfe1jhwCaBJJj95Q+w7UMmdOP9AmBxNgdrvcGRjIxWa9RTLnOKQ93vtP+AkLy0n2mIM03jYA57hA0hnS6wwfxfnk3fL+9SeL0ghVqW1DfFdZcCUSjKMZgRo+onXV8sUCs2QJaPnR8/t4HKisITg121kbkTqpCw42o0U4fsK/Xktrxe3crBpeVQTeFvXson3v/iQjo8M2C0OWs0jal9a0nVivthoSx4JGVzuiMuS908dCYxoJTNMScD7xx/HcGULFQuM7M7JxutLTkHjXUSwaoA/Vytlp1/mwtBYckWjNouPsYvOnKDFlN mND7Zw6n 5OUX5vijMIYLSW7u1hYmcrPfZoTc7ruCCvgegjLQ08n4e7VirG0bgzfMLCNIDkQ4QU6EEkN725fIyi5QwnUbX3YOMs3rQMbF7+Q+HK/maJJLopY40leoc/F+mHaWbdvAExISoHUB6skY4NOWpVm8nkTkboLgJJ0lQkgHnbXVrWiiCGptZLTjMkXM2b0XL7QWM6Kpq8s9Gers5T/k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:19:35AM -0600, Michael Roth wrote: > +void snp_dump_hva_rmpentry(unsigned long hva) > +{ > + unsigned int level; > + pgd_t *pgd; > + pte_t *pte; > + > + pgd = __va(read_cr3_pa()); > + pgd += pgd_index(hva); > + pte = lookup_address_in_pgd(pgd, hva, &level); > + > + if (!pte) { > + pr_info("Can't dump RMP entry for HVA %lx: no PTE/PFN found\n", hva); > + return; > + } > + > + dump_rmpentry(pte_pfn(*pte)); > +} > +EXPORT_SYMBOL_GPL(snp_dump_hva_rmpentry); show_fault_oops() - the only caller of this - is builtin code and thus doesn't need symbol exports. Symbol exports are only for module code. --- diff --git a/arch/x86/virt/svm/sev.c b/arch/x86/virt/svm/sev.c index a8cf33b7da71..31154f087fb0 100644 --- a/arch/x86/virt/svm/sev.c +++ b/arch/x86/virt/svm/sev.c @@ -339,4 +339,3 @@ void snp_dump_hva_rmpentry(unsigned long hva) dump_rmpentry(pte_pfn(*pte)); } -EXPORT_SYMBOL_GPL(snp_dump_hva_rmpentry); -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette