* Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer
2024-01-09 19:02 ` Johannes Weiner
@ 2024-01-09 19:32 ` Nhat Pham
2024-01-10 15:51 ` Dan Streetman
` (3 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Nhat Pham @ 2024-01-09 19:32 UTC (permalink / raw)
To: Johannes Weiner
Cc: Yosry Ahmed, Andrew Morton, Dan Streetman, Seth Jennings,
Vitaly Wool, linux-mm
On Tue, Jan 9, 2024 at 11:02 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> On Tue, Jan 09, 2024 at 05:43:01PM +0000, Yosry Ahmed wrote:
> > I have been actively contributing to zswap and reviewing zswap patches
> > for a while, and I am already getting CC'd on most of them. Add myself
> > as a reviewer. While we are at it, add missing zswap files to the entry
> > in MAINTAINERS.
> >
> > Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
> because I agree with what you're saying. However, I think that
> maintainers entry could use some more help. You, me and Nhat have been
> doing most of the recent development and reviewing of changes in that
> space. Those patches have been largely met with radio silence by the
> existing maintainers, which makes me think the folks currently listed
> have moved on to other projects and/or aren't able to spend as many
> cycles on zswap anymore. Maybe it's time to update the list?
Agree. We've been working on zswap + cc-ed for code review for awhile
now. Might as well make it official :)
>
> get_maintainers.pl says this:
>
> [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
> Johannes Weiner <hannes@cmpxchg.org> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
> Yosry Ahmed <yosryahmed@google.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
> Nhat Pham <nphamcs@gmail.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)
>
> How about the below? Dan, Seth, Vitaly, what do you think?
>
> Thanks
>
> ---
>
> From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
> From: Johannes Weiner <hannes@cmpxchg.org>
> Date: Tue, 9 Jan 2024 13:50:53 -0500
> Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
> and reviewers
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Nhat Pham <nphamcs@gmail.com>
> ---
> MAINTAINERS | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f71c525405e0..b65538e85e9c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -24122,11 +24122,13 @@ N: zstd
> K: zstd
>
> ZSWAP COMPRESSED SWAP CACHING
> -M: Seth Jennings <sjenning@redhat.com>
> -M: Dan Streetman <ddstreet@ieee.org>
> -M: Vitaly Wool <vitaly.wool@konsulko.com>
> +M: Johannes Weiner <hannes@cmpxchg.org>
> +M: Yosry Ahmed <yosryahmed@google.com>
> +M: Nhat Pham <nphamcs@gmail.com>
> L: linux-mm@kvack.org
> S: Maintained
> +F: Documentation/admin-guide/mm/zswap.rst
> +F: include/linux/zswap.h
> F: mm/zswap.c
>
> THE REST
> --
> 2.43.0
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer
2024-01-09 19:02 ` Johannes Weiner
2024-01-09 19:32 ` Nhat Pham
@ 2024-01-10 15:51 ` Dan Streetman
2024-01-10 15:53 ` Dan Streetman
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Dan Streetman @ 2024-01-10 15:51 UTC (permalink / raw)
To: Johannes Weiner
Cc: Yosry Ahmed, Andrew Morton, Seth Jennings, Vitaly Wool, linux-mm,
Nhat Pham
On Tue, Jan 9, 2024 at 2:02 PM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> On Tue, Jan 09, 2024 at 05:43:01PM +0000, Yosry Ahmed wrote:
> > I have been actively contributing to zswap and reviewing zswap patches
> > for a while, and I am already getting CC'd on most of them. Add myself
> > as a reviewer. While we are at it, add missing zswap files to the entry
> > in MAINTAINERS.
> >
> > Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
> because I agree with what you're saying. However, I think that
> maintainers entry could use some more help. You, me and Nhat have been
> doing most of the recent development and reviewing of changes in that
> space. Those patches have been largely met with radio silence by the
> existing maintainers, which makes me think the folks currently listed
> have moved on to other projects and/or aren't able to spend as many
> cycles on zswap anymore. Maybe it's time to update the list?
>
> get_maintainers.pl says this:
>
> [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
> Johannes Weiner <hannes@cmpxchg.org> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
> Yosry Ahmed <yosryahmed@google.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
> Nhat Pham <nphamcs@gmail.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)
>
> How about the below? Dan, Seth, Vitaly, what do you think?
Speaking only for myself of course, ACK to the below; obviously I
haven't been doing any zswap maintaining for a long while. Thanks to
you all for continuing to develop and maintain it!
>
> Thanks
>
> ---
>
> From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
> From: Johannes Weiner <hannes@cmpxchg.org>
> Date: Tue, 9 Jan 2024 13:50:53 -0500
> Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
> and reviewers
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> ---
> MAINTAINERS | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f71c525405e0..b65538e85e9c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -24122,11 +24122,13 @@ N: zstd
> K: zstd
>
> ZSWAP COMPRESSED SWAP CACHING
> -M: Seth Jennings <sjenning@redhat.com>
> -M: Dan Streetman <ddstreet@ieee.org>
> -M: Vitaly Wool <vitaly.wool@konsulko.com>
> +M: Johannes Weiner <hannes@cmpxchg.org>
> +M: Yosry Ahmed <yosryahmed@google.com>
> +M: Nhat Pham <nphamcs@gmail.com>
> L: linux-mm@kvack.org
> S: Maintained
> +F: Documentation/admin-guide/mm/zswap.rst
> +F: include/linux/zswap.h
> F: mm/zswap.c
>
> THE REST
> --
> 2.43.0
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer
2024-01-09 19:02 ` Johannes Weiner
2024-01-09 19:32 ` Nhat Pham
2024-01-10 15:51 ` Dan Streetman
@ 2024-01-10 15:53 ` Dan Streetman
2024-01-10 16:14 ` Seth Jennings
2024-01-14 18:53 ` Yosry Ahmed
4 siblings, 0 replies; 12+ messages in thread
From: Dan Streetman @ 2024-01-10 15:53 UTC (permalink / raw)
To: Johannes Weiner
Cc: Yosry Ahmed, Andrew Morton, Seth Jennings, Vitaly Wool, linux-mm,
Nhat Pham
On Tue, Jan 9, 2024 at 2:02 PM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> On Tue, Jan 09, 2024 at 05:43:01PM +0000, Yosry Ahmed wrote:
> > I have been actively contributing to zswap and reviewing zswap patches
> > for a while, and I am already getting CC'd on most of them. Add myself
> > as a reviewer. While we are at it, add missing zswap files to the entry
> > in MAINTAINERS.
> >
> > Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
> because I agree with what you're saying. However, I think that
> maintainers entry could use some more help. You, me and Nhat have been
> doing most of the recent development and reviewing of changes in that
> space. Those patches have been largely met with radio silence by the
> existing maintainers, which makes me think the folks currently listed
> have moved on to other projects and/or aren't able to spend as many
> cycles on zswap anymore. Maybe it's time to update the list?
>
> get_maintainers.pl says this:
>
> [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
> Johannes Weiner <hannes@cmpxchg.org> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
> Yosry Ahmed <yosryahmed@google.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
> Nhat Pham <nphamcs@gmail.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)
>
> How about the below? Dan, Seth, Vitaly, what do you think?
>
> Thanks
>
> ---
>
> From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
> From: Johannes Weiner <hannes@cmpxchg.org>
> Date: Tue, 9 Jan 2024 13:50:53 -0500
> Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
> and reviewers
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> ---
> MAINTAINERS | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f71c525405e0..b65538e85e9c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -24122,11 +24122,13 @@ N: zstd
> K: zstd
>
> ZSWAP COMPRESSED SWAP CACHING
> -M: Seth Jennings <sjenning@redhat.com>
> -M: Dan Streetman <ddstreet@ieee.org>
> -M: Vitaly Wool <vitaly.wool@konsulko.com>
> +M: Johannes Weiner <hannes@cmpxchg.org>
> +M: Yosry Ahmed <yosryahmed@google.com>
> +M: Nhat Pham <nphamcs@gmail.com>
> L: linux-mm@kvack.org
> S: Maintained
> +F: Documentation/admin-guide/mm/zswap.rst
> +F: include/linux/zswap.h
> F: mm/zswap.c
Sorry I should have used the proper ack:
Acked-by: Dan Streetman <ddstreet@ieee.org>
>
> THE REST
> --
> 2.43.0
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer
2024-01-09 19:02 ` Johannes Weiner
` (2 preceding siblings ...)
2024-01-10 15:53 ` Dan Streetman
@ 2024-01-10 16:14 ` Seth Jennings
2024-01-14 18:53 ` Yosry Ahmed
4 siblings, 0 replies; 12+ messages in thread
From: Seth Jennings @ 2024-01-10 16:14 UTC (permalink / raw)
To: Johannes Weiner
Cc: Yosry Ahmed, Andrew Morton, Dan Streetman, Vitaly Wool, linux-mm,
Nhat Pham
> How about the below? Dan, Seth, Vitaly, what do you think?
Fine with me as well. Happy to see others continuing to develop on this!
On Tue, Jan 9, 2024 at 1:02 PM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> On Tue, Jan 09, 2024 at 05:43:01PM +0000, Yosry Ahmed wrote:
> > I have been actively contributing to zswap and reviewing zswap patches
> > for a while, and I am already getting CC'd on most of them. Add myself
> > as a reviewer. While we are at it, add missing zswap files to the entry
> > in MAINTAINERS.
> >
> > Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
> because I agree with what you're saying. However, I think that
> maintainers entry could use some more help. You, me and Nhat have been
> doing most of the recent development and reviewing of changes in that
> space. Those patches have been largely met with radio silence by the
> existing maintainers, which makes me think the folks currently listed
> have moved on to other projects and/or aren't able to spend as many
> cycles on zswap anymore. Maybe it's time to update the list?
>
> get_maintainers.pl says this:
>
> [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
> Johannes Weiner <hannes@cmpxchg.org> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
> Yosry Ahmed <yosryahmed@google.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
> Nhat Pham <nphamcs@gmail.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)
>
> How about the below? Dan, Seth, Vitaly, what do you think?
>
> Thanks
>
> ---
>
> From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
> From: Johannes Weiner <hannes@cmpxchg.org>
> Date: Tue, 9 Jan 2024 13:50:53 -0500
> Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
> and reviewers
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> ---
> MAINTAINERS | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f71c525405e0..b65538e85e9c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -24122,11 +24122,13 @@ N: zstd
> K: zstd
>
> ZSWAP COMPRESSED SWAP CACHING
> -M: Seth Jennings <sjenning@redhat.com>
> -M: Dan Streetman <ddstreet@ieee.org>
> -M: Vitaly Wool <vitaly.wool@konsulko.com>
> +M: Johannes Weiner <hannes@cmpxchg.org>
> +M: Yosry Ahmed <yosryahmed@google.com>
> +M: Nhat Pham <nphamcs@gmail.com>
> L: linux-mm@kvack.org
> S: Maintained
> +F: Documentation/admin-guide/mm/zswap.rst
> +F: include/linux/zswap.h
> F: mm/zswap.c
>
> THE REST
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer
2024-01-09 19:02 ` Johannes Weiner
` (3 preceding siblings ...)
2024-01-10 16:14 ` Seth Jennings
@ 2024-01-14 18:53 ` Yosry Ahmed
2024-01-14 22:47 ` Nhat Pham
2024-01-16 13:46 ` Vitaly Wool
4 siblings, 2 replies; 12+ messages in thread
From: Yosry Ahmed @ 2024-01-14 18:53 UTC (permalink / raw)
To: Johannes Weiner
Cc: Andrew Morton, Dan Streetman, Seth Jennings, Vitaly Wool,
linux-mm, Nhat Pham
On Tue, Jan 9, 2024 at 11:02 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> On Tue, Jan 09, 2024 at 05:43:01PM +0000, Yosry Ahmed wrote:
> > I have been actively contributing to zswap and reviewing zswap patches
> > for a while, and I am already getting CC'd on most of them. Add myself
> > as a reviewer. While we are at it, add missing zswap files to the entry
> > in MAINTAINERS.
> >
> > Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
> because I agree with what you're saying. However, I think that
> maintainers entry could use some more help. You, me and Nhat have been
> doing most of the recent development and reviewing of changes in that
> space. Those patches have been largely met with radio silence by the
> existing maintainers, which makes me think the folks currently listed
> have moved on to other projects and/or aren't able to spend as many
> cycles on zswap anymore. Maybe it's time to update the list?
>
> get_maintainers.pl says this:
>
> [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
> Johannes Weiner <hannes@cmpxchg.org> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
> Yosry Ahmed <yosryahmed@google.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
> Nhat Pham <nphamcs@gmail.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)
>
> How about the below? Dan, Seth, Vitaly, what do you think?
>
> Thanks
>
> ---
>
> From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
> From: Johannes Weiner <hannes@cmpxchg.org>
> Date: Tue, 9 Jan 2024 13:50:53 -0500
> Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
> and reviewers
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> ---
> MAINTAINERS | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f71c525405e0..b65538e85e9c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -24122,11 +24122,13 @@ N: zstd
> K: zstd
>
> ZSWAP COMPRESSED SWAP CACHING
> -M: Seth Jennings <sjenning@redhat.com>
> -M: Dan Streetman <ddstreet@ieee.org>
> -M: Vitaly Wool <vitaly.wool@konsulko.com>
> +M: Johannes Weiner <hannes@cmpxchg.org>
> +M: Yosry Ahmed <yosryahmed@google.com>
> +M: Nhat Pham <nphamcs@gmail.com>
> L: linux-mm@kvack.org
> S: Maintained
> +F: Documentation/admin-guide/mm/zswap.rst
> +F: include/linux/zswap.h
> F: mm/zswap.c
Probably a bit too late, but should we also merge the zpool entry with
the zswap entry? I can send a follow up if we are in agreement.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer
2024-01-14 18:53 ` Yosry Ahmed
@ 2024-01-14 22:47 ` Nhat Pham
2024-01-16 13:14 ` Dan Streetman
2024-01-16 13:46 ` Vitaly Wool
1 sibling, 1 reply; 12+ messages in thread
From: Nhat Pham @ 2024-01-14 22:47 UTC (permalink / raw)
To: Yosry Ahmed
Cc: Johannes Weiner, Andrew Morton, Dan Streetman, Seth Jennings,
Vitaly Wool, linux-mm
On Sun, Jan 14, 2024 at 10:54 AM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> On Tue, Jan 9, 2024 at 11:02 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
> >
> > On Tue, Jan 09, 2024 at 05:43:01PM +0000, Yosry Ahmed wrote:
> > > I have been actively contributing to zswap and reviewing zswap patches
> > > for a while, and I am already getting CC'd on most of them. Add myself
> > > as a reviewer. While we are at it, add missing zswap files to the entry
> > > in MAINTAINERS.
> > >
> > > Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
> >
> > Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> >
> > because I agree with what you're saying. However, I think that
> > maintainers entry could use some more help. You, me and Nhat have been
> > doing most of the recent development and reviewing of changes in that
> > space. Those patches have been largely met with radio silence by the
> > existing maintainers, which makes me think the folks currently listed
> > have moved on to other projects and/or aren't able to spend as many
> > cycles on zswap anymore. Maybe it's time to update the list?
> >
> > get_maintainers.pl says this:
> >
> > [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
> > Johannes Weiner <hannes@cmpxchg.org> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
> > Yosry Ahmed <yosryahmed@google.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
> > Nhat Pham <nphamcs@gmail.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)
> >
> > How about the below? Dan, Seth, Vitaly, what do you think?
> >
> > Thanks
> >
> > ---
> >
> > From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
> > From: Johannes Weiner <hannes@cmpxchg.org>
> > Date: Tue, 9 Jan 2024 13:50:53 -0500
> > Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
> > and reviewers
> >
> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> > ---
> > MAINTAINERS | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index f71c525405e0..b65538e85e9c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -24122,11 +24122,13 @@ N: zstd
> > K: zstd
> >
> > ZSWAP COMPRESSED SWAP CACHING
> > -M: Seth Jennings <sjenning@redhat.com>
> > -M: Dan Streetman <ddstreet@ieee.org>
> > -M: Vitaly Wool <vitaly.wool@konsulko.com>
> > +M: Johannes Weiner <hannes@cmpxchg.org>
> > +M: Yosry Ahmed <yosryahmed@google.com>
> > +M: Nhat Pham <nphamcs@gmail.com>
> > L: linux-mm@kvack.org
> > S: Maintained
> > +F: Documentation/admin-guide/mm/zswap.rst
> > +F: include/linux/zswap.h
> > F: mm/zswap.c
>
> Probably a bit too late, but should we also merge the zpool entry with
> the zswap entry? I can send a follow up if we are in agreement.
Sure, if Dan doesn't mind.
Also, maybe we can eventually deprecate that interface too, once we
have retired zbud + z3fold and no new allocators are invented after a
while? Similar to how frontswap is killed that is.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer
2024-01-14 22:47 ` Nhat Pham
@ 2024-01-16 13:14 ` Dan Streetman
0 siblings, 0 replies; 12+ messages in thread
From: Dan Streetman @ 2024-01-16 13:14 UTC (permalink / raw)
To: Nhat Pham
Cc: Yosry Ahmed, Johannes Weiner, Andrew Morton, Seth Jennings,
Vitaly Wool, linux-mm
On Sun, Jan 14, 2024 at 5:48 PM Nhat Pham <nphamcs@gmail.com> wrote:
>
> On Sun, Jan 14, 2024 at 10:54 AM Yosry Ahmed <yosryahmed@google.com> wrote:
> >
> > On Tue, Jan 9, 2024 at 11:02 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
> > >
> > > On Tue, Jan 09, 2024 at 05:43:01PM +0000, Yosry Ahmed wrote:
> > > > I have been actively contributing to zswap and reviewing zswap patches
> > > > for a while, and I am already getting CC'd on most of them. Add myself
> > > > as a reviewer. While we are at it, add missing zswap files to the entry
> > > > in MAINTAINERS.
> > > >
> > > > Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
> > >
> > > Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> > >
> > > because I agree with what you're saying. However, I think that
> > > maintainers entry could use some more help. You, me and Nhat have been
> > > doing most of the recent development and reviewing of changes in that
> > > space. Those patches have been largely met with radio silence by the
> > > existing maintainers, which makes me think the folks currently listed
> > > have moved on to other projects and/or aren't able to spend as many
> > > cycles on zswap anymore. Maybe it's time to update the list?
> > >
> > > get_maintainers.pl says this:
> > >
> > > [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
> > > Johannes Weiner <hannes@cmpxchg.org> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
> > > Yosry Ahmed <yosryahmed@google.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
> > > Nhat Pham <nphamcs@gmail.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)
> > >
> > > How about the below? Dan, Seth, Vitaly, what do you think?
> > >
> > > Thanks
> > >
> > > ---
> > >
> > > From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
> > > From: Johannes Weiner <hannes@cmpxchg.org>
> > > Date: Tue, 9 Jan 2024 13:50:53 -0500
> > > Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
> > > and reviewers
> > >
> > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> > > ---
> > > MAINTAINERS | 8 +++++---
> > > 1 file changed, 5 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index f71c525405e0..b65538e85e9c 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -24122,11 +24122,13 @@ N: zstd
> > > K: zstd
> > >
> > > ZSWAP COMPRESSED SWAP CACHING
> > > -M: Seth Jennings <sjenning@redhat.com>
> > > -M: Dan Streetman <ddstreet@ieee.org>
> > > -M: Vitaly Wool <vitaly.wool@konsulko.com>
> > > +M: Johannes Weiner <hannes@cmpxchg.org>
> > > +M: Yosry Ahmed <yosryahmed@google.com>
> > > +M: Nhat Pham <nphamcs@gmail.com>
> > > L: linux-mm@kvack.org
> > > S: Maintained
> > > +F: Documentation/admin-guide/mm/zswap.rst
> > > +F: include/linux/zswap.h
> > > F: mm/zswap.c
> >
> > Probably a bit too late, but should we also merge the zpool entry with
> > the zswap entry? I can send a follow up if we are in agreement.
>
> Sure, if Dan doesn't mind.
Yep fine with me. Thanks!
>
> Also, maybe we can eventually deprecate that interface too, once we
> have retired zbud + z3fold and no new allocators are invented after a
> while? Similar to how frontswap is killed that is.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer
2024-01-14 18:53 ` Yosry Ahmed
2024-01-14 22:47 ` Nhat Pham
@ 2024-01-16 13:46 ` Vitaly Wool
2024-01-17 3:12 ` Yosry Ahmed
1 sibling, 1 reply; 12+ messages in thread
From: Vitaly Wool @ 2024-01-16 13:46 UTC (permalink / raw)
To: Yosry Ahmed
Cc: Johannes Weiner, Andrew Morton, Dan Streetman, Seth Jennings,
Linux-MM, Nhat Pham
Den sön 14 jan. 2024 19:54Yosry Ahmed <yosryahmed@google.com> skrev:
>
> On Tue, Jan 9, 2024 at 11:02 AM Johannes Weiner <hannes@cmpxchg.org> wrote:
> >
> > On Tue, Jan 09, 2024 at 05:43:01PM +0000, Yosry Ahmed wrote:
> > > I have been actively contributing to zswap and reviewing zswap patches
> > > for a while, and I am already getting CC'd on most of them. Add myself
> > > as a reviewer. While we are at it, add missing zswap files to the entry
> > > in MAINTAINERS.
> > >
> > > Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
> >
> > Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> >
> > because I agree with what you're saying. However, I think that
> > maintainers entry could use some more help. You, me and Nhat have been
> > doing most of the recent development and reviewing of changes in that
> > space. Those patches have been largely met with radio silence by the
> > existing maintainers, which makes me think the folks currently listed
> > have moved on to other projects and/or aren't able to spend as many
> > cycles on zswap anymore. Maybe it's time to update the list?
> >
> > get_maintainers.pl says this:
> >
> > [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswap.c
> > Johannes Weiner <hannes@cmpxchg.org> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:14/29=48%,authored:5/29=17%,added_lines:121/551=22%,removed_lines:192/440=44%)
> > Yosry Ahmed <yosryahmed@google.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:11/29=38%,authored:3/29=10%,added_lines:86/551=16%,removed_lines:44/440=10%)
> > Nhat Pham <nphamcs@gmail.com> (maintainer:ZSWAP COMPRESSED SWAP CACHING,commit_signer:9/29=31%)
> >
> > How about the below? Dan, Seth, Vitaly, what do you think?
> >
> > Thanks
> >
> > ---
> >
> > From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 2001
> > From: Johannes Weiner <hannes@cmpxchg.org>
> > Date: Tue, 9 Jan 2024 13:50:53 -0500
> > Subject: [PATCH] mm: zswap: switch maintainers to recently active developers
> > and reviewers
> >
> > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> > ---
> > MAINTAINERS | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index f71c525405e0..b65538e85e9c 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -24122,11 +24122,13 @@ N: zstd
> > K: zstd
> >
> > ZSWAP COMPRESSED SWAP CACHING
> > -M: Seth Jennings <sjenning@redhat.com>
> > -M: Dan Streetman <ddstreet@ieee.org>
> > -M: Vitaly Wool <vitaly.wool@konsulko.com>
> > +M: Johannes Weiner <hannes@cmpxchg.org>
> > +M: Yosry Ahmed <yosryahmed@google.com>
> > +M: Nhat Pham <nphamcs@gmail.com>
> > L: linux-mm@kvack.org
> > S: Maintained
> > +F: Documentation/admin-guide/mm/zswap.rst
> > +F: include/linux/zswap.h
> > F: mm/zswap.c
>
> Probably a bit too late, but should we also merge the zpool entry with
> the zswap entry? I can send a follow up if we are in agreement.
I am afraid we are not. That would be one more step in the wrong direction.
~Vitaly
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer
2024-01-16 13:46 ` Vitaly Wool
@ 2024-01-17 3:12 ` Yosry Ahmed
2024-01-17 9:53 ` Vitaly Wool
0 siblings, 1 reply; 12+ messages in thread
From: Yosry Ahmed @ 2024-01-17 3:12 UTC (permalink / raw)
To: Vitaly Wool
Cc: Johannes Weiner, Andrew Morton, Dan Streetman, Seth Jennings,
Linux-MM, Nhat Pham
> > Probably a bit too late, but should we also merge the zpool entry with
> > the zswap entry? I can send a follow up if we are in agreement.
>
>
> I am afraid we are not. That would be one more step in the wrong direction.
Do you mind elaborating the reason? Zpool is only to abstract the
zswap allocators, it makes sense that it is tightly coupled with
zswap, no?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer
2024-01-17 3:12 ` Yosry Ahmed
@ 2024-01-17 9:53 ` Vitaly Wool
0 siblings, 0 replies; 12+ messages in thread
From: Vitaly Wool @ 2024-01-17 9:53 UTC (permalink / raw)
To: Yosry Ahmed
Cc: Johannes Weiner, Andrew Morton, Dan Streetman, Seth Jennings,
Linux-MM, Nhat Pham
On Wed, Jan 17, 2024 at 4:13 AM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> > > Probably a bit too late, but should we also merge the zpool entry with
> > > the zswap entry? I can send a follow up if we are in agreement.
> >
> >
> > I am afraid we are not. That would be one more step in the wrong direction.
>
> Do you mind elaborating the reason? Zpool is only to abstract the
> zswap allocators, it makes sense that it is tightly coupled with
> zswap, no?
Hmm, I must admit I misread your sentence. Sorry about that.
Please disregard my previous comment, merging zpool with zswap sounds
good to me.
~Vitaly
^ permalink raw reply [flat|nested] 12+ messages in thread