From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C8ACC46CD2 for ; Tue, 9 Jan 2024 13:51:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98E9D6B0075; Tue, 9 Jan 2024 08:51:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 916AB6B007B; Tue, 9 Jan 2024 08:51:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 790B46B007D; Tue, 9 Jan 2024 08:51:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 62CFA6B0075 for ; Tue, 9 Jan 2024 08:51:06 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2CDAE1C0844 for ; Tue, 9 Jan 2024 13:51:06 +0000 (UTC) X-FDA: 81659908932.16.16C9C76 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf29.hostedemail.com (Postfix) with ESMTP id 5B7E1120009 for ; Tue, 9 Jan 2024 13:51:02 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=k+bvkKpm; spf=pass (imf29.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704808264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ymKWYi8Z65Trhul0I0GccChFLj4eXF904h1FUWP0hJQ=; b=Zft9wA2J6WYBIRSjw3hjbj9xN/taAtVP/s2O9eEWEVdqnzOGK2SNxsA0avTIxQz2Z3+k4/ slt10y3L8V+dpSk6HjFogen4odIsMsN6teWLAfEfgjcXuHB6pIiIYE2YYRNN5YdTwN51F9 Rx8WULnZEqxSoTqCjFEZO46r2149flg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=k+bvkKpm; spf=pass (imf29.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=hca@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704808264; a=rsa-sha256; cv=none; b=zoTUM7p9kuas5juSJrtZ1/galWPLHzKFTZft+PVJypl+O3jjJWSGLUc8R5LsffPAzrePHa PllKSO77kGwJP5T7FmxF6PxLxjpgicOTgNWZ7BODTExYfvo6LsRy3yENXmXSakMkv9RaUq TgHgO7ykJ2ON/8Zbe5CEoXb1IPLZOtY= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 409Dgf03005564; Tue, 9 Jan 2024 13:50:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=ymKWYi8Z65Trhul0I0GccChFLj4eXF904h1FUWP0hJQ=; b=k+bvkKpmf3iiMtK06hUlfeog0dywwVwG9vrrW3YdrQna6ysKZaPOUmcd4/JTXYJlV82v 9YPynhoyzxJSuLCzq5ClOkYYhwBPjvh1jZA2aYhBCrTtxEK9VYdHZKl3Vm8o93xqtQvx 8wFtGRLnuiZ8DAvvTOe8jhtrc8re455eBZ/Z+iqaNlByta0LWZQOnbuI18PiWYfHZU9r tWldBLm3rS4neEO8CmUdSxSIIi5rsleyjBFb5zUy0QdcmbKmsBuG8JkgapaZjqGuZpjH 2A4erMBMNabpWj6HJbgXFgKyFZ2I51Hsry1Rkc7ohOT43/l5OIyOoHy+ZW7ATg8RXhb8 aA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vh78vg69w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jan 2024 13:50:12 +0000 Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 409Dh5i3006163; Tue, 9 Jan 2024 13:50:11 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vh78vg697-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jan 2024 13:50:11 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 409D1SL9028052; Tue, 9 Jan 2024 13:50:10 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3vgwfsjub2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jan 2024 13:50:10 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 409Do73W23986828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Jan 2024 13:50:07 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5BB6420043; Tue, 9 Jan 2024 13:50:07 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B27B620040; Tue, 9 Jan 2024 13:50:06 +0000 (GMT) Received: from osiris (unknown [9.152.212.148]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 9 Jan 2024 13:50:06 +0000 (GMT) Date: Tue, 9 Jan 2024 14:50:05 +0100 From: Heiko Carstens To: Christophe Leroy Cc: linux-hardening@vger.kernel.org, Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Nicholas Piggin , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, steven.price@arm.com, Phong Tran , mark.rutland@arm.com, Greg KH Subject: Re: [PATCH 4/4] ptdump: add check_wx_pages debugfs attribute Message-ID: <20240109135005.7302-A-hca@linux.ibm.com> References: <2e8806da45a4b00249d5c449130b5f9ce78b3403.1704800524.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2e8806da45a4b00249d5c449130b5f9ce78b3403.1704800524.git.christophe.leroy@csgroup.eu> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: GWEkJgHDQrp2b62jDGJkkX_iMwFv_Sr- X-Proofpoint-ORIG-GUID: MorbjN2VJcppxv7aT443XRfsyD1mKQHI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-09_06,2024-01-09_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=853 suspectscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 spamscore=0 mlxscore=0 bulkscore=0 clxscore=1011 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401090114 X-Rspamd-Queue-Id: 5B7E1120009 X-Rspam-User: X-Stat-Signature: wgp9g7ke8napqi1s41hpm9mcczcmdo86 X-Rspamd-Server: rspam01 X-HE-Tag: 1704808262-739981 X-HE-Meta: U2FsdGVkX19rUr3kwrnpN8ZA8LAS0ggf1d0ntCO9uy05uLtD1NjBQOSzqs+6AQ+xXekjdU8H4ocYVJnBDDiQPo0s7bA4cjvsa41tJcQMvshwrDgWt+7R4PRtOLNY6i8CC3BnPkhnsou2vbm2rD3euxJjU8sPCgGiQcXu33im+kHCxFrrQ4CaN2eT89DibWAvW5m27GI+LMcIV7FYeh7dpc7Skm71EJWFIKt5a43LAsHwW21ANhjHYGu2G0oUyTbp93AyHbKpBLePvCexkEUoiVnBM63108xTT8yhMcifdWVm4zMSTmSLd4tKLFkGFANqVuHilCMkTljQaG+wHvcXKOtCHwhtlM2OOjeguHrRPZZdV1XELcjHShpHh4JSDO1sbr4aD+jkAOjzXpKJ4SJCaWcIWjTC4zcTfW1tZGS+l6a9Hj9J7XgSEbPHBbMplRg8dqd96+h3jE7uOrSSLLLHk+UFysDnvCi2nVw+BMNgRpNTbvEdKmVHzyRO9DEuj1/7JlDOvNuuJAmdtpjiay+uhIqIpaUbPx3TPh1Vh82K9gdQm1g7j052qaLMG9NkxOptrYEqzLig1qJNgLPadH/t/Df+nOnKGuutaugR44O+2dDXynGAWc2ZdCrZvbdTN/tQXJpQGxzbuCKPup97vAzLfwI8cDVHSvMDTzeHY3h9YJ6P8OzR/gmeiLg2StOYGE2964d+1MsnECr5ApYivE9NV5btbA7/pcSFfaPdDkuJko5imP4BVlvhTzoqdn9Qy4zDL9yzoOkZqTVFFrjq/L3H0vj5j0A3q3LWvpSczCfBgzHbTuyR2vNmlz1Q+HQbatB9Z8J6HBcr/wh+youDBBi9HVpEi1/YPRHeL0e+rW6SPutnv3tzR/QWDPcbQmYaHF6k72vfLpksyy4qjwYd0BIvmm2vhNQ3FIklQ4V4Q0E8MRL9vXBMPliClFCoIKgnsd88hVKVMPPUjdV6mZX0atj 6jjEFrRp UeNy08XzR39DyV4RQDp49qHMzLw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 09, 2024 at 01:14:38PM +0100, Christophe Leroy wrote: > Add a writable attribute in debugfs to trigger a > W^X pages check at any time. > > To trigger the test, just echo any numeric value into > /sys/kernel/debug/check_wx_pages > > The result is provided into dmesg. > > Signed-off-by: Christophe Leroy > --- > mm/ptdump.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) ... > +static int check_wx_debugfs_set(void *data, u64 val) > +{ > + ptdump_check_wx(); > + > + return 0; > +} > + > +DEFINE_SIMPLE_ATTRIBUTE(check_wx_fops, NULL, check_wx_debugfs_set, "%llu\n"); > + > +static int ptdump_debugfs_init(void) > +{ > + debugfs_create_file("check_wx_pages", 0200, NULL, NULL, &check_wx_fops); > + > + return 0; > +} Wouldn't it be better to have (only?) a readable attribute which triggers this, and provides the result via this attribute? That would allow for automated tests without having to parse dmesg.