From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0F12C46CD2 for ; Tue, 9 Jan 2024 08:33:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B1E86B0075; Tue, 9 Jan 2024 03:33:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 013FB6B007B; Tue, 9 Jan 2024 03:33:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD00F6B007E; Tue, 9 Jan 2024 03:33:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C700C6B0075 for ; Tue, 9 Jan 2024 03:33:12 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 94657A07B2 for ; Tue, 9 Jan 2024 08:33:12 +0000 (UTC) X-FDA: 81659107824.29.6E6464C Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 8691A140014 for ; Tue, 9 Jan 2024 08:33:10 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hae9Vcp8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704789191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ceJhrDKfwTQDkSMBoGVp9fmH8KOXA4wCnrRuiRZloUM=; b=bIh98pCPJD4RXlhqrtJcqVBayz7usdPIZkUa15/mflYouNmZnUi2FeYChSwW3lkIm+XIgV H/84wZROwwDEJ3dq3yIei1bKdAI2sQQwLWA4dUVgDQ0IcqV7ZS9D8Yb024QhctQ71zrYKj 8r4ockbUTMwbSpaiNrDj4BAGwlDa9wM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=hae9Vcp8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of horms@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=horms@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704789191; a=rsa-sha256; cv=none; b=DKFcPIie5RB+Eh7TI3kT16bbG+6+Xq7SElXC3SzHVRntVCquehhWzNcxKWhQoMCMN8/0Df IHxcpxe9fo6xwonGKOtWU76ZUxoIY5XHqTUmX4xHejDk8F3LT4PlEKi22sCKui6L3medIf 7B5JQ7RD0o0oJzyZIz0d3DmnYp05FsQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B0013CE176E; Tue, 9 Jan 2024 08:33:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 359E9C433F1; Tue, 9 Jan 2024 08:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704789185; bh=A8Hyrx8gv2NivKMAgmiyJ4RK4toNpxNWKdpezhMjsB4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hae9Vcp8/kaaJWKrCD8n2rypMTJgDsf+fIUhRrlgD2zzHG1fE0pMkgVLy2Aay16i1 cyOHkhWI6T9AA0gmkJRtZt2jCOTuc/GnE/NFt35tRFGpCvFIalZbChShpHaOxn17RM sI5RHW0Ki3H0e99EmMwZ6tO0SgA6QAqR2LAPQFlkuKHdVPcV2i/aQ865CceI5/rxfK gR0HZ9dSmm6LFVOSKnwJUC2JqLjmUkL+hI52eC592xyJdoFew40D8m5YvlAVdr2EqL CHVYbJeXgyIcRIjxYeABsn7YZUkU56k8rkALLN+maFLPBr7Q+5gP4DXI0YDvuJOFww WRb5Fwe1ZVgUw== Date: Tue, 9 Jan 2024 08:32:57 +0000 From: Simon Horman To: David Howells Cc: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Steve French , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yiqun Leng , Jia Zhu Subject: Re: [PATCH 1/5] cachefiles: Fix __cachefiles_prepare_write() Message-ID: <20240109083257.GK132648@kernel.org> References: <20240107160916.GA129355@kernel.org> <20240103145935.384404-1-dhowells@redhat.com> <20240103145935.384404-2-dhowells@redhat.com> <1544730.1704753090@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1544730.1704753090@warthog.procyon.org.uk> X-Rspamd-Queue-Id: 8691A140014 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5b7ibwexnie5c4dxspdxziaibrdwz7zk X-HE-Tag: 1704789190-313128 X-HE-Meta: U2FsdGVkX18vzvlDqE8Tgt00mpepADxl02/caqwmOpaORrRd5v9GWv60EtF1Or+O3d2f9lpPH5d8oNVPFxJpzYWpoc1xXDj6N0hzIUOwuFLw1atO17k1J9Xz94aR0TA1NeOyWIWATJdimLaYhuhvOG6Mj9eDObI1mVSn4CUgQrw0v7tfToto+RvWb5KNn+mLvOOQz4y/Dl4QIuNQ3Ea8J++ke/WzPAMTUpbSzrQIQz8wFtGT3nDn5SxCPfmL5aVoJB/1MWuRD5ut8ZVqw1Q7VGlEqHwXWhaG+51SFAnM9TGjzIpvR46GAlClPuWjeIV8ppB5GGIVqVLN0H8pWDkIbNJE2MdqH1e344zA4wB2nfPVYw/o1yWryTttBM+1tUhch9ygdbYB8WCO4D5y1uhp40UiLlP6ek6TXurs5+07DSc24ln8WjUvFXoboK4Wt8kZWrKVM7zjHLnnN03i18aWbRBG99SnYkPVd1YfBqk/+QVmVO9pJtTVRsqvZbFnbsQZsWA5gNp4lYb5pgzwcJW8omtUy31oF8s5s5LYtHHTQ47AZ7YmQkvvLil99bHMCtxjter6qxAfbSLdsTRQWenrmzg/XVwZTpcVVT+4dXBTYkrD/ptTDweRPjqksaix7Pg7FhiIOTuVXORVucixnadBv8Rt3oIP7JbdzQMR190Z889b2znFQLR4P+xgcSuRO01ykXgtNNplQJC40DrHKX7GigxWTZmWdsRflr2f3XMxj1qEEqlT843arfA7EnvIklPig07utGSlPwgiehKHY+GQLRYj/gIF9dgTaR3rBolaEkjLYtFEq4KgLduH1s/FFO9glMKl6VfF6OmiEQ5krMV8H7sfx0SAVAuuisQDcLDS7E7D19UTlQI3trozQv+JeVNkInYldGS+SqPHJtdkCkfgPB5cScAU2CQMB++NYUxqvZvBGmMobNvQZ3jklra4hzhHlGwwFyPFhSU5xxuHZif oflBIVpC I5BKjG7MtB46nxJUKaCGfernHogpn4osf1Pm+87s3VCDd4KSiqEabQdj/72ekb2FHZGgBSzzOLG7kKnbsTm2CHbm7FJND2Gdf6jkAF6xRAR7wNf0SSdZQgfL8JoVT4WPQH83Lpr+W/zIeXof71+NK4+EN69VMXLuFnQXomBnJJ/zQMjqHZ6XSO0E9WYjdkCcbkwcJFLNlmWOZn/P+9c9Pt7ywb3WRvfD8Paz3BT0zLxc+d+iper/HCMTTi0Q8CzS6QpmibZiwFT5BUcJszuPCbKB5FVh7Jwsc6PlRhW5KTB17Tlj8SMwmkEIFf+abncSXPC4/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 08, 2024 at 10:31:30PM +0000, David Howells wrote: > Simon Horman wrote: > > > I realise these patches have been accepted, but I have a minor nit: > > pos is now unsigned, and so cannot be less than zero. > > Good point. How about the attached patch. Whilst I would prefer to use > unsigned long long to avoid the casts, it might Hi David, I would also prefer to avoid casts, but I agree this is a good way forward. Thanks for the quick fix. Reviewed-by: Simon Horman