From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CE1DC3DA6E for ; Mon, 8 Jan 2024 17:24:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD5646B0081; Mon, 8 Jan 2024 12:24:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C85AC6B0083; Mon, 8 Jan 2024 12:24:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B74146B0085; Mon, 8 Jan 2024 12:24:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A92916B0081 for ; Mon, 8 Jan 2024 12:24:42 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6EF10120705 for ; Mon, 8 Jan 2024 17:24:42 +0000 (UTC) X-FDA: 81656818404.15.C882C72 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf13.hostedemail.com (Postfix) with ESMTP id 7F0B520023 for ; Mon, 8 Jan 2024 17:24:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="GWNjZ/Es"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf13.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704734680; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/0/yZW+jizbTPKg/3nE3L3wpdEnPj+t5+Qikx8UNpIo=; b=AjqW14TiItnmkPjKuptjHj4IeuKlA+NObjHRcVENveEj3Qmsdzl94G7fvLoP6LvKJ1O3BV cnfwdVlDA/8DdOpv0SRkGMM4FSSxvpi6tVwYCjewEiHAnlT/IWUbBYgjGxDRa9k6WLjRF5 b4kZjZdr34UkV0rRa5bdzheYVPqE38k= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="GWNjZ/Es"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf13.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.179 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704734680; a=rsa-sha256; cv=none; b=kQR7sT69hjHvrON3EZzzpcbyUVDQ9MPkHgZKRcNQXWHgJ0/Y/AgZRnRp6cT9A8qMh+1M1Y QnxW5F21MsDidr6zwxTcJqc57NmizHQcdH5zsPf5kcc0oplbsp40Tuonq50EcilLyRSZf2 OU7GCruxYv1J0BvRtiGKCKdWC5E8JjY= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d3e8a51e6bso16447205ad.3 for ; Mon, 08 Jan 2024 09:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704734679; x=1705339479; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/0/yZW+jizbTPKg/3nE3L3wpdEnPj+t5+Qikx8UNpIo=; b=GWNjZ/Es6O4GrmNzP9G8sblCIqng5AhjRDQBAESC1mZeficLoP11+RpJYtVQfkMQGI d6mCEzuQCkBm3sg3EJcDy3eErViCiGcTFTWBkxmMpVSxbZ/mMWChwJIPpcpHjkuFd3th Cg0oU3jY+mO5x+aZZhxCEeEt0OWyzfKoQaTYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704734679; x=1705339479; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/0/yZW+jizbTPKg/3nE3L3wpdEnPj+t5+Qikx8UNpIo=; b=Euq3ySR1XseeWd2P9Q0nCGTZT8bgjX1tOQ0O5/0BXJ0B2QAmwemn/0Xi+WYWUG/wZI sizj3TDA8Pc8nh7IgdRa8wMjx77mtsYRuOemSho4Mo/8prwRXkxFyjQZ6t6SrFzb+4B3 gspLKYFrK7UL/e5i9fmTUt1sOjx93eoD1RcBRscnjG++dmu5JZOnqiO+rsWIRxelRv+w iA/C5iUSN2pqsPqZJdbzwZtjlkHHWNPNGL8jw8zrsY3ZAkbMyjENw6jV/xvpb++4rV4U lI6/GpM+3jABTtV8QJ7s7sZ2lsnfZaMvGUpC0vhbCWpoFpSc9z2nVAg2J1E7wrbCz5In oZaQ== X-Gm-Message-State: AOJu0YwMWZoCTP056zotFv1xgf0Q13ZXswz4u7aDceMh+IW82Qv2lW8f twHmkx7fi2W+OBt0GkcBkLNrUUoTIWOo5wQyDVMNaNUZsg== X-Google-Smtp-Source: AGHT+IGXUaIsk4LzkicBoi9K3B75PqICfJ/nDEBSERGNdYftoElqQ6rDd5l2c8wC5hk7hXSwXzohbQ== X-Received: by 2002:a17:903:32c8:b0:1d5:36b3:bd83 with SMTP id i8-20020a17090332c800b001d536b3bd83mr1814808plr.101.1704734678959; Mon, 08 Jan 2024 09:24:38 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id o12-20020a1709026b0c00b001cfb4d36eb1sm146208plk.215.2024.01.08.09.24.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jan 2024 09:24:38 -0800 (PST) Date: Mon, 8 Jan 2024 09:24:37 -0800 From: Kees Cook To: Askar Safin Cc: Eric Biederman , linux-mm@kvack.org Subject: Re: [PATCH] exec: remove useless comment Message-ID: <202401080923.A8F568C2FA@keescook> References: <20231227003120.11209-1-safinaskar@zohomail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231227003120.11209-1-safinaskar@zohomail.com> X-Rspamd-Queue-Id: 7F0B520023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: c9qigje4sm615j9mps7c4np8h8iqkb3x X-HE-Tag: 1704734680-678974 X-HE-Meta: U2FsdGVkX1/w26ofa2IE+QBUIjzVFkQj3Bnpj6/2ou/LHwcYf6iM3+Puj4u9m1jYYipyZi4/jx8IpX7DvbZcqtBEgi8x8uKnDAJkykZcECjVqaqKFjv+IYsE+E0J16YQ40ovCivjyyWggVDVTJf2AMYiMi/C5sSh7erWXnKPU8BKz46xtimECpNgHOQjr+O2i7DqbvOH46QMFlIAigw41fYB06EF/daSRnSxufYDQNGPZS8n63s7yVXoUQi0ftbYXT7jCq7UXCWhJuDK95O6RNyJHn55Ks4TGd9Bp5WM87k21czaYjYLjoCAPnerFsslMFNmCDLyKdHDaJMjUKaMdmBejkjsGokOrBnWpR6ppd0rl7nBLZ1WQGH7eOpJClQ2GE3vxQo51H0I440bLL/3Ti9kKXqWF132LkoCFKBhqD0zGxrONiAxHCV5vo0ND6WAH5skzDIitQtEib2q0szJTmdg6e6zqRJ/xblwYpKAg6XB2Qmqf0lSmB4y7mfbWvz4zt7JEnJrWqzW0q36Rk4+a9Uhqw77Rlw+qJ1KTH05NBENAel/R8eOmexXKI5NLFCB01a/FJbrIhgvzziHskdeI+wgBHHbJFOkMlRWLj9VYtWS+GGHvvTNAeV2saIXBizcihntde/x2jfN5hHP97FavSIj00jx6DI2+4R1rnOpmw9SYysVHIO2dd6aVu5c26X3dK3IjJSONEWUz1wvNn7huGiBDeTAYqQ9hMsNhKL8F1S8hWNV4W+iRpUsZMe+QWDETSH/4A9BlvpHZAb1WjtAdKO/V5k7xk6aROhzKWkEdJ5/Ea+lS4JrVvT/YQdCZTCMfIFDC5yh/jTkkmS3m8b4fjsl1NYiVimLdOcHvJ0DW2q26lZrUfHrfhjqZGxILdCmRAeyZROh8OULfpK7gtOVTisnQFHT2AcHZyEjkvOIUwKFdZmFfYIYEQZkz+Z5iT2az8YF3SgCR37Zb28mX/G +LI9iSOi j6wzsXojL+oG3on703RqGZbW76Mx+YwObvBm9WkvGBdvRTcnInPwdCAf+IzJ4HONDSUS66wibY1Gn8aCuIRQUs2yDssYhsHyoRIekr+ykwT6DmuToOtHsL8NUCQphtIQlCYCfPkip075X3YO8rQD39ntpe+eJNJ1MIRNjpK9WFKfM+XWEOVpNlVRbN9dFWSHmaAAzypHWMN+oVRBKvDodPwMqZs8gozZAVPRmW61uaJJF4okpI0S6LTS7AXNAdSYzxDTxZDs4Nl+sDQUWvuWldqvC510qFgTrpJs5G1ovtQ/19d2Y82xmb6Z7m1H6saoNibA3408MZKqYBy7xyDbxks25J3WdmVCwGbrxExexiaX6g9k/IFMtVnKmsHXTmwpktVNwsvDrR+qsZvDYIAMQeW1QNXDyUPpXNrUkoXSnyH4ZoAKSLspWlSdbiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.115254, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 27, 2023 at 03:31:20AM +0300, Askar Safin wrote: > Function name is wrong and the comment tells us nothing Yes, quite true. :) Can you please include a Signed-off-by? https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin -Kees > --- > fs/exec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/exec.c b/fs/exec.c > index 4aa19b24f..d882a6128 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -1804,9 +1804,6 @@ static int exec_binprm(struct linux_binprm *bprm) > return 0; > } > > -/* > - * sys_execve() executes a new program. > - */ > static int bprm_execve(struct linux_binprm *bprm, > int fd, struct filename *filename, int flags) > { > -- > 2.11.0 > -- Kees Cook