* [PATCH] exec: remove useless comment
@ 2023-12-27 0:31 Askar Safin
2024-01-08 17:24 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Askar Safin @ 2023-12-27 0:31 UTC (permalink / raw)
To: Eric Biederman, Kees Cook; +Cc: linux-mm
Function name is wrong and the comment tells us nothing
---
fs/exec.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/exec.c b/fs/exec.c
index 4aa19b24f..d882a6128 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1804,9 +1804,6 @@ static int exec_binprm(struct linux_binprm *bprm)
return 0;
}
-/*
- * sys_execve() executes a new program.
- */
static int bprm_execve(struct linux_binprm *bprm,
int fd, struct filename *filename, int flags)
{
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] exec: remove useless comment
2023-12-27 0:31 [PATCH] exec: remove useless comment Askar Safin
@ 2024-01-08 17:24 ` Kees Cook
2024-01-09 3:04 ` [PATCH RESEND] " Askar Safin
0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2024-01-08 17:24 UTC (permalink / raw)
To: Askar Safin; +Cc: Eric Biederman, linux-mm
On Wed, Dec 27, 2023 at 03:31:20AM +0300, Askar Safin wrote:
> Function name is wrong and the comment tells us nothing
Yes, quite true. :) Can you please include a Signed-off-by?
https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
-Kees
> ---
> fs/exec.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/exec.c b/fs/exec.c
> index 4aa19b24f..d882a6128 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -1804,9 +1804,6 @@ static int exec_binprm(struct linux_binprm *bprm)
> return 0;
> }
>
> -/*
> - * sys_execve() executes a new program.
> - */
> static int bprm_execve(struct linux_binprm *bprm,
> int fd, struct filename *filename, int flags)
> {
> --
> 2.11.0
>
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH RESEND] exec: remove useless comment
2024-01-08 17:24 ` Kees Cook
@ 2024-01-09 3:04 ` Askar Safin
2024-01-11 0:50 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: Askar Safin @ 2024-01-09 3:04 UTC (permalink / raw)
To: keescook; +Cc: ebiederm, linux-mm
Function name is wrong and the comment tells us nothing
Signed-off-by: Askar Safin <safinaskar@zohomail.com>
---
Thank you, Kees! You are very kind
fs/exec.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/exec.c b/fs/exec.c
index 4aa19b24f..d882a6128 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1804,9 +1804,6 @@ static int exec_binprm(struct linux_binprm *bprm)
return 0;
}
-/*
- * sys_execve() executes a new program.
- */
static int bprm_execve(struct linux_binprm *bprm,
int fd, struct filename *filename, int flags)
{
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] exec: remove useless comment
2024-01-09 3:04 ` [PATCH RESEND] " Askar Safin
@ 2024-01-11 0:50 ` Kees Cook
0 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2024-01-11 0:50 UTC (permalink / raw)
To: Askar Safin; +Cc: Kees Cook, ebiederm, linux-mm
On Tue, 09 Jan 2024 06:04:34 +0300, Askar Safin wrote:
> Function name is wrong and the comment tells us nothing
>
>
Applied to for-next/execve, thanks!
[1/1] exec: remove useless comment
https://git.kernel.org/kees/c/38132920f430
Take care,
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-11 0:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-27 0:31 [PATCH] exec: remove useless comment Askar Safin
2024-01-08 17:24 ` Kees Cook
2024-01-09 3:04 ` [PATCH RESEND] " Askar Safin
2024-01-11 0:50 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox