From: Kees Cook <keescook@chromium.org>
To: Askar Safin <safinaskar@zohomail.com>
Cc: Eric Biederman <ebiederm@xmission.com>, linux-mm@kvack.org
Subject: Re: [PATCH] exec: remove useless comment
Date: Mon, 8 Jan 2024 09:24:37 -0800 [thread overview]
Message-ID: <202401080923.A8F568C2FA@keescook> (raw)
In-Reply-To: <20231227003120.11209-1-safinaskar@zohomail.com>
On Wed, Dec 27, 2023 at 03:31:20AM +0300, Askar Safin wrote:
> Function name is wrong and the comment tells us nothing
Yes, quite true. :) Can you please include a Signed-off-by?
https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
-Kees
> ---
> fs/exec.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/exec.c b/fs/exec.c
> index 4aa19b24f..d882a6128 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -1804,9 +1804,6 @@ static int exec_binprm(struct linux_binprm *bprm)
> return 0;
> }
>
> -/*
> - * sys_execve() executes a new program.
> - */
> static int bprm_execve(struct linux_binprm *bprm,
> int fd, struct filename *filename, int flags)
> {
> --
> 2.11.0
>
--
Kees Cook
next prev parent reply other threads:[~2024-01-08 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 0:31 Askar Safin
2024-01-08 17:24 ` Kees Cook [this message]
2024-01-09 3:04 ` [PATCH RESEND] " Askar Safin
2024-01-11 0:50 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202401080923.A8F568C2FA@keescook \
--to=keescook@chromium.org \
--cc=ebiederm@xmission.com \
--cc=linux-mm@kvack.org \
--cc=safinaskar@zohomail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox