From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C944DC3DA6E for ; Fri, 5 Jan 2024 19:20:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 452DF6B02E5; Fri, 5 Jan 2024 14:20:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 402D96B02E8; Fri, 5 Jan 2024 14:20:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F19D6B02EA; Fri, 5 Jan 2024 14:20:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1D27D6B02E5 for ; Fri, 5 Jan 2024 14:20:16 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7D2E5A189C for ; Fri, 5 Jan 2024 19:20:15 +0000 (UTC) X-FDA: 81646223190.24.013E0D7 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf07.hostedemail.com (Postfix) with ESMTP id 3EB7F40026 for ; Fri, 5 Jan 2024 19:20:13 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=aB0j7KDK; spf=pass (imf07.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704482413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/a0UKaTZTMHEDAeTcb9/TUYxxz2I8dAfWxoQjcoX6lk=; b=aboYWX7OcsyWbzqN0qNgPC6JgqtfSkREYXBbq0aQQLLggeHr/kznGmRg+EdYJ/g60IjoL3 zR9io1Ds1w2uj6iqqMwHScRVgOzvNNFZY1BJBVqvDTqIXZf+wWoBNkH2KtWuf/Wm64KXND BD3eVyPoO3B+FomxYDZDq+GLnqJXF5g= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=aB0j7KDK; spf=pass (imf07.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704482413; a=rsa-sha256; cv=none; b=AwI9X/C0gTNX33uiV6DJIki20MZdsjgCc/sTeGKEe5bT/gk/IEqOGNp+KEmVkR/VibxWPb KueufJevazfHOPhTl41rpv2KCLqJfK/XbSbFRMf6HOX0bVjMX/bCk/xowc0gtycMN519Qi lmNAdJDsc+VOEhEDnuPjRhQH5gYCg5g= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 4CE2040E0196; Fri, 5 Jan 2024 19:20:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0HqsHS1C0SBX; Fri, 5 Jan 2024 19:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1704482406; bh=/a0UKaTZTMHEDAeTcb9/TUYxxz2I8dAfWxoQjcoX6lk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aB0j7KDKQj5CmPpTDfG8fpfAgLxkhkEPYfftoiRN375Q2eqjmbXSZoLvE1rkW77ur PBB7Bhkm7hV1hQ5zqE7y3eiSezd+C2GUrHWdxLKpJpHpKDRTaCVdwrUyJBicvK7y8b n4xfyrSeqlVW7GPisHaI/41JrTno/0pm91uwlQfYucfSvFu3lIcoHt0v19OfT2Bpk7 6gCCZP0zsZRj0YxlIHFJtx2RHMUgIT7eEb0Bm/RzsR5NE03ncesHWgxCtBXEXDZOI2 CgnqiDwNGwZk8xiO+nVW+VLrYMh72Ol3PSuzDEjl26zuhx8gqXscQJGNHR8BIpe82d fpJj5Fkn//3ajL6hD+dFCKilsF+JYuFLqu9nI6qEAmio/sCcjgB8foNEgyRkjCJlEk +GT0bLOv49gpGqT3M3tji45NaKScH5oEnYcAC9+6CGNnz1P9JSThezuZuoL4qINjn8 qaUKvknOiIm8IfGkVPGmohdF4wyw8rwWoEq/dvhO84tm3vYhb12ACwTiqUX+/959h5 h26Lgcl/UzvbK3ECtWX85yXyO1KjvTWvCQqJMeV9MetLGDerh1p2AKYryaJb1hCY2C o1VJqEql+2MuC/k6EYSHlWU/sx+3wxccHJ3FwwEYYtMGqQwcO7gv59LDp4dCIlNMub AFpDI4YqDo5B71rG79b35ceM= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 49A5040E00C5; Fri, 5 Jan 2024 19:19:28 +0000 (UTC) Date: Fri, 5 Jan 2024 20:19:21 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v1 04/26] x86/sev: Add the host SEV-SNP initialization support Message-ID: <20240105191921.GHZZhWObgbgXxP/kkB@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-5-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231230161954.569267-5-michael.roth@amd.com> X-Rspamd-Queue-Id: 3EB7F40026 X-Rspam-User: X-Stat-Signature: r5zq48ceewzrww4ydcostt8yqwnpr4sy X-Rspamd-Server: rspam01 X-HE-Tag: 1704482413-262119 X-HE-Meta: U2FsdGVkX1/JHzhYQm2icvfCzqCEhsegtgVbUtj+u926IQME9KMkzymQGsOSb8ugn5QdngpQdN6cawr1BAEOLJFr4vQ6k9/VJ5ZJJg4nyhmfc/VRVYf6cTjgoXr/GQgVyzF0VHORGG9WI4E1HNQf8s+3DNFxqvL1imIibr8mskA7jqQbXEZUWXeh7ugKErEqErx9852TKlMffNL8qhwvyez1RMCMDENaGYifVhpjkx3GQ+DeUHbTU2quTbwU9D8eCRgeBRsTW0zn9gZWMNqUF88VnE2JdEgaCf9DwxckXwBHbqUIGBPb+PMLf3F7drpkmj1nm9F7aPmhOkyo9Fdqdcmw1r1d+TUITEOzhfw3+ybpoIj+ZJbUzWYhGPOIjyfwr3A9dRtNZVN5LQ2N1gAXTQdfUErUSoZ1MbwaNo0bfAIPx6SLH2heSnGp7qUfLY9ZM3neOtNlTz8W0AuBUQGfccxX1/B19Qaafq5nkXyTAmVw7dM85/jPT7usdO/9hLXqtoE8O1ra76VhsrecxejJZbo97kwXdJ2hilPWl6PbKvkMapC2AQFQpEatcdwz78r4Kuw4naccwWjzKTQOdTls/JvYRvEmMpkqkJrhDRExoyCJCxOzK44P4+BOtyBvKT8oGBk2NNjt2J2Q+7voI+Mq0hE0E5FIcdzsqc9wqyJkxema2ciFAleq+FaDC3LGjXj3J5cQxbkJBmtPnakPdaFCiKykYtlDMtNX8nNcGGYdC7TJtO23zpIRWkHIsQjG/3vorWvamUnhAvfAf0ukvMVIYRCc3z1dbJj1Z7rx/fdVXqpDFVDBbfAemgsol5GRkVv0uDzg9OgAOisRoWzcDJUpuRY9S3yP7Z++AcikH5eSyt2hhcY2sjEzA/B+6M2PkwnBtW4DCvcyvlJ07LTfdWB7EFW8tRCwxXntZMVRoBOcNTvHqWBnmosBxep0I8rHBfjZzZs7VNexMshtYrxcM1M vJAZZ2NF tN8JEO9KzSHmxqFvhRHfSr7WAWszfO4vhj3qb6zz4Qr2gDEy+HdTivsD6HICRGUv8hDd1BtjFyEIxHWBiJJaJtuhEohyolRpICXhS2sWdvpRmx06MIoHrZr/79Ypo3YFmoVZrFrZ9/qQwudS1saoM4MbwWGTIFnd6ko9cxkEXtSYh6fkndeBHBp4I7VJDWtUearnfQGxQtWdGSK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:19:32AM -0600, Michael Roth wrote: > +static int __init __snp_rmptable_init(void) > +{ > + u64 rmptable_size; > + void *rmptable_start; > + u64 val; ... Ontop: diff --git a/arch/x86/virt/svm/sev.c b/arch/x86/virt/svm/sev.c index ce7ede9065ed..566bb6f39665 100644 --- a/arch/x86/virt/svm/sev.c +++ b/arch/x86/virt/svm/sev.c @@ -150,6 +150,11 @@ bool snp_probe_rmptable_info(void) return true; } +/* + * Do the necessary preparations which are verified by the firmware as + * described in the SNP_INIT_EX firmware command description in the SNP + * firmware ABI spec. + */ static int __init __snp_rmptable_init(void) { u64 rmptable_size; -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette