linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Melissa Wen <mwen@igalia.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	Alex Deucher <alexander.deucher@amd.com>,
	Harry Wentland <harry.wentland@amd.com>
Subject: [linux-next:master 7009/12403] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_color.c:958 amdgpu_dm_update_plane_color_mgmt() warn: inconsistent indenting
Date: Fri, 5 Jan 2024 16:31:20 +0800	[thread overview]
Message-ID: <202401051643.PPdbmG1U-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   d0b3c8aa5e37775cd7c3ac07b256218df0fd6678
commit: ef113a3b1964b40dd87287806865b947d70f7df5 [7009/12403] drm/amd/display: reject atomic commit if setting both plane and CRTC degamma
config: x86_64-randconfig-161-20231228 (https://download.01.org/0day-ci/archive/20240105/202401051643.PPdbmG1U-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401051643.PPdbmG1U-lkp@intel.com/

smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_color.c:958 amdgpu_dm_update_plane_color_mgmt() warn: inconsistent indenting

vim +958 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_color.c

   918	
   919	/**
   920	 * amdgpu_dm_update_plane_color_mgmt: Maps DRM color management to DC plane.
   921	 * @crtc: amdgpu_dm crtc state
   922	 * @plane_state: DRM plane state
   923	 * @dc_plane_state: target DC surface
   924	 *
   925	 * Update the underlying dc_stream_state's input transfer function (ITF) in
   926	 * preparation for hardware commit. The transfer function used depends on
   927	 * the preparation done on the stream for color management.
   928	 *
   929	 * Returns:
   930	 * 0 on success. -ENOMEM if mem allocation fails.
   931	 */
   932	int amdgpu_dm_update_plane_color_mgmt(struct dm_crtc_state *crtc,
   933					      struct drm_plane_state *plane_state,
   934					      struct dc_plane_state *dc_plane_state)
   935	{
   936		bool has_crtc_cm_degamma;
   937		int ret;
   938	
   939		/* Initially, we can just bypass the DGM block. */
   940		dc_plane_state->in_transfer_func->type = TF_TYPE_BYPASS;
   941		dc_plane_state->in_transfer_func->tf = TRANSFER_FUNCTION_LINEAR;
   942	
   943		/* After, we start to update values according to color props */
   944		has_crtc_cm_degamma = (crtc->cm_has_degamma || crtc->cm_is_degamma_srgb);
   945	
   946		ret = __set_dm_plane_degamma(plane_state, dc_plane_state);
   947		if (ret == -ENOMEM)
   948			return ret;
   949	
   950		/* We only have one degamma block available (pre-blending) for the
   951		 * whole color correction pipeline, so that we can't actually perform
   952		 * plane and CRTC degamma at the same time. Explicitly reject atomic
   953		 * updates when userspace sets both plane and CRTC degamma properties.
   954		 */
   955		if (has_crtc_cm_degamma && ret != -EINVAL){
   956			drm_dbg_kms(crtc->base.crtc->dev,
   957				    "doesn't support plane and CRTC degamma at the same time\n");
 > 958				return -EINVAL;

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


                 reply	other threads:[~2024-01-05  8:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202401051643.PPdbmG1U-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=alexander.deucher@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=linux-mm@kvack.org \
    --cc=mwen@igalia.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox