From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51FBBC3DA6E for ; Fri, 5 Jan 2024 16:22:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C34B68D001A; Fri, 5 Jan 2024 11:22:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE51E8D0018; Fri, 5 Jan 2024 11:22:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD3D98D001A; Fri, 5 Jan 2024 11:22:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9E03A8D0018 for ; Fri, 5 Jan 2024 11:22:34 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 770E81C0CEC for ; Fri, 5 Jan 2024 16:22:34 +0000 (UTC) X-FDA: 81645775428.29.31425D3 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf25.hostedemail.com (Postfix) with ESMTP id 66705A0022 for ; Fri, 5 Jan 2024 16:22:32 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=B5hW1EV9; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf25.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704471752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j+eM5pN/ZJjguSTXrDo3g1D8mHy8zmaIa7AEsjD59Ss=; b=hr9TmxqPS5sGIRM5yjCZGWla5NNMSwaQQ2rJtxHK2LjoqY4AQXT+By5/QvTCPJ5RFL7rbx t4650nwa3YD01Pxt+usP9/KOyBvSs9sonEsQT2S15cAo6h4rLXlitavQ6fjQh4qGUwaBPE XayoOWCNElktXVKUO8PgUfsZ1jH8F80= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=B5hW1EV9; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf25.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704471752; a=rsa-sha256; cv=none; b=lJPL8w2XOtGJNj9UUETerck2mZ7ieITuZ3ny3CZkrH8f1IFkEZkp+hevvi8Mp8FaIjr8HO l0W9ygf9l9olRUz/04mPF5sQ63mApZZ5GlaY+HLmePxaPRglm2joWe7CBXGLSIUBRRmUC8 q2gJFsePqX9U2EtnnMTbsapyMDu3lDE= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id C73DD40E016C; Fri, 5 Jan 2024 16:22:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 84HtEWuwaCZG; Fri, 5 Jan 2024 16:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1704471746; bh=j+eM5pN/ZJjguSTXrDo3g1D8mHy8zmaIa7AEsjD59Ss=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B5hW1EV9vq5JsAI+1K8hZ+f2YqJiyOSKPbVarcMMiw8kX2ro9XqQCODVg4iFe/8fD NbSSivZTtrQT8C7BxFa1r+3wg7vnBfocNEP25TIBX6PPQIUjouhNkLFt5qQDLDZQF3 GcrStKGHX+9V3L+8K+veTdS3iX3KgBDOqKjRijz3eaZFMPKLWD5I3S/nUEc7FUtMua OxSJc7LIquZzRfl25m1BfXTbp/+b6CCNX49o01v4+//tf4vZavCs52zR6GK+KOBk1M CMmrYtfB9tmVTYO3ZQfTtEy4GGBumFGc9Ii8TlDcXSOyqbfvndPOB2owY7i6nBe5zb q61eALCQgj6osq0Ey2wjgA75scGAlI46jHRjhfi+3Eml/OR3RND0+0N3t9Koohpr97 9b3/yw4hn53CarYV5+2qqXyM14tD7rKlN/IcrMjh55wgT6dN/lJSiUvaXL5B9NMbf+ JE3TFAEv3LTJMUaOk4vn/2+DMTrWYpMrgHUwVnC5kLreh3vS5P+EnlK8X0YeFz7mfM MapqpvHY/m07UOKex0RizLW2ykAOU0jdTwauka14ssguCs8KKAs75iH6KxiIHAF2wV ggQIii0tmodflsN7YB/D/WWv8Ci3WR46LazY5XuNEajUAbiv/GEmC6XEodW4IEugwu vYB5DRcBjVXm4N99CMbdoLkc= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 08D6A40E00C5; Fri, 5 Jan 2024 16:21:47 +0000 (UTC) Date: Fri, 5 Jan 2024 17:21:42 +0100 From: Borislav Petkov To: Jeremi Piotrowski Cc: Michael Roth , x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v1 04/26] x86/sev: Add the host SEV-SNP initialization support Message-ID: <20240105162142.GEZZgslgQCQYI7twat@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-5-michael.roth@amd.com> <20240105160916.GDZZgprE8T6xbbHJ9E@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240105160916.GDZZgprE8T6xbbHJ9E@fat_crate.local> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 66705A0022 X-Stat-Signature: 89s6yk66tym8fwprgcitckcqtdbfk8jy X-Rspam-User: X-HE-Tag: 1704471752-340086 X-HE-Meta: U2FsdGVkX18daLdQRsW99KgAoMaymrBsltPwvKnAJfyCZxPZWnmXVuUayycAwJ6IVY3abzcLFRkuf2LA0x3ceoDOs5jxCprzD7Ub65GDT3GyMBTAHFqYYVUHiAQZPl/LP0Shj6fuKkGBFCBTBFF/5IkvkXED3csAyvUQShoEV+eqj2N+2PyJk/q3L4Vt4kDz+aSdM29IlIUfW0l/JZMBrfYk/kwLCA7gId3s6Ly8u5Bhdao2zLCo2LeaGYI/xiP6Jkz5qhDLNpAJ01RBtM+D7488N1C+hM23a6Je9v2yLq7WfC6P1pJGc8Js35N2DwerMARVE5yBsFVD3hpd8LQeOurdVs45CNMyOB5e3SOLl2BEJBM0ZRfrSmYiFFpT5Jjls5VvTQBh6pVJANNT9F/O/dyFutWKnJs+vkAeO50d831vyrWzAKKjRuoZ8/VWwNbfa43jlFGecE+Qh01uLgbtjPclCQA37grSfaZ7if3OoBveYVTlCsPVKF7qr8koBEAHAx6634vwmTy/S8uvO4s4cDZmB31hGQzJYB90f5sgnPO4/aBmZnPBMbGggMU7fwqoTgU8H4Ep9byloec6MsLrpxySVOZIcNhEtBm8kchDPZErfy3wo36wm/0xibWyeCazBEKHDoxJ+1beeGBTMM8IgrlsPdKpUd8N+JuPUcKm+l0AVDgxI9lvYPcY3zbJflm+0vOxjcnBUszd/Spa8C+R4j+BinvKGTqqyiODRSaZrseZw0TxxCMJg986P7syuf9u1X+LULSi5l9q8mijABpyjS93Rf84jS484m+YmXr22X9esLyNbKNGFuP33KtsWMNI3Rjr5eHMq2oFkpsSOjXQgCUJe1ZaPWuGBDidLc3MEt64aBeYMueKt5PSNDVsEsiW18uy8u3KAb0z20zkHh2Ul3J7NXX859wdgAsy5xpPu73RyonpiCUIWsDOkjMVH0iz1wRAawUIBWTGOoZrr5s syRS6+w6 AdeatZj0DQacnwXwGZHWUv4/a06WuyzBxglyFDytnF0nhlNHD5wQwOCSTsltI/9wQr6zk/Pn0RAvRp92aPA5wbswzOqv4mb3j4EJKqjss/Zlh6cbDKc7PajgduFhr6JcSTB48b9rzCcBxVj2nCqO3o2Ozk1xNRvx0crUxYtDkOsI8IjPDp0srJNmjyAWwGpsNctzPH12utCa3+VgmidjQXTHGiFIPxW6LyToC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000031, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 05, 2024 at 05:09:16PM +0100, Borislav Petkov wrote: > On Thu, Jan 04, 2024 at 12:05:27PM +0100, Jeremi Piotrowski wrote: > > Is there a really good reason to perform the snp_probe_smptable_info() check at this > > point (instead of in snp_rmptable_init). snp_rmptable_init will also clear the cap > > on failure, and bsp_init_amd() runs too early to allow for the kernel to allocate the > > rmptable itself. I pointed out in the previous review that kernel allocation of rmptable > > is necessary in SNP-host capable VMs in Azure. > > What does that even mean? > > That function is doing some calculations after reading two MSRs. What > can possibly go wrong?! That could be one reason perhaps: "It needs to be called early enough to allow for AutoIBRS to not be disabled just because SNP is supported. By calling it where it is currently called, the SNP feature can be cleared if, even though supported, SNP can't be used, allowing AutoIBRS to be used as a more performant Spectre mitigation." https://lore.kernel.org/r/8ec38db1-5ccf-4684-bc0d-d48579ebf0d0@amd.com -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette