From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 922E0C3DA6E for ; Fri, 5 Jan 2024 16:10:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E50366B020C; Fri, 5 Jan 2024 11:10:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFFE76B020D; Fri, 5 Jan 2024 11:10:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC7006B020F; Fri, 5 Jan 2024 11:10:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B570E6B020C for ; Fri, 5 Jan 2024 11:10:10 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7BB22A1A1A for ; Fri, 5 Jan 2024 16:10:10 +0000 (UTC) X-FDA: 81645744180.28.BF86E80 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf01.hostedemail.com (Postfix) with ESMTP id 38D6840020 for ; Fri, 5 Jan 2024 16:10:07 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=e8XnFhLY; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704471008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hbXwqK0OxWvMXMXdG0rzK29hIKNQYHBM1ksrUbaSRh8=; b=NmSG69eckX6NJLyGFzlO2O0f/708eV9PWH/MiSeHFK5tkgnvYek3hZyK1nuTNrK/QafulA nNSa+k2oyLChliubaM9qnfkCrF3wOLrbg/wu2i8ysj4efL/eEyLkFGUI2YwL+a3ggJCE12 TJ6btNoh5+rw4QIutuNUOYWuLVGTHuI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=e8XnFhLY; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf01.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704471008; a=rsa-sha256; cv=none; b=hxqnfVU0jvqGKFnc5hkrkv/kD6a3Mtsml9lDUFMd5LtXvIE9MKFWddVg8uZVscAA9ORxSH T9deP+xAKfLZYMqHLaDHa43d7EV3UE1GqyQefD3iZN1ULt1iCDEqvtjm0BGUDxULOxz83m ChkAomyjAIdTXfAVggiiUB8UdMkfEqc= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id ECF8C40E0196; Fri, 5 Jan 2024 16:10:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id PCgHEbNop059; Fri, 5 Jan 2024 16:10:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1704471000; bh=hbXwqK0OxWvMXMXdG0rzK29hIKNQYHBM1ksrUbaSRh8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e8XnFhLYTn6wVrhB1oGHnnkiaLQNzGw27kCQ4orbXRtpPWQN15Ikeeb6dC9FMNT4V 08nbNNLdbuVqBsBVhLz8851dcrm8x3p+EW8GeJZlvbVieJDeTUvKCndfl3vUZCCZOY VgENpIcUhA/q6LjhAknzz6vJYImadJXtK1CwOtySrs4Fqwrx3v3/r3LmYpre2akl2w 3zpgn4xYZKZIL+9BghPvkYG6YRQc5ENXxIiK2TnxekY7MdkOtVz6vvhRL48aSxro/Z udKGIB0rzsmvT8y17GVwNigHycw2JCnHQMUNafy6TkuejfCkrrJTBzgnvpFavsmDG6 prZ0tRSDWIOyk98VQ0cl1MjsQ7mjAwFKG+ckDcgRmr2CsFKHOqRBV29c84oNDuGPx1 Wi42yvALu9FM4FCo5kSzTAz9kkS9EUCG71a4hFuZg02xr4RGRNUDXTVO0nKU9MRjwp CFWa3Yl/jANlvdO9Ifub/VFbSe2aWXSSHP12uQbsyHbf9Pl1RyDTStobt/vTQ0tVo4 VHHoSzXuujKIcOJUG7vDL5EvoN0KDvfhNXQv7p8auEiMAwO2hYJBc4SFoCONRsjmSs m1R+FAUvbMPZ5Kw5EFfRb1+UnZT4xoBaSEAWhC0/GS3Z4skpS4mHLzoJxA6ygZpZQg MDWi7EbMfM4VPffbtRq7L0VM= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 445DA40E016C; Fri, 5 Jan 2024 16:09:21 +0000 (UTC) Date: Fri, 5 Jan 2024 17:09:16 +0100 From: Borislav Petkov To: Jeremi Piotrowski Cc: Michael Roth , x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v1 04/26] x86/sev: Add the host SEV-SNP initialization support Message-ID: <20240105160916.GDZZgprE8T6xbbHJ9E@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-5-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 38D6840020 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: bnh1k67s83dogyhiu1p1zjfrwyunrcw3 X-HE-Tag: 1704471007-448014 X-HE-Meta: U2FsdGVkX1/yJx6FSdMzuw0IsbZ2O4CrZl06eCZWSbwQzjWjOPGYOrlEfxuk2fV4hkW4cZRuGbWXTTVHOEhahFXLcCrdfRpw9Sts5oQuEM55diPHCiUL0Ao8plY5ho8sjRKYbbWJvRNW9dYIgLHvq0HCnRNu2TcZW7/l75kiWBWpHt4QblF4tSwajr/WYMXAjdDSzeXOc/aj4oFMXjyEe+FyEybje62+GD8+PCGIyRYedx0BPVnZUDyUXHYPM1hXH5W/WpiQKubmXcprHBdezrFnZ0nRCrHePSXxNFIGLWrnWQKafHhwW1aj/2divU5bi9G6GkMSuG70UHr5p/fFn8fOTaAl9GD36Q8frFxGSIceUX48SAMQdZeaZ96QesEFkYrjYIuy2vWaf07wuuLvRP/fw4orwlAhjpu5u7OwdPFBOXsEwbBIn1CjZFJCJWPgVFGVLZc0jLEyt+NeIXyzsubhZpyxtnFSegTVaIVRE5kowEkqLxIsmRjeXr9w5vWqodgrQnUVawWFDNlXnPvTNABO0Ay3vql6wpFnfRxpaJahUi6eFi1OnTk0IuccvUY2t0/pnAvINkPABNf6kFL5SlnVqms/fxWlSBYRvO/OUW2x5eu0Pbc6+9jJ2CZtC+EKPOvTGYLIhTEF4IzZQ5HE2Q0VmCeP0nLrIPO52kJdaekd+F4HdYHn/RuqFsdv8EGzwM4VhyiYOwk8rWhiGo9JhMcrpGhFrZmfiOxbGIH6kgIFeF9whjyraxKs+NvteadrNbzaYojcjkC+0H0zQjaIqG6hqEW+qmB+GsU3G8taifa8ikxOVTowEokZ7xigTLez3/pvZoFDJtrR8h2stXiaKvkPTrHWljmvJJtILQ8rxWibcKciMkrgzpC9Tt7SQ4jr3w0KZPnpYtFiiuVemL/iSUbl4lCetwOtS1wn6+Q4BE1ee11sa5jmifO8pWoysoiXyDACsffafaugj9yHcZs PO+gDzwW WCOCCtdzYpTNahg6sg1IhJBXlinaLsd3oLb+jNyudmZdRNdxnXnBoSIJ8DMziDe5AKFdnVL6vJgvqq0tIHAj6O1nh/qPEUuDaA5URt/gKOdXYhiuoOEcoj2lyDVmanm0wpj382NcV3MBLgozoRRgX2ulzY+ov8UQiWqjM5VtO/rsrUSFiCCx3edhXQorIWMTgTdYhtrnBXBdZlzA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 04, 2024 at 12:05:27PM +0100, Jeremi Piotrowski wrote: > Is there a really good reason to perform the snp_probe_smptable_info() check at this > point (instead of in snp_rmptable_init). snp_rmptable_init will also clear the cap > on failure, and bsp_init_amd() runs too early to allow for the kernel to allocate the > rmptable itself. I pointed out in the previous review that kernel allocation of rmptable > is necessary in SNP-host capable VMs in Azure. What does that even mean? That function is doing some calculations after reading two MSRs. What can possibly go wrong?! -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette