linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Michael Chan <michael.chan@broadcom.com>
Cc: oe-kbuild-all@lists.linux.dev,
	Linux Memory Management List <linux-mm@kvack.org>,
	Vasundhara Volam <vasundhara-v.volam@broadcom.com>,
	Andy Gospodarek <andrew.gospodarek@broadcom.com>,
	Pavan Chebbi <pavan.chebbi@broadcom.com>
Subject: [linux-next:master 11866/12403] drivers/net/ethernet/broadcom/bnxt/bnxt.c:5662:5-7: Unneeded variable: "rc". Return "  0" on line 5677
Date: Thu, 4 Jan 2024 19:55:57 +0800	[thread overview]
Message-ID: <202401041942.qrB1amZM-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   d0b3c8aa5e37775cd7c3ac07b256218df0fd6678
commit: 96c9bedc755ed1fa6e35d37328ddbcb439c93c4c [11866/12403] bnxt_en: Refactor L2 filter alloc/free firmware commands.
config: arm64-randconfig-r053-20240104 (https://download.01.org/0day-ci/archive/20240104/202401041942.qrB1amZM-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401041942.qrB1amZM-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:5662:5-7: Unneeded variable: "rc". Return "  0" on line 5677

vim +5662 drivers/net/ethernet/broadcom/bnxt/bnxt.c

  5658	
  5659	static int bnxt_hwrm_clear_vnic_filter(struct bnxt *bp)
  5660	{
  5661		u16 i, j, num_of_vnics = 1; /* only vnic 0 supported */
> 5662		int rc = 0;
  5663	
  5664		/* Any associated ntuple filters will also be cleared by firmware. */
  5665		for (i = 0; i < num_of_vnics; i++) {
  5666			struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
  5667	
  5668			for (j = 0; j < vnic->uc_filter_count; j++) {
  5669				struct bnxt_l2_filter *fltr = vnic->l2_filters[j];
  5670	
  5671				bnxt_hwrm_l2_filter_free(bp, fltr);
  5672				bnxt_del_l2_filter(bp, fltr);
  5673			}
  5674			vnic->uc_filter_count = 0;
  5675		}
  5676	
> 5677		return rc;
  5678	}
  5679	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


                 reply	other threads:[~2024-01-04 11:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202401041942.qrB1amZM-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrew.gospodarek@broadcom.com \
    --cc=linux-mm@kvack.org \
    --cc=michael.chan@broadcom.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pavan.chebbi@broadcom.com \
    --cc=vasundhara-v.volam@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox