From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24AC4C47073 for ; Thu, 4 Jan 2024 11:34:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF7386B02E4; Thu, 4 Jan 2024 06:34:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7F456B02E5; Thu, 4 Jan 2024 06:34:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F97A6B02E7; Thu, 4 Jan 2024 06:34:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7D0D26B02E4 for ; Thu, 4 Jan 2024 06:34:37 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4CD76807A2 for ; Thu, 4 Jan 2024 11:34:37 +0000 (UTC) X-FDA: 81641420994.11.E832B55 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf13.hostedemail.com (Postfix) with ESMTP id E0D242000C for ; Thu, 4 Jan 2024 11:34:33 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=QtvPnqN9; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704368074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DaA85JZ3rfzvuiZT2nU5IqFu1BqiLfSbMwxD/EB8i9Q=; b=gquiuutJTT+F/iBtw8wZETzAUNhhIFGr95paUA5XXuB2aaz8YvA95OgCY5zkkGQ2R6dD9O VfmouMH0GxJ3bFW/wUfTetaoZlznUMjBVAs/8rrpm/RdjIm8m/0sMyt5okkMWwPu4jOu2r 59QTaKPVW3G542Carq/nSm27/0tpdeU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=QtvPnqN9; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704368074; a=rsa-sha256; cv=none; b=tHMp+3tkS81XnZc+IB8YDF2vffHij6XYseN3D/l6DPeXSRKhvTr+m7fIwROG9cRFyiT8/F e0vj4goPt0TeON5wrfV6XVvM6UHLbyj3zdHj3yx2QICUXDvPsk5eM93/sA0CKEDjcqssJj I6Z5v9QgMG+EqfBEkU6n1X4n33TiO1c= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 404AHvBh020357; Thu, 4 Jan 2024 11:34:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=DaA85JZ3rfzvuiZT2nU5IqFu1BqiLfSbMwxD/EB8i9Q=; b=QtvPnqN97N2k9foVZDhNtmrMCiDh7vZfB6hiFUM5ej2zaAvoM+sROVyv5NyHqzzOg5n6 RgSHCzptstyh3CJ/WWyw6m7AYL/F82+Qtzmx0roLaWwQIfTcmIXw2wcsy5/BgJOKFnMs sPE3aaWlq0RTr7xFhuRQMnX5bih59Vg4qmM9NBcPjmnAcwDk283/BdX/HxPq3jL4Lp63 GFpvdj037rJweGJ0Wre17ufeeVGDwg9GHVqVIbVSPuKasR8zriF2S7rZz7Ad/dX2o8f6 u98Yv0CD/Lu7URpDfBB+Fvmn1aQTWWyDRcSQJjdHukhi1gacyi7PgDoI/kL1234Gao4v eg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vdm4p87u7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Jan 2024 11:34:20 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 404BQTXx032285; Thu, 4 Jan 2024 11:34:19 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vdm4p87tp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Jan 2024 11:34:19 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 404AUHJA019397; Thu, 4 Jan 2024 11:34:18 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vc30sr1yw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 04 Jan 2024 11:34:18 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 404BYFI428508726 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 4 Jan 2024 11:34:15 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1912520040; Thu, 4 Jan 2024 11:34:15 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 347CD20043; Thu, 4 Jan 2024 11:34:14 +0000 (GMT) Received: from osiris (unknown [9.171.1.64]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 4 Jan 2024 11:34:14 +0000 (GMT) Date: Thu, 4 Jan 2024 12:34:12 +0100 From: Heiko Carstens To: Alexander Gordeev Cc: Ilya Leoshkevich , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Subject: Re: [PATCH v3 28/34] s390/mm: Define KMSAN metadata for vmalloc and modules Message-ID: <20240104113412.7040-A-hca@linux.ibm.com> References: <20231213233605.661251-1-iii@linux.ibm.com> <20231213233605.661251-29-iii@linux.ibm.com> <20240102150531.6306-F-hca@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: A-r5ni_NxO1svHGVXf-nj62fil3Gwpze X-Proofpoint-ORIG-GUID: OVn0-Bn5itLqAoOpBhaSOLkGr5KeaBNy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-04_07,2024-01-03_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 impostorscore=0 bulkscore=0 mlxscore=0 mlxlogscore=678 malwarescore=0 spamscore=0 priorityscore=1501 adultscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401040088 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E0D242000C X-Stat-Signature: xbch5dpegcgtfzg9ha8neu3411kw7uac X-Rspam-User: X-HE-Tag: 1704368073-979729 X-HE-Meta: U2FsdGVkX1940JasGHkazWlvOwzdKXcR5QKQXtfIytrit2VVkegfn1Fek6XctrI7tu1KR8AbPbg0Al+kF+ZmgLMvtyhSHnlKd7uAJ+gXXVZ1bxl8NTVmRibn/qjNLh+a+vDHINSh3e0MIu8tLUvjFxMqWsrOaGCf72GrKLbDGQ6AvIX7O7v0SNIosGNLR5Z7dcinx0walmQF6Kxd5xArxFooQX061RIOZ2yDP7oJh5StUYDu0Op7FxvxUEyjckdUq3Ng5Pwmr6H61z0Ku9d7aSKTHyM/u0TB1BlJrgFwJ3p/u0Uhtgp+HZn1TAg8d4Tniewv54dL0RHwYSBmJlgr4xLM41qjlwjOl+0WaDOxE6qgHw5d8ZXK1V7JxEkXepsLyC3neje2lSENEYwmum26xQfOf+d4zikUXXvjWA7wRqyMprC/zWF4aTGUtQV/sBkB9PbogYpnT4OUcEHEwALfrakhihjO3/JzPJ6QzerFRk4Enpk9MIQCQin2pFXryccvmSE50iEUIsYQI5t8zsQmj1VHzlCBhz/7XBPYQatRAUZnvLNiZlva+UwDm+HgwaVovK2XkDSrybizUaCFZQ9Cf6ccAUfQPsnmwpotLMbZ10XodVR/X6ASLWk3oWvu7Kn9fNBMxKs9oe56pjq7Ly9QqIRH18sIgTf1VyIcmBp7gsfvDyVA6nXu5m3PyBSk86bccpFFw8T8V0Tl4O/bxiH5ldYUY9TiRDFG0Y6R/xFCQJ4loS9WK884oeb/Ix12dFukEZC6on/p0p9BHs9eo7TSKweW0GxCO95R9KpRJoM9sTjJ2O4Xormqk3/le4pEB7QjjbLA+lMXXHmf2OKNOccanOq+j+rM5LALMuyKbQ2x6VoryaSOY/W6kSvbrlFjxeb/jLTa0N36D1iqIzFRb5TcMw3QrSFikbTcaDBIBI5bX+ITJ48cpTD39stGYWyTuPdhL0Lqm2K4Z8KeNnx4wQP YhorkPjY wej/lbeig0iMHuALlaFos0DHxKigtlohIM5oydc7SHcVSbnMQVfYxvyDdECVSRHfbN5X/eQIBIGf0vGv0P9WEVfVwfpwIoGWVbE+lmm0326EN+8FQ1vwtrAWFWIs8K3PeocSLud9C7/KIOUXiVGKbVykeEaxlBjLX2Or7I7XMSPJMHq062p9xoBRnBPRA4GijZaCLr5JI2625PtA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 04, 2024 at 11:03:42AM +0100, Alexander Gordeev wrote: > On Tue, Jan 02, 2024 at 04:05:31PM +0100, Heiko Carstens wrote: > Hi Heiko, > ... > > > @@ -253,9 +253,17 @@ static unsigned long setup_kernel_memory_layout(void) > > > MODULES_END = round_down(__abs_lowcore, _SEGMENT_SIZE); > > > MODULES_VADDR = MODULES_END - MODULES_LEN; > > > VMALLOC_END = MODULES_VADDR; > > > +#ifdef CONFIG_KMSAN > > > + VMALLOC_END -= MODULES_LEN * 2; > > > +#endif > > > > > > /* allow vmalloc area to occupy up to about 1/2 of the rest virtual space left */ > > > vmalloc_size = min(vmalloc_size, round_down(VMALLOC_END / 2, _REGION3_SIZE)); > > > +#ifdef CONFIG_KMSAN > > > + /* take 2/3 of vmalloc area for KMSAN shadow and origins */ > > > + vmalloc_size = round_down(vmalloc_size / 3, _REGION3_SIZE); > > > + VMALLOC_END -= vmalloc_size * 2; > > > +#endif > > > > Please use > > > > if (IS_ENABLED(CONFIG_KMSAN)) > > > > above, since this way we get more compile time checks. > > This way we will get a mixture of CONFIG_KASAN and CONFIG_KMSAN > #ifdef vs IS_ENABLED() checks within one function. I guess, we > would rather address it with a separate cleanup? I don't think so, since you can't convert the CONFIG_KASAN ifdef to IS_ENABLED() here: it won't compile. But IS_ENABLED(CONFIG_KMSAN) should work. I highly prefer IS_ENABLED() over ifdef since it allows for better compile time checks, and you won't be surprised by code that doesn't compile if you just change a config option. We've seen that way too often.