From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41BB4C47073 for ; Thu, 4 Jan 2024 10:31:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEF026B0254; Thu, 4 Jan 2024 05:31:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A9EB46B0256; Thu, 4 Jan 2024 05:31:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 940476B0258; Thu, 4 Jan 2024 05:31:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7BA836B0254 for ; Thu, 4 Jan 2024 05:31:40 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3EA784038D for ; Thu, 4 Jan 2024 10:31:40 +0000 (UTC) X-FDA: 81641262360.30.99B0176 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf30.hostedemail.com (Postfix) with ESMTP id EC5EE8001B for ; Thu, 4 Jan 2024 10:31:37 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=V2d40fYB; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf30.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704364298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0rxushcfZyl8L0hy6S9Km4lGh2/dzw7ZO9lKAm8opZ8=; b=wmbIDXQ1RHOlGBkZ1N4t6S2vQoPVjgn1BSPJKhP34cIvc9uq509Qq+vyfn/fAkEGjXU65f 62f0osPkdLNOG0iQ2C6Qru0m88OS05DtGLu2ezM+y0Kdghj9Tij4SfhktJpASxbSNxK3m3 AV3GoOFev7QLFP0HW8Y5go2NHsSpkvg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=V2d40fYB; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf30.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704364298; a=rsa-sha256; cv=none; b=q7SSH/JQsMsaUyeQOKxaFiMb4DueIk35QZVRzF0m/bJRE3aU9xNaS+0P8SF4DJbX2NC6dG c6w8nYi0kiKSt5BZPcEoNw75zvWDBh5KdOhfsfk6yVuuCF9F4qOA9JF8OU1++chxjdwQg+ Q0Kms7Jkrbj09W7R+CdRQL0OJw9oui0= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 7C1B540E0202; Thu, 4 Jan 2024 10:31:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cpt72dB3zF74; Thu, 4 Jan 2024 10:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1704364291; bh=0rxushcfZyl8L0hy6S9Km4lGh2/dzw7ZO9lKAm8opZ8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V2d40fYBXLsjiwgw88xJEJal0iK5jhfOdiiW5CFmq7CsA30eB3UEH5tslaIptPYHx AiKsFb6HXIdUELKJTNpqrJ+OtNud5zqyBzQO12LOoH6NGEzs213S/tk5v/52ynLT+d BMUbP6o8Hi5BWVifZygd83cULDxVy73O2SgyQiBLTg/+hDTkamGbeymlReg9rcHoE2 qb0hcW/GpP5dnDESmgo7cEDUG5p9xnZrGBlZk/BzCIXjhvzIKEkQmTdJsLz2hR9f5Y 3e/8k6phnvZM8lA8qSM7zaOWOJp3eL9Tc+otbB0CH8PvK46AXOGxw1FN1ZCd2oaGD7 indn2kf4LREaQl/JX+VTc0TLlwQNTp2WyLiBjla+Bw720a4k9qAZa9W7O5cQQKgwp7 3HT2ReBRVycQg//veJFInytfO5HSRvVRcuJbA0MPCcLvSvs8oi9YMpQ4q1qn0bzL+5 2UximNaMGXpHLlqLvXpeC2zshznqUwr9JofQc+LA8WBk+mL2P6pNm7ZxUHu8VyYs0d fc9TkDWvo4d7PMa4lnjQcWjHYn0Sf7srHrNS7OtjNQd21AGPYlE3GKV146o5opcokD 0FvC5c4D1ZHKr5ycn1wFc1eWC9g48Qqj6QE89nWfm6ewVFLsyBNsoFSTzvr+7wDdPE uPUiPUyJWMXVD9UcdHdhHnFY= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id D2A6C40E0177; Thu, 4 Jan 2024 10:30:53 +0000 (UTC) Date: Thu, 4 Jan 2024 11:30:47 +0100 From: Borislav Petkov To: Michael Roth Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com Subject: Re: [PATCH v1 03/26] iommu/amd: Don't rely on external callers to enable IOMMU SNP support Message-ID: <20240104103047.GDZZaI11z9Htj3XS/P@fat_crate.local> References: <20231230161954.569267-1-michael.roth@amd.com> <20231230161954.569267-4-michael.roth@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231230161954.569267-4-michael.roth@amd.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: EC5EE8001B X-Stat-Signature: 8o99ua4idoummhz3b7mfotybs1fdzgoj X-Rspam-User: X-HE-Tag: 1704364297-115079 X-HE-Meta: U2FsdGVkX19jyvzm1YCRklQmtsSXUG9QlYMsJYgwV0mcoq75VmCr6B6dyeqAmOdRxcqSEiiHciJj1CLhvO7zQ3Li4OgUaZNjJ6XogtmUl/Fmw1bOxxLupLNx3v8qQ3tjawrUcDi25XSrjEjyn+PExSJdfCy3NPEt/ls8h6YFSxRmMM1GHNLhLADZAMB9o333BoNbHyc0VG+m3TxZU8yu3o9WFNWKfogz7v/fLNzHtqkYf/7ljJ3OOiSEUTtYtxeWkTuDA1TXBhiW5dVlnG0rky7hPFau4b7FEXL+ltV7PTf5wCPIjfGFinyVNYTPKKJY81rtHKYZhzKF6NKNBP3vIM8DyVQFW3g687TRZXJZdwgeu+uToC4C67DO5DqOPbtIaSz6ojQh1s14P858fovhoU1N/3D/oV+xbSuWuW8+Jwhhld1JBVR6TLk1RD7frRI2rId+KZSYUpsVITm9azDD2qrC3w6mevDnzlOFnsfULuwFiEJqaNrCCzMCyfCkpXq42DgsoEhbAvYUh7yViAPlS768aWGyR3i1wIeZrWmksRkIA+wdUnes21NH29MJ9tK2x05OSkTgd7Y/I3ddaRgJtwGY4cpywN0Ww13UlnY3/zY3XRyf4Sclchw+UvTlhe/gA4OToQinpm5J5bbf323kqZaSFPOcCM/QogajjINdo7WmWAPqMf4KNyWnA01ePGej4wgp8foS9qxrnY8OOAYKlu90p66EBVSDRfKLb9VOHl+2Y/zC5Y1Ma6xb7B6M694rU8trCFGiCK6vgJ4Ul/sRZvlYe8P8XRC+VyDr0LDqAsYQYgG3mo9DCI/zRJ9i0bs+QPjQnlvL3m57HMiigB0yiybi0srB75F4Cc4CaK7SKu9vu+ncdytWkaKV9No1ZKvMtw1+XuHRDM8nZIoTgGpnm4xjHthf/GzSycPYV8KM8aI/HYFpM5PCyIMSQ13kzK02X009wFOqN0ervHt1xYj i20E44Yn i28+qIo7iRnmRr4JVZRavpvI8wyRxIFGZKvAQNQ+Gq3+HRTnRPHMrElRhiwRRmLisqwcI9fFMMNVLC7ZRYyyO3VLl2GiQvRphd2xqddz1SJd0HZUiKv/C9BoGZ0ay98i2OJLQS/Tb3g0QebeFGCcg9yHM/Orl0mhGtepXSrv/IHDs+MpGSr7vTzO+sbk91OxnuQJDExkBIvTgMqY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 30, 2023 at 10:19:31AM -0600, Michael Roth wrote: > +static void iommu_snp_enable(void) > +{ > +#ifdef CONFIG_KVM_AMD_SEV > + if (!cpu_feature_enabled(X86_FEATURE_SEV_SNP)) > + return; > + /* > + * The SNP support requires that IOMMU must be enabled, and is > + * not configured in the passthrough mode. > + */ > + if (no_iommu || iommu_default_passthrough()) { > + pr_err("SNP: IOMMU is disabled or configured in passthrough mode, SNP cannot be supported.\n"); > + return; > + } > + > + amd_iommu_snp_en = check_feature(FEATURE_SNP); > + if (!amd_iommu_snp_en) { > + pr_err("SNP: IOMMU SNP feature is not enabled, SNP cannot be supported.\n"); > + return; > + } > + > + pr_info("IOMMU SNP support is enabled.\n"); > + > + /* Enforce IOMMU v1 pagetable when SNP is enabled. */ > + if (amd_iommu_pgtable != AMD_IOMMU_V1) { > + pr_warn("Forcing use of AMD IOMMU v1 page table due to SNP.\n"); > + amd_iommu_pgtable = AMD_IOMMU_V1; > + } Kernel code usually says simple " enabled" not " is enabled". Other than that, LGTM. --- diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index 1ed2ef22a0fb..2f1517acaba0 100644 --- a/drivers/iommu/amd/init.c +++ b/drivers/iommu/amd/init.c @@ -3231,17 +3231,17 @@ static void iommu_snp_enable(void) * not configured in the passthrough mode. */ if (no_iommu || iommu_default_passthrough()) { - pr_err("SNP: IOMMU is disabled or configured in passthrough mode, SNP cannot be supported.\n"); + pr_err("SNP: IOMMU disabled or configured in passthrough mode, SNP cannot be supported.\n"); return; } amd_iommu_snp_en = check_feature(FEATURE_SNP); if (!amd_iommu_snp_en) { - pr_err("SNP: IOMMU SNP feature is not enabled, SNP cannot be supported.\n"); + pr_err("SNP: IOMMU SNP feature not enabled, SNP cannot be supported.\n"); return; } - pr_info("IOMMU SNP support is enabled.\n"); + pr_info("IOMMU SNP support enabled.\n"); /* Enforce IOMMU v1 pagetable when SNP is enabled. */ if (amd_iommu_pgtable != AMD_IOMMU_V1) { -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette