From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 140DBC4706F for ; Thu, 4 Jan 2024 07:01:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A30A96B008C; Thu, 4 Jan 2024 02:01:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B8876B00AC; Thu, 4 Jan 2024 02:01:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A77B6B00AD; Thu, 4 Jan 2024 02:01:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 78E696B008C for ; Thu, 4 Jan 2024 02:01:24 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 43AB71C1209 for ; Thu, 4 Jan 2024 07:01:24 +0000 (UTC) X-FDA: 81640732488.19.9676BCA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf06.hostedemail.com (Postfix) with ESMTP id 594CD180014 for ; Thu, 4 Jan 2024 07:01:21 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GjYw5Pnp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704351682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4BuoMDfr8xNr98yXRW/o7fB7uCs9taDdfmDN5oci4lY=; b=zAnXtFjWF8RhaShmy1t156aTbzEjMc3W4UQL7q6ojGh6xyaWGD3a7tbTG/2DpeN8pVYwrg 1Ey3jZXYibRIFpK+SuPnvMdcPx0Dq0X8uh9HVJRB5a5zT8VvJmEaDx0KWvRaJKRCRXjBiY YLCLR2zL0kuD/dEBwck2pLVtlgfY6YY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GjYw5Pnp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704351682; a=rsa-sha256; cv=none; b=UZpqf+MKdArpN/5DaZfNs9NPALNWM1Ztz6smfU8fojReLU3pxfiVrRCWAr+b/vCxCd19vm 6WGSuY0DttWYf9EKRuficvrWskaquC4XcUOarCAsBlF4l4OjYlt5ARI32LQJGlgvs8sUmZ pZrbDPvjoEGiUKArbaRKQz3dJQkZ+Po= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A14DCCE1704; Thu, 4 Jan 2024 07:01:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8083C433C8; Thu, 4 Jan 2024 07:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704351677; bh=RqBhKWkFis19hqqQmUIi8WVLIMhvoMfnNJPLpNlMPlo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GjYw5PnpG4O4E8HKV0wMCADjEuC8FrX/hoUOYV3kmHpX2IKXh3WZ8grf3XETlzGjm Fi/OHpBNV1wI7IYWmXHTf0Yb3IycxDKUbXtT2NX+H0M4gUAQjNnPj3OehXuZF6eVEG rLhnvObOcq5uTvM8HcRc4MdQlv9a0lgFAjBjUBp2Rx4R4cpyrMEhK7unyP5YCILLgx UPnoPkwQslZll5z6wgbzUivDbtL86k58YKn+bT4vbKIoVVv54n80WXoyy2S/CowXBd Xe5hv1+U5N8YLYFpH954/LLXn+xGo2BU6AjZ0uYRGRTviELu3DeFmVCeyzrDT+L06H ErvIo/WtbiDDw== Date: Wed, 3 Jan 2024 23:01:17 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 09/15] xfs: don't allow highmem pages in xfile mappings Message-ID: <20240104070117.GX361584@frogsfrogsfrogs> References: <20240103084126.513354-1-hch@lst.de> <20240103084126.513354-10-hch@lst.de> <20240104000324.GC361584@frogsfrogsfrogs> <20240104062428.GC29215@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104062428.GC29215@lst.de> X-Rspam-User: X-Stat-Signature: hidz76kkjjj4rkg5edaz4ddg7krapytn X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 594CD180014 X-HE-Tag: 1704351681-574733 X-HE-Meta: U2FsdGVkX1+8coi2+GQcQW5oZbqLv7YfoUxDjltFF+ujhj69e98scOtMQ0tuD8mGsQfuqYWLFzwvzrJWoym6gRZvckNM3sn6BiDqJeYAv8vugJ279eaMAiaL3tSbr2XA/XKG5F8kWU0pstMtYbbtbGDLcq9/pTQwoJfPwAxWSX/2Zib7eMidSCFXZBOtg0aFaZA9cbgtoJn60JTrbugw/VIXD2soTVZQgntvv9aiNghHabKKuIZ683+5g80cmQj4JvTiyNZ/YqfASvU1aFrHwPEuntlqLcmJo8camyQ/LAD5crWh2DnlkRhlzJ3D2eSDrxBSloFJm4dmLWmkAJxv1PPrH4xgVBA2V+JFwbuLG/6KjQfOEnmWvLnRejqGjprHEiE2dsu2yGrioUJusyalAS8thcQbUF/kZ6tJ8pYuh/SmL3PKwXoG7fwYvXxl+wq/037qzC47givZEL+5FBk2OtAp6JE9YCa9XKf/9ktcA6Xtd313DVTBc1a53Jfoh23asiKFsth9KVR9DJaXHHOdC6j5LgaBX35Vxrf2ZS99rx4IFyveT3GTZ6SktYmjTb+wAYK7/5xz3c1AoE7/u3cubOvzoK612NIRHs7mA3kzSFcFpOVYoNHSFfTVhHmSl6umviWEz16WgHu+t4LxfRNsIB4VpjrjMcVL6Qns7tBI0/Vksrz/ntCTQ3z8IX3m8yPVaAKRxhZDP2iz2Ju3MuemriZVBt6yw6D3tXIA3cnyqfVFuLw7IwLa6n5+hXX4NAUaCQ7XLgAicAaHtn+3l0OrG6F+ZH8YxLtOKmsozE7JSBjiw8p97/mswZKJYLW358E4Q3QMYtnHrdmikyWq38r6G4drjxBUlNkBNPmUlL6XZ07hsLOamUZKOqA7J2q70e6F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 04, 2024 at 07:24:28AM +0100, Christoph Hellwig wrote: > On Wed, Jan 03, 2024 at 04:03:24PM -0800, Darrick J. Wong wrote: > > > + /* > > > + * We don't want to bother with kmapping data during repair, so don't > > > + * allow highmem pages to back this mapping. > > > + */ > > > + mapping_set_gfp_mask(inode->i_mapping, GFP_HIGHUSER); > > > > Gonna be fun to see what happens on 32-bit. ;) > > 32-bit with highmem, yes. I suspect we should just not allow online > repair and scrub on that. I've in fact been tempted to see who would > scream if we'd disallow XFS on 32-bit entirel, as that would simplify > a lot of things. You and Dave both. :) I guess we could propose deprecating it like V4 and see if people come out of the woodwork. --D