From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34B50C47073 for ; Thu, 4 Jan 2024 06:55:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F7616B03A8; Thu, 4 Jan 2024 01:55:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A6E26B03A9; Thu, 4 Jan 2024 01:55:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BE5E6B03AA; Thu, 4 Jan 2024 01:55:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4C5AC6B03A8 for ; Thu, 4 Jan 2024 01:55:20 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 041868053D for ; Thu, 4 Jan 2024 06:55:19 +0000 (UTC) X-FDA: 81640717200.06.88BF092 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf25.hostedemail.com (Postfix) with ESMTP id B27D6A0002 for ; Thu, 4 Jan 2024 06:55:17 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N6TRl8Fv; spf=pass (imf25.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704351318; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rFBPwOWp86iS3aHOGGRGQg0L17RaW3TkptzWUHUFCyc=; b=K6hWYJ2Jr87r7CXWhqPROxyn/PJ8a4VexUrSzVSkiDatRM0RqAdJJxu3DMZrRHPHaTArW6 MMUqQX0aVGKkv1brL52V5TUCUlEJV/8vlqS5j/VBeVufdjIlBqxI/87CG13drjvbz6xjLX kZsxMiJJ0wrHoGc5C4l7tKn2srGRrdU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704351318; a=rsa-sha256; cv=none; b=FH2DeqGFB/PPpMn2a4mBEvoXCJ4PNtmypUUeSV9UN2vbzKzP3hwiWvndYKD0P2Dbq8MWa+ hrZw85NWqlfN0++SpV5H7778mjH7kg+QEUWFaEZuQhD3iB8PKn3tiGYzd6hqPgRis+eOBg gI4TokvGfzRDikgL2mGt+wYtYErRoOM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=N6TRl8Fv; spf=pass (imf25.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 2F91CCE1704; Thu, 4 Jan 2024 06:55:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65A01C433C7; Thu, 4 Jan 2024 06:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704351312; bh=GhliB2+i6ivMC5eLBdvRqy6WYTaYt0Dyon9VLhK2D14=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N6TRl8FvrTiOGd9V/6/KmHjpvNJoLdP8TzonR0zpkWnJu5qgQFb0O++9S7GQhbknt FcutXGeF/y2kMPJnd8kbXb/irRUbwIWVysmTMqdDK+viHVu8gG636/yonjfnitQCwJ 0XSbce0yXBjZGa8DjzjPs05payeXefkW8J0xeLEAmCpjw1d8O4vbYnbj+iC4N9W6Z+ Qt9SzDvvlF+JRhl7cv0sNDD/zKUQ1yZxdY9eD6kv+dL9ezW1cRoN4mfoS0aCwCUjdI SqyxxA+nwZN9x8ZD315/hAVNOn/3oideA74P8jzn7uvcC72/i9NTfripVPJf8EAV9v /IoRJVcsCaUlA== Date: Wed, 3 Jan 2024 22:55:11 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 04/15] xfs: remove xfile_stat Message-ID: <20240104065511.GV361584@frogsfrogsfrogs> References: <20240103084126.513354-1-hch@lst.de> <20240103084126.513354-5-hch@lst.de> <20240103234533.GX361584@frogsfrogsfrogs> <20240104061415.GB29011@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104061415.GB29011@lst.de> X-Stat-Signature: dz4cnz6wnjtqy3mcut68wxd8k6ufms8b X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B27D6A0002 X-Rspam-User: X-HE-Tag: 1704351317-30706 X-HE-Meta: U2FsdGVkX18MOnBKDcA9RoRaO3JZoy7nNlXBjIbmYg0xhZifCAxQmoevlI2ytn8isuOuMD1/WzcUPjf3VqMGdwkTOpKNVKlIm6oQi0wnvvhV4PiMJXLQqdy5y58TyCec5KNsQ0RGfy3PaN+HoV2kR8hTsDb0I/uv2O1mubz7SbhiVo1+In3peVLdw/FJDzCnnSuxEVNM3cQmO+GtVrTPLqIZlxo/W67TyanxJ+IXZZ1z0tVyTE7L7QJVqTmD8XYapiM0r1/Xk1DOK+5h67cBCbyvTSiB4v5cZUP6YNf4i1YD+BR0A3d9KNfZSO27CN0RqtifiaBQriFbY70jFs8SvcpbvSwh4CbL/6ZmOBIBH3q9SaD9d4YVX8TMfK2ps9jWNkVqAZ2QgjLhl2XX8W7htIGSZlY34NE0lVJkTa1PyPL5B5W329jHmnJiLqppAGKIhrrTiZyD3pTj7mZ4H+0/3LYSZOw2xzCV4UhcwYhrG3Cw7op2rfKjIdTepIydrYTOQmquOQvyBgnLwwnjP38s6aBRFFjFbcVUjYsvB/6fdwY+Lm3QDwUwzHmZIGLjyJ71B0xPG6CNLJAwafGmuY2gnY7HO1EiY4yL1C8u6NX+5kzsBZDFa/B3PINpWXZV2bS5yOfmxQICFps6dkXDD1ZTfuvVhVBZ8MF4nSWKc1V6ejcWq9zxx3Rm8WuEqO56hxRGC+pXHqSjesqZg/3ceCBz4t5fDw7I0scEvcLQf25ShVIljq6VPz6/qgwMJyF/5XDwafjHYXx0FO6gS2xhUpSEjCPGrdgzKZQnSeKWxUuL0CiXYmRCCHoxY3uCEJ+RVqaafiJjjFwWZCzXk2wTsNYbDQHzylzMHJmS9fv3hY/Y0ALfruIjijAh+xy4n++dpIo/2pFe95QM/hwhVQaW+xLiqWQvSq8PQfexI29mtuyI8pN9GzN0vPguEzdygK7NjDhtBYzNwAayiog1wcc8bJO /3wzWl7W mo/sA+yle8+kbXu2IWU2Kk7Oa1nj6CdmeaN05PyVtKSGKEfrKvxlkHqe/y3Rhr6kyROTtOb7/temdIumVZLai3B5TeyJKapPGrNrQE/76228hQTZEyfb7UeedOzdNq34+m5QXkiolQvKBtT0pc3MprrXXUHUP6R2Q9d0zhn+g6wkVXcKP3BP0YnBsa4loTr+Ycwi22YeG+wAP4bVD+saBYCgJuoVaVLAxGVO3/GQz+ZqJtxs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 04, 2024 at 07:14:15AM +0100, Christoph Hellwig wrote: > On Wed, Jan 03, 2024 at 03:45:33PM -0800, Darrick J. Wong wrote: > > > + __entry->bytes = inode->i_bytes; > > > > Shouldn't this be (i_blocks << 9) + i_bytes? > > Actually this should just be doing: > > __entry->bytes = inode->i_blocks << SECTOR_SHIFT; > > The bytes name here really confused me. Me too. It looks like some weird way to encode the bytes used by the file using a u64 sector count and a u16 byte count for ... some reason? XFS (and thankfully tmpfs) seem to ignore all that entirely. > Or we could change the trace > point to just report i_block directly and not rename it to bytes and > change the unit? I prefer to keep the tracepoint in bytes because that's a little easier than rshifting by 9 in my head. --D