From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB482C4706F for ; Thu, 4 Jan 2024 06:26:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 224196B03AA; Thu, 4 Jan 2024 01:26:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D4126B03AB; Thu, 4 Jan 2024 01:26:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C3776B03AC; Thu, 4 Jan 2024 01:26:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F22986B03AA for ; Thu, 4 Jan 2024 01:26:30 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C5498801CA for ; Thu, 4 Jan 2024 06:26:30 +0000 (UTC) X-FDA: 81640644540.16.B53CDB2 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP id 3B25780006 for ; Thu, 4 Jan 2024 06:26:28 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704349589; a=rsa-sha256; cv=none; b=nLXHl+cD86YJxYG3RmBK6AY07Yj8JTJRq0Ahd6nxCQ+mqrh6wThFeGG6ly+D3dTxV8xdEZ 0Z333Gogo3GzB6XGh6IGumJl5L8q3ZMbapOlRwhSfa5gwiZH/0H4PYSMcn9TxeK7JTUy0S LGjD2VZqju9fQe0MByspiEMx9MolM7Q= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf02.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704349589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tIUBisrgChMhCSJQtE0237pDcFMrSjBa78FhlSCP1cc=; b=RwtjBAAQN7xlqCSeqGsLxjy+vjvNmWutZd6wEKGlOno+pQS8ZaBHOCGDNxsnwTGz7ygq6k bPzDmKQq7kt+38qdYvSXfEEkxzVrf7CUpWTlnS52CL4snKekw6l3oqof+xu9WMEmcV6WgA Iy0KOhxQmgFBgO65TknNlvEbcrxuMQk= Received: by verein.lst.de (Postfix, from userid 2407) id 667EF68AFE; Thu, 4 Jan 2024 07:26:26 +0100 (CET) Date: Thu, 4 Jan 2024 07:26:26 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 14/15] xfs: use xfile_get_page and xfile_put_page in xfile_obj_store Message-ID: <20240104062626.GE29215@lst.de> References: <20240103084126.513354-1-hch@lst.de> <20240103084126.513354-15-hch@lst.de> <20240104002024.GH361584@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104002024.GH361584@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 3B25780006 X-Stat-Signature: z5d1o6a4p6iejh8xz1e4nptfzqgsn7ro X-Rspam-User: X-HE-Tag: 1704349588-268450 X-HE-Meta: U2FsdGVkX1/nMdGb5OSek3U675a1OqCyhZzwn+Cf/Q9oUGtRVu2B2hgaBU/vplon5cZGVOMricBzo/1HMSr2X62OmVa4X8DrTaAJ6kB1HkWoV7+Os1E5Ea8/GO0jOr1DN1BmoyHeUAWisAdMJfvy6jcPvU41Le2usdlQKM3BRDwVgpY5bXOz4pnta5Tb/88Oyw+6ipDYUVNtz4v0BHRQdxJtH1AUt7tD1f1Iideq0u1EwuI/YozSF3iIPhtUk4+CVtkaeIesnL6Zm/lrtbPZnCxZeqY1BT/8SVeHt361Ss8Mrs9zye2KeqgwSiFj40+YHb4cazzYlWYJS29Z09XRbPUHNtvsG4s5AgMjjvvAzPstgsUKgfS0qznn++A5e0rWBgHJOxqMdqKMeLV0CieW8Uk4bLZfmy+qPDNtS9xC5Wo6I+tW7gV2hldzA3QoNEwosSzOcNJ6UVBnAomDn0Rv+3J3YvbemXi4yEIUQ/V4aaa0lDe294G9NRiq7pla2AtpGvfC4F50HcKVcMKxPMsXYYDwdfDA4V1PNf4afhonevwbApd7Y4hR/K/Rq2xvZAg1+TXieUoTfcuCj5oioG7e7ZnpuRYKn/4ERXZpT/J2bFneHpzWBotBxlTXQvExhmrJNc9JH7MSkpmz458cuhqr/K6BB20Bi9fepSJEVDriYDPgbx30Tl3oqL8aocNwIx3SOjv++1VxhBkNyRDOj4q7Ou79+Kn9lBNpfOXRqbwvPW8SMK7nkcj2KGm84ZrPZqDqdEaQwrD0KAmivjKuImz9MDK7BZSGIm4s X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 03, 2024 at 04:20:24PM -0800, Darrick J. Wong wrote: > On Wed, Jan 03, 2024 at 08:41:25AM +0000, Christoph Hellwig wrote: > > Rewrite xfile_obj_store to use xfile_get_page and xfile_put_page to > > access the data in the shmem page cache instead of abusing the > > shmem write_begin and write_end aops. > > > > Signed-off-by: Christoph Hellwig > > Much simpler, though I wonder if willy is going to have something to say > about xfile.c continuing to pass pages around instead of folios. I > /think/ that's ok since we actually need the physical base page for > doing IO, right? Well, as mentioned in the cover letter I'd much prefer to return a folio here, but we'd first need to sort out the whole hwpoison flag mess for that first. There's also a few issues with the xfs-internal xfiles interface that need attention, but they're solvable.