From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE54BC47073 for ; Thu, 4 Jan 2024 06:24:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A35E6B0310; Thu, 4 Jan 2024 01:24:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 553506B0311; Thu, 4 Jan 2024 01:24:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 442F36B0313; Thu, 4 Jan 2024 01:24:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 323E76B0310 for ; Thu, 4 Jan 2024 01:24:35 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 06C9E1A017B for ; Thu, 4 Jan 2024 06:24:35 +0000 (UTC) X-FDA: 81640639710.21.22CD460 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf28.hostedemail.com (Postfix) with ESMTP id 7C9E2C000C for ; Thu, 4 Jan 2024 06:24:33 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704349473; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6qckOpFXxzIjyATNhN7kkaKo1Rn+un3wDe9lat9+C1U=; b=GxNbt03w7LI9AS0T0QuAY9oH9W/rMGiG9JVL70gQdx/Ps2viw6ju/mANvhbNqJ5eCKK3jD Oyy5TI/rK0kfX5ATU4Zd7gyDQ2vB59MKCTiH6yXRBdU2DijS1JsQznL8c+yGB5h5+TWAQz YHAUVtQIKjf67wXdmnKQMVxd6Xy5Nkk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704349473; a=rsa-sha256; cv=none; b=xpzvrNmwXlJMXMb0p+TIGgDkI+ADXTxWPcftc9L5Bj3uEf7gHa1vYRFWrnEEl/Ey24dysr kjIUS4cENdvo2+XQrgpoXwm9VPAvSCl1VMpLhLlMpXLfzfcchdaPFPo+c2AWaTJw1h72h9 bq9RkjMPpTbDb/J0QN0LMnTH/Y+cH4I= Received: by verein.lst.de (Postfix, from userid 2407) id 8921368B05; Thu, 4 Jan 2024 07:24:30 +0100 (CET) Date: Thu, 4 Jan 2024 07:24:28 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 09/15] xfs: don't allow highmem pages in xfile mappings Message-ID: <20240104062428.GC29215@lst.de> References: <20240103084126.513354-1-hch@lst.de> <20240103084126.513354-10-hch@lst.de> <20240104000324.GC361584@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104000324.GC361584@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Stat-Signature: e9nixtaiwcf1m5z1hndxwjhji4cpdqnf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7C9E2C000C X-HE-Tag: 1704349473-76313 X-HE-Meta: U2FsdGVkX182mwAd3LwSkgkPHszbn7/McvSFjexoHVu8HVk7oVN7RsM1JwPjIkUFX9O/j5Z+cd5a3sZJQHW024oqs04wnJUWYZxuGz4R/CgPNZ32I1FTqbh0zdkOXsTvVAG/fqJCYy45869pwSXhqcbpDYmh0O3o78SDRQI/M2XEkBLH4EEeriO5A9j8hdkXaIL/uRG5xhTn0OjjB+WNMTo6f/pl4RpFjT8/9GhIhDZ8m1wHqAW30zKpBjdHrpRtws/e6BFiv9WqqoxmR3WUpPOCaptamfd3Jqh8/PWI59dFjthbLmc3/9VL6RuTByWaToHH6WPAxX/+JNYZu56p70ADy1b4bZOewcXFgV1bbDBZ9QQ4mhpHQEFxWraSvSS3xk8OwYGxUSBaG2C35S7uCRAhBAVpoW4U+i4gPAeZYXWmI2HZq+cjCPVVf+Xb5m2ZJjSY3nRLk6ZDTqwCfUg5KsD/ucM2lLGRlOI9llpyVjSGgm5QKq7mbsWdcB29Sfc3y5vI2WyHbG/rh/tCRvxdiXiugZ7wpUPE0YPkE1CtA6FAxRQ2Hg07+RXHxmG3rIfoJOpLk2SU+ZMr2tCvFPRBJjmwPAb6SlYRknn3AIHVdxfGMck3+NKyjmRvDbd/m/IVdOdjTr62/pJLVcTw0fXVTuWreNFABNh5ZUJHwBMhCLDpbklHQ95TR1A6rNujElRTJ2Tn1kZ1zupdQIlc1fvvtiqzMU9Odo24y85aYn+dbL0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000101, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 03, 2024 at 04:03:24PM -0800, Darrick J. Wong wrote: > > + /* > > + * We don't want to bother with kmapping data during repair, so don't > > + * allow highmem pages to back this mapping. > > + */ > > + mapping_set_gfp_mask(inode->i_mapping, GFP_HIGHUSER); > > Gonna be fun to see what happens on 32-bit. ;) 32-bit with highmem, yes. I suspect we should just not allow online repair and scrub on that. I've in fact been tempted to see who would scream if we'd disallow XFS on 32-bit entirel, as that would simplify a lot of things.