From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2612BC4706F for ; Thu, 4 Jan 2024 06:21:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 727288D006F; Thu, 4 Jan 2024 01:21:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 687F58D006C; Thu, 4 Jan 2024 01:21:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5289C8D006F; Thu, 4 Jan 2024 01:21:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3A5EE8D006C for ; Thu, 4 Jan 2024 01:21:08 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 095411C0FE5 for ; Thu, 4 Jan 2024 06:21:08 +0000 (UTC) X-FDA: 81640631016.11.8371398 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf27.hostedemail.com (Postfix) with ESMTP id 48A8C40006 for ; Thu, 4 Jan 2024 06:21:06 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704349266; a=rsa-sha256; cv=none; b=hfYIsO79n/iEO1kc55mpiD52XSwgz3ZiSxsEmXoJ/1fNv2mw/h4ZyA2bGdiC9FMn/7YztK o4XJ5IjpwG5qZptzZiiYuF3bHTP7LEvnPIUOO46gKR71TIUrRcTx+Tjy8Z3LTWqAhtUkl4 vmGrNRgKwzuRj77gaPmku6++z8hayws= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704349266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wqfphJmYNkgs0IE9ZJhKcorezyBU7pOggxWFwp/TKz8=; b=A+9I/ykY7wtTntIgEmNK4p3ItTtbwsUkqqFM6+l0i2DLvuEzw9dAq5adO8XP5ycFbP3hOa wdtHDQeEXi5M4cLRzgCMLxODjNRJgBqnA30QSskQkYUgpwgSodcFE0HBNoM3uNdAEhp99M f1n1OBKYav8EuMPE1WerIOcqTrWER8o= Received: by verein.lst.de (Postfix, from userid 2407) id 94A1B68AFE; Thu, 4 Jan 2024 07:21:02 +0100 (CET) Date: Thu, 4 Jan 2024 07:21:02 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 06/15] xfs: don't try to handle non-update pages in xfile_obj_load Message-ID: <20240104062102.GA29215@lst.de> References: <20240103084126.513354-1-hch@lst.de> <20240103084126.513354-7-hch@lst.de> <20240103235538.GZ361584@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103235538.GZ361584@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 48A8C40006 X-Stat-Signature: 3mhh5qqcxxnmqycmxysszs4jbize5zfa X-HE-Tag: 1704349266-324724 X-HE-Meta: U2FsdGVkX180UMFEQVl+13YBv3zvefZymN9MsTW0Q6b8HFnD5NEKJ4eXqAioI2MyXwqYTzUE4AIwDlCn3W9Q7iq9rinGVXnwEAfbKXCL25Y/KtYrgnqDNP5TlE5hL1ELgx/gYdB1kiK5dEXvm9sqXCPqZZ0Zifxt1eRiVECnR5VMmu0EApYat3icVUiyvsD/BmwV3BLSumkslSIAYRTrnz8yd82cLZykn9PNom5jq1AO8pR0FMRLxn42K8vHjrQ2HYgNQIK76dPt2sbzl0lVIpzEDpIPBY9wZy/5dInOUMHQbG3/Ixczuuc6BWHOgahJ1+T+4lMluXnjCpL9s9EBrjMpnNwruwF6r+dx0cDMr8buJ6WdTUw98W9mr8oi8ecW+0v3wBV0Nhr1hOF4BpSN1XGGyal73d3eBflBp78fk/PU7WQKvRJjs8DVhKz7rr4mRFxAK4VMwEDx8GUrDa6JaMgB6Wz1gZ2/i/lQKzCzS9ib1HhFvC2cb+xX7Z3JqM8cvWQKI02SHqmlQW1N2IvTjM4s/JzjcW8L2oH8ByvTdO6RsxoIaVQSIFEDTnL/Arwrj1EWyw8DGFvv/C5uWAx5QCu8Axy1stnXCdqQNGn4C6YHpPURSsUkZQQmePfmn35OVi7rDzU8quAs91EgAv+/r4PkjmeJFi8foccy3mALPnQaG2mhK4M8Ai6RO1xNd+UB81PO+lwi0Y974eB+BXtXoExBbLEw9xDzEJTWGBKBcKLbx2KdR3uFuhtObNsncvtn791bjFgEKsOMzQXC7HLxVAtcR3/H9Os7TNPhYcicBWQuAP5kEvqZIboAS55wbKg1B4FDtcqgLQ55kMfgpHoc1nsTucU1hOsH/zbiEYMWs8hyxG+iSTZoDM6EJ8SetHCpeQRb9VxuOa4twNkRN1lVXNzi+R7TMXvLEl3C/rMfs7j1ZBPjdGoOsTj6CwShMPfn4Somgdi2CpwX5BeIH/0 fHre1tMK yke0OWmdFVkIg2vC8BY7/g2x26sRtZjFZzZ96CX3Xss3XJTQ25XU2usPTzvkGdG54ba4f3uE1hB1L25Dr62bRkAolgqtnHC7GabWBykESw97b3/k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 03, 2024 at 03:55:38PM -0800, Darrick J. Wong wrote: > On Wed, Jan 03, 2024 at 08:41:17AM +0000, Christoph Hellwig wrote: > > shmem_read_mapping_page_gfp always returns an uptodate page or an > > ERR_PTR. Remove the code that tries to handle a non-uptodate page. > > > > Signed-off-by: Christoph Hellwig > > Hmm. xfile_pread calls shmem_read_mapping_page_gfp -> > shmem_read_folio_gfp -> shmem_get_folio_gfp(..., SGP_CACHE), right? > > Therefore, if the page is !uptodate then the "clear:" code will mark it > uptodate, right? And that's why xfile.c doesn't need to check uptodate? Yes.