From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E785C4706F for ; Thu, 4 Jan 2024 06:15:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B40C06B0307; Thu, 4 Jan 2024 01:15:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF0D36B033E; Thu, 4 Jan 2024 01:15:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DFF16B033F; Thu, 4 Jan 2024 01:15:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8F2226B0307 for ; Thu, 4 Jan 2024 01:15:48 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5E1A31C0F71 for ; Thu, 4 Jan 2024 06:15:48 +0000 (UTC) X-FDA: 81640617576.06.72105EF Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf09.hostedemail.com (Postfix) with ESMTP id 9F45414000C for ; Thu, 4 Jan 2024 06:15:46 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704348946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QDa+aqXZTWkHAwtgeJlsPUZq6+0jxFswCY1ZuXCAfsw=; b=gnNfF+xFyXBZd/8KgVTqnmZo4WdfCsx5Xq/hzF7YA3BbObWsqF35YJJIqtjhwkrC9IE1X+ qv04DwM4Ld36AYlTPJSaM+mJsdqB5evFMihAw/IlvIZ4U9GnjH6YmROuzvGB4Xmu4UGMiF L2OLB+9axHJy859jI7kJSiQhNPH9VbI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704348946; a=rsa-sha256; cv=none; b=dZ/b9O8UDLShxe163szksRHfaiJ9bQIgXwQ+D/6atf5J7Ixh3xcpNUjbxRrY9Ni/v0xrWc 7o+ZfVNYpzfUjmA0Md8n97kN8PUF3pkCMQ966AK0cqmncVndrPmFhrYgJUwfoN6eXH5Da7 Gd/4+jKawfjCAKx9ThcaHG7jyVerhcY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=pass (imf09.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id 4B9FC68AFE; Thu, 4 Jan 2024 07:15:43 +0100 (CET) Date: Thu, 4 Jan 2024 07:15:42 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 05/15] xfs: remove the xfile_pread/pwrite APIs Message-ID: <20240104061542.GC29011@lst.de> References: <20240103084126.513354-1-hch@lst.de> <20240103084126.513354-6-hch@lst.de> <20240103234849.GY361584@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103234849.GY361584@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: etu4ybno83rmd971nt3ae115ohonb851 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9F45414000C X-Rspam-User: X-HE-Tag: 1704348946-141240 X-HE-Meta: U2FsdGVkX19XXrQqOthbvrm1XuFxhKCw3DZ0uvzMa/CatayKrzY39F5fnjzKUOfisUOKDekUsiR/TrMXgnhNTjnKvpVxWyYDdJS0pjEr8IOc8Tnqzm+XGvfo889AA8lP7miDE05ikk7nj7csyprbhF/aBlk9XmoKH0EsmGgVQM8zhHawIOGzHBcLBo5aSH1fVyYdvkGthFPw9Xe4GyYISphvSZdgg7NvRoHWoIVhj41oldFUm5+h9cU1yR2kShH0thdUTi3fb1VWEPrazC15lAJM/bd6xzW8wvYy5d0q5n5tB6pOetQyckguUP7sSc5plJ+l7g6PZYoXQFqaSWbHLQSLdaKAdgw4ATVONRseuhByiY+xmhGyMHbET+7fmjA9Zf/wpQFvJ+oOQvFr37GMTgt39TgW5Iw9B+NzbdXOXh9osx71FpCJrs3+q2t5i6Ju+jDH9nIk8V5Cgawr3XkS2AXqRw/lRnOsjIpE/cBfSZtoj1z/5aYNa6AZGDYaTiCPpMz4oIVF6I7gUjUesHP2P6C8NvLuavgQ+Fob//oSuMmX5bKBtfAJmSHF/f8u3NZeqyOXjZIsuQtOb6g8gGtQeKwHg7W0FxzIlxED2Ooyh+Q8xPpcGs+y1cslQYVLmUOYimfs/RC3CjAq7blBTfQuhCO1khklvYz3n7nKsEfXLPXiYCROPDVgH49EwM17Wpon2j+bvBTKOpWWASWWXLBxJXGWDKf3P3FC+uxyrELok9RWpmVxOn0i4quc8rY3lDI6yYSFCWJedUNl5c7u9L5S0FWlABpKuZ42M2wggI3HEMBFJlOHi5dzNEDO75qGFoS5pbmzUrrrG0mIN+34+oN59TxqFV45RPfWAHDo9vfQV53U6kYYPB6BswAGyLniH2gqma9qUiXN7xkO42HP7w4vQJz3LuRrSqKeY7IVpppvPhk791feFU2zZ0eemG2o2519PbqWo1Pl/uvdgG9PYxx rRucVcK5 DHna1gajiGIXFqvaBZemqcYqJIZiJQrQC5tErOdXGb4q/8zbFaoyG6qQLeuP2wSmmIxlfvesWZgcd753OSd3ztzG6vQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 03, 2024 at 03:48:49PM -0800, Darrick J. Wong wrote: > "To support these cases, a pair of ``xfile_obj_load`` and ``xfile_obj_store`` > functions are provided to read and persist objects into an xfile. An errors > encountered here are treated as an out of memory error." Ok. > > -DEFINE_XFILE_EVENT(xfile_pwrite); > > +DEFINE_XFILE_EVENT(xfile_obj_load); > > +DEFINE_XFILE_EVENT(xfile_obj_store); > > Want to shorten the names to xfile_load and xfile_store? That's really > what they're doing anyway. Fine with me. Just for the trace points or also for the functions? Also - returning ENOMEM for the API misuse cases (too large object, too large total size) always seemed weird to me. Is there a really strong case for it or should we go for actually useful errors for those?