From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A4DC4706F for ; Thu, 4 Jan 2024 06:14:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39F2C6B0129; Thu, 4 Jan 2024 01:14:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34EC66B0131; Thu, 4 Jan 2024 01:14:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23DA06B0136; Thu, 4 Jan 2024 01:14:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 12B136B0129 for ; Thu, 4 Jan 2024 01:14:23 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DBB0AA0374 for ; Thu, 4 Jan 2024 06:14:22 +0000 (UTC) X-FDA: 81640613964.14.40056CE Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf07.hostedemail.com (Postfix) with ESMTP id C8FE940015 for ; Thu, 4 Jan 2024 06:14:20 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704348861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MRH7KLgXQyaRbLHc3PS5KdlP/ZXIrCYhc2pw9Aa5nVg=; b=vfPZlff75brvGpFuW55mfWYgUJAPM67xWk9Lj9PFF2INTKfjTG+IkG41dV7n0nNwGoQdFW W+Hk4JtMWpk/ESZq/Ztfq+wwo9lHdQ10ZBEO6+OWKeEYv/3yndbsFP1pld/2pq2UydC6cG fQOCK0Zuo00owskyHQKALddCDBs46vg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704348861; a=rsa-sha256; cv=none; b=maJTU2nf6CaiKjjxjn+FqG0wTiQjXZ3i8ZtfFE4QA57ViEdQmRu7+2tGWshWyU0dJO0F3s Jh+5YH0wvjDwUpyMtkZgd6TOUF+Htq1sZxC1qe4jYRdS1qBDE9FLW3ZdHZjqKT3EAAPzKQ rVOzGSbJAGYX7nOOOWiEzke6QX+fndk= Received: by verein.lst.de (Postfix, from userid 2407) id A63D168AFE; Thu, 4 Jan 2024 07:14:15 +0100 (CET) Date: Thu, 4 Jan 2024 07:14:15 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 04/15] xfs: remove xfile_stat Message-ID: <20240104061415.GB29011@lst.de> References: <20240103084126.513354-1-hch@lst.de> <20240103084126.513354-5-hch@lst.de> <20240103234533.GX361584@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103234533.GX361584@frogsfrogsfrogs> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: C8FE940015 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: usys3jxza535qhqnr3wok1j8ko4d9n5h X-HE-Tag: 1704348860-308765 X-HE-Meta: U2FsdGVkX1800i8XgN97594sg/ee7w1e91D7+zPCWg37vkGalf0DLexzqVUTDbKt2rXnPCkdEbfsPTCx6OTk3ntejN0s/jufMRAmg+AKjVxcV9yJAwjXumvfMyaagpz6qIQG7zuyw8tidjdXOaL18yncQkaSi06i0EvxDZp9RxLOft8Gcjsqb/HGTFHMaOXxGzKFDCgC2QTRo0zvEn0FXfvBwLzO+/b94geAGZhSk0etn1rIQEcT+qxp4Rl/gQoB1yC28UOqq7KNEgsxHSNOg8kzySzOEkBMBfW43BjjJCV7pU4cLqZN2xPMwcocp336CMOFiwym79zCAIHHBNzzE6hjFYmTC5b14ttwhjKowilL0n7eyahoy56jdrAdBM92hIfEfSLtjF7IJOvtwynru+xPIWfz0+5gv41/NWThV7Bf8QHaAJzgIkwEMF0QZIL278ssg219G4Pn33xqRTQGxs2Jh5zFRGaE+L93CjPlpVKuX0vBkJNN65wKoqK4gVtZmXTd/BVLlLQowgSx+82KGuKUoanwBAtU89AxTiW/HI6KaVLaPmA9i/P3+h9jtWGfVfvVPlu3suhHsdA1t2Hkb4SHNtx9ot88VRHrCtv+DNWylh/yrmEJS3vRW9U6xElzqVyV5Qg5vXuiMDEaLjvVE/4VpZqWkWEMikWaKpCkedAveJNC0nehQDx6fqNIAmU3oZoka8qG0Dh5Z4QmnZ677GVdrMnHalJon1WDVofidsTOOhE7ILkJSS73gr2/QNPacYyOq20/DIkFLZo9y5E3mwS63TTBPfXB75CHdruIEYpXArMt6WaXqWIDt9Zt9lMt1intQgj9D1sfA3CRXFx2KmIV8Q2fmLN8s76LAURx7gfbyfz3huYgXwaka0962pTruve//bOr0yYcPpV0W1OPEt3nBLXpQvnzjKm29GQE8kB8fgbTG/2DjRzCGb0CAmyQmuQx9j73qogUHV9Gxd1 twsa+ii3 8EHx7dX1RSUBppjf4xGH0gPE6L/l0L1kRhx3ZCqjLTgOfsOPnU+mLC7WMAIP5MoDH2guGqKzclPrJ64xt0TbKoZM7kA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 03, 2024 at 03:45:33PM -0800, Darrick J. Wong wrote: > > + __entry->bytes = inode->i_bytes; > > Shouldn't this be (i_blocks << 9) + i_bytes? Actually this should just be doing: __entry->bytes = inode->i_blocks << SECTOR_SHIFT; The bytes name here really confused me. Or we could change the trace point to just report i_block directly and not rename it to bytes and change the unit?