From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9E77C3DA6E for ; Thu, 4 Jan 2024 01:35:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B11D6B03BE; Wed, 3 Jan 2024 20:35:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 760F36B03BF; Wed, 3 Jan 2024 20:35:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 627796B03C0; Wed, 3 Jan 2024 20:35:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 51C986B03BE for ; Wed, 3 Jan 2024 20:35:10 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1850812019D for ; Thu, 4 Jan 2024 01:35:10 +0000 (UTC) X-FDA: 81639910380.07.0E0565F Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id E7E4C80016 for ; Thu, 4 Jan 2024 01:35:07 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GqTgjPal; spf=pass (imf02.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704332108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QbxU0Hj2gUJQVgWc4oyWm8lNMvir/6AyCLaOUX50ah0=; b=7VGkS34qEuWW8m8nLivrX2TCqV1xTxKs+jsIUQTxd05BSd+e6giQ4JwZSN4PNJnjf/slqF ObCknMZYRSek26pKcrGEeJPdPNpSiX4a5b7Knx/q/YwuXMNbey0iXMU37xdnO7J+VxYD+4 10ixOT5DZO/N92c0gDNJP4yVbohqo8A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704332108; a=rsa-sha256; cv=none; b=5OjVGmXiiGVoCKxZet6SFVhADznshVajIlQXkblYALcPF95gmBh6xO2iL8L6aTGY4/qLtd oPfXDOLIMAa4kxnJqsk+xoGKJDBEKV7EUSbMlcTtkaJbgAW/sH6kpbBhOE1FwuQ63dnGaV J9bCY7m5RnHkbKpLiHgNefT7qsWhO9Q= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GqTgjPal; spf=pass (imf02.hostedemail.com: domain of djwong@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 502ECCE18EA; Thu, 4 Jan 2024 01:35:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8610EC433C8; Thu, 4 Jan 2024 01:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704332102; bh=XK+/+y1prMNPU8PIEktemD7UgzhlD1W+6rMSbgtbEjY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GqTgjPalSK+YIG+HojeQ/wbSW3tROt9AEtmlVPBw8k1G8mSsh05pfl9ytngGfiFcK yP9M/mL8sbZ0/t50ZSuPdEGcSrJJbH0tprWK1xmDocKfi4eAggLtJOr/MMoo9oU6Ui rj009c559RSg/AWjvnutG7mWbdZaMX0aDW+w4hSIz/W9teDDvIBx79PykP0KaM4Wzx sbx2PVc/Fc/Z8luTk6xi2qS+8+F0UztJX/lmp7WiazLOEmwyDkr+4YY5qyeHjhjfQ4 8bizS6ilCkOwU1kLMoXmxRM64H49GII6EIUUwnKbuZ59onpWw/C00AwnjhM/UHOZPY y3KOOM7N4zxJA== Date: Wed, 3 Jan 2024 17:35:02 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Chandan Babu R , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: put the xfs xfile abstraction on a diet Message-ID: <20240104013502.GQ361584@frogsfrogsfrogs> References: <20240103084126.513354-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240103084126.513354-1-hch@lst.de> X-Rspamd-Queue-Id: E7E4C80016 X-Rspam-User: X-Stat-Signature: nheybqktfbrte39zyrnfs8kof58qq6st X-Rspamd-Server: rspam03 X-HE-Tag: 1704332107-109557 X-HE-Meta: U2FsdGVkX19F54bSPEIE44tpvYcPy/a4ffn2iNMgAef2CY5G2BXrabBpyBXYGRi1B9WBMRa0Qx43qh1DVJ1W65Ur209orqoQsn5zk0Euu8BteexnXaOQ32IFUk4ExepYjeQ1z7K4qlSV7UervrXG/AsmFT0MZYOaOZReh2aLom8QMPyeevIn5TaHDGVY3usHcHDeI+L54+d0ezakBD/LZoEboN49VS4e5ETFDUdbgZP3zrI02BX7zkyt8JW869VZJR/HCP25Xy6qUetBDapA6rVPTARmKj7VaVGQMbe7uBi1SuHNENAicIblcYBewEHoIet5HFKv/HT4dEG9COH6UmdZi7bYgigKoy4l69ptaMiA5M4nXqiS+t2fk8kh1XK6nBx1XRwW1S83hzg6E2GVBfEw+V1iQ4BV6plBc5/tLj9CQW7pgOig0eCr+yzg+qMgh8a5uHeWxOTxKDLcIk5AM8IRP3XFat1FnIez5Mln7uUcH8s5SEH495O/pSW8xez+wT7L8rNme5VE32N1Vq43xiKj2j8CyiTG5HkCfWyaQeq/VJLge+6k+jbT1rFhOUE0eKsxAY/TpvPPbrg27MaIc00kzc/PIFiv6l4KDQohaunmcUcoddPgW+JbwtN8dSYCNF/vo6a0xTniFSzN9fOaNHaJGmoPMTsl4JTkeNFfT77cU+PoOoJhjg4fgREDzo0nJhYp5NjLuc0cKP1CnZI+3JyLVhpgCrqjRQjle2ysgmo2XDhasjgg8vOHW+MDBmf8+Ntt/RPwibv1YKdNbMfW481C18zo+H9y6IOss86lIcYI6NrOFyTYLDFM9dPPDHEVkffUSyAQH2xHLwTJdwGTlzr9C/9L7T9gqfNtdOO3kY1lz693rZHWpkB2s2+Q1UOZyPZEK2PnHz5CmhV++znLSA5OxVb24DohCIvcXq+DqrUOuezlHMgD6pSoPNWphoOrY8t8MDXp2iLYAIqpZHa il9mjYYb uDJCNMg7AQscN+jrYbgSpi3MUSuxSP9/QbJO18H+S1W0BDEap5ppE5mO4Iec3TxR+np/4/zsDF2in/3Oaf50I7JIDzKpnboBZJQdlHjO35R+1PJUUCvxwMz4FoeD5k3Usny5nvxx8SqjFqGSi+4H0Gp6SQrsCk5pgDMPgTdfCOD+VW+pDs2Ze8sR2mQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000344, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 03, 2024 at 08:41:11AM +0000, Christoph Hellwig wrote: > Hi all, > > this series refactors and simplifies the code in the xfs xfile > abstraction, which is a thing layer on a kernel-use shmem file. > > Do do this is needs a slighly lower level export from shmem.c, > which I combined with improving an assert and documentation there. What's the base for this series? Is it xfs-linux for-next? Or djwong-wtf? --D > One thing I don't really like yet is that xfile is still based on > folios and not pages. The main stumbling block for that is the > mess around the hwpoison flag - that one still is per-file and not > per-folio, and shmem checks it weirdly often and not really in > at the abstractions levels where I'd expect it and feels very > different from the normal page cache code in filemap.c. Maybe > I'm just failing to understand why that is done, but especially > without comments explaining it it feels like it could use some > real attention first. > > Diffstat: > Documentation/filesystems/xfs/xfs-online-fsck-design.rst | 10 > fs/xfs/scrub/trace.h | 38 - > fs/xfs/scrub/xfarray.c | 60 -- > fs/xfs/scrub/xfarray.h | 3 > fs/xfs/scrub/xfile.c | 311 +++------------ > fs/xfs/scrub/xfile.h | 62 -- > mm/shmem.c | 24 + > 7 files changed, 143 insertions(+), 365 deletions(-) >